Numberformat exception

[Abhradeep Banerjee]

I am having this error when going to the menu of remove or delete can anyone help where is the problem?

Exception in thread "main" java.lang.NumberFormatException: For input string: "S8470017G"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:449)
at java.lang.Integer.<init>(Integer.java:660)
at Travel.compareTo(Travel.java:33)
at Travel.compareTo(Travel.java:1)
at java.util.Arrays.mergeSort(Arrays.java:1144)
at java.util.Arrays.sort(Arrays.java:1079)
at java.util.Collections.sort(Collections.java:117)
at lab6Ex1.main(lab6Ex1.java:110)
Java Result: 1



main method

 import java.io.*;
import java.util.*;

public class lab6Ex1 {

    public static void main(String[] args) {


        //declare variables FileReader, bufferedReader & inFile and line
        FileReader fr = null;
        BufferedReader br = null;
        String inFile = "Travel_Records.txt";
        String line = "";


        //declare variables for Menus Input_prompt, IC_Prompt,etc
        final String INPUT_PROMPT1 = "\nPlease select one of the following options: \n"
                + "1)   Search flights by IC number \n"
                + "2)   Search flights by departure date \n"
                + "3)   Display all flights \n"
                + "4)   Insert new record or remove old record \n"
                + "5)   Exit program ";

        final String IC_PROMPT = "\n\n\nPlease enter the IC number";
        final String Dept_PROMPT = "\n\n\nPlease enter the departure date in the following format" + "dd/mm/yyyy";
        final String Insert_Remove_PROMPT = "\n\n\n \n"
                + "1) Remove Record\n"
                + "2) Insert Record\n"
                + "3) Return to previous menu\n"
                + "4) Exit Program";

        final String Insert_Record = "Please enter new record in the following format: Serial Number|SXXXXXXXG|Name"
                + " | Country |MM/DD/YYYY | Time in 24 hr clock | Country | MM/DD/YYYY | Time in 24 hr clock";
        final String Delete_Record = "Please enter the serial number of the record to delete";
        //declare var to contain the record files


        String NRIC;
        String Name;
        String srcCountry;
        String deptDate;
        String deptTime;
        String destCountry;
        String arrDate;
        String arrTime;


        //declare and initiate new linked list

        LinkedList<Travel> LL = new LinkedList<Travel>();

        try {

            //initiate filereader and bufferedreader objects

            fr = new FileReader(inFile);
            br = new BufferedReader(fr);


            // while line is not null
            while ((line = br.readLine()) != null) {

                StringTokenizer tokenizer = new StringTokenizer(line, "|");
                
                NRIC = tokenizer.nextToken();
                Name = tokenizer.nextToken();

                srcCountry = tokenizer.nextToken();
                deptDate = tokenizer.nextToken();
                deptTime = tokenizer.nextToken();
                destCountry = tokenizer.nextToken();
                arrDate = tokenizer.nextToken();
                arrTime = tokenizer.nextToken();
                //create new Travel object
                Travel travel = new Travel(NRIC, Name, srcCountry, deptDate, deptTime, destCountry, arrDate, arrTime);

                //  this item object to Llist
                LL.addFirst(travel);

            }
            //close buffered reader
            br.close();
        } catch (FileNotFoundException e) {
            System.out.println("The file" + inFile + "was not found");
        } catch (IOException e) {
            System.out.println("Reading error");
        } finally {
            //close filereader
            if (fr != null) {
                try {
                    fr.close();
                } catch (IOException e) {
                    System.out.println("error closing file");
                }

            }

        }
        //create readers to read from user input
        try {
            BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
            System.out.println(INPUT_PROMPT1);
            //read one line from user
            line = reader.readLine();

            while (!line.equals("0")) {


                //read one line from user
                Collections.sort(LL);

                if (line.equals("1")) {
                    System.out.println(IC_PROMPT);

                    BufferedReader IC = new BufferedReader(new InputStreamReader(System.in));
                    line = IC.readLine();
                    for (int n = 0; n < LL.size(); n++) {

                        if (LL.get(n).NRIC.toUpperCase().contains(line.toUpperCase())) {

                            //printout information of the video
                            System.out.println(LL.get(n));

                        }
                    }
                } else if (line.equals("2")) {

                    System.out.println(Dept_PROMPT);
                    BufferedReader Dept = new BufferedReader(new InputStreamReader(System.in));
                    line = Dept.readLine();
                    for (int n = 0; n < LL.size(); n++) {

                        if (LL.get(n).deptDate.toUpperCase().contains(line.toUpperCase())) {

                            //printout information of the video
                            System.out.println(LL.get(n));
                        }
                    }
                } else if (line.equals("3")) {
                    for (int n = 0; n < LL.size(); n++) {
                        System.out.println(LL.get(n));
                    }

                } else if (line.equals("4")) {
                    System.out.println(Insert_Remove_PROMPT);
                    BufferedReader Insert = new BufferedReader(new InputStreamReader(System.in));
                    line = Insert.readLine();



                    if (line.equals("1")) {
                                System.out.println(Delete_Record);


                        BufferedReader delete = new BufferedReader(new InputStreamReader(System.in));
                        line = delete.readLine();

                        
                   for (int n = 0; n < LL.size(); n++) {
                    System.out.println(LL.get(n));
                    

                   
                       
                    }








                          FileWriter fwp = new FileWriter(inFile);
                            BufferedWriter bwp = new BufferedWriter(fwp);
                            PrintWriter outFile = new PrintWriter(bwp);





                        
                    } else if (line.equals("2")) {
                        System.out.println(Insert_Record);
                        BufferedReader insert = new BufferedReader(new InputStreamReader(System.in));
                        line = insert.readLine();


            FileWriter fwp = new FileWriter(inFile);
            BufferedWriter bwp = new BufferedWriter(fwp);
            PrintWriter outFile = new PrintWriter(bwp);


                        StringTokenizer tokenizer = new StringTokenizer(line, "|");
                        NRIC = tokenizer.nextToken();
                        Name = tokenizer.nextToken();
                        srcCountry = tokenizer.nextToken();
                        deptDate = tokenizer.nextToken();
                        deptTime = tokenizer.nextToken();
                        destCountry = tokenizer.nextToken();
                        arrDate = tokenizer.nextToken();
                        arrTime = tokenizer.nextToken();

                        //create new Travel object
                        Travel travel = new Travel(NRIC, Name, srcCountry, deptDate, deptTime, destCountry, arrDate, arrTime);

                        //add this item object to Llist
                        LL.add(travel);

                        for(int i = 0; i<LL.size(); i++)
                        {
                        outFile.println(LL.get(i));
                        }

                        outFile.close();



                    } else if (line.equals("3")) {
                    } else if (line.equals("4")) {

                        System.out.println("Are you sure you want to exit? Y/N");
                        BufferedReader exit = new BufferedReader(new InputStreamReader(System.in));
                        line = exit.readLine();
                        if (line.equalsIgnoreCase("Y")) {
                            System.exit(0);
                        }
                    }

                } else if (line.equals("5")) {
                    System.out.println("Are you sure you want to exit? Y/N");
                    BufferedReader exit = new BufferedReader(new InputStreamReader(System.in));
                    line = exit.readLine();
                    if (line.equalsIgnoreCase("Y")) {
                        System.exit(0);

                    } else {
                        System.out.println("Wrong entry");

                    }
                }
                System.out.println(INPUT_PROMPT1);
                line = reader.readLine();
            }
        } catch (IOException e) {
            System.out.println("error");
        }
    }
}
  

 public class Travel implements Comparable<Travel>  {

    // declare all var to contain the fields of a record

     String NRIC;
     String Name;
     String srcCountry;
     String deptDate;
     String deptTime;
     String destCountry;
     String arrDate;
     String arrTime;

    //creates constructor to store all the fields into the var

    public Travel(String NRIC, String Name, String srcCountry, String deptDate, String deptTime, String destCountry, String arrDate, String arrTime)
    {
        this.NRIC = NRIC;
        this.Name = Name;
        this.srcCountry = srcCountry;
        this.deptDate = deptDate;
        this.deptTime = deptTime;
        this.destCountry = destCountry;
        this.arrDate = arrDate;
        this.arrTime = arrTime;
        // create  a toString () method to return sting in the same delimited
        //format as input record
    }
        public String toString(){
            return(NRIC + "|" + Name + "|" + srcCountry + "|" +deptDate + "|" +deptTime + "|" +destCountry + "|" + arrDate + "|" + arrTime );
        }
public int compareTo(Travel LL){
    return new Integer(NRIC).compareTo(new Integer(LL.NRIC));
}
        
    }


   

text file

S8470017G|Abhradeep Banerjee | Singapore |09/07/2007 | 13:28 | Kolkata, India | 09/01/2010 | 16:28
S22209619B|Debabrata Banerjee | Kolkata, India |09/08/2007 | 13:28 | Singapore| 09/01/2010 | 16:28
S8328944B|Debabrata Banerjee | Kolkata, India |09/08/2007 | 13:28 | Singapore | 09/01/2010 | 16:28
S8470017G|Abhradeep Banerjee | Singapore |09/07/2007 | 13:28 | Kolkata, India | 09/07/2007 | 16:28
S8470017G|Abhradeep Banerjee | Kolkata, India |09/08/2007 | 13:28 | Singapore| 09/08/2007 | 16:28

Thanks

[Jan Hoppmann]

You compare two Integers in Travel.compareTo(Travel), and if you construct a new Integer object with a String, it tries to cast it to a number. But if you try to cast "S8470017G", for example, the S and G are no numbers, so you get this exception.

Try this:

return NRIC.compareTo(LL.NRIC);

This uses String.compareTo(String).

[Henry Wong]

Abhradeep Banerjee wrote:I am having this error when going to the menu of remove or delete can anyone help where is the problem?

Exception in thread "main" java.lang.NumberFormatException: For input string: "S8470017G"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:449)
at java.lang.Integer.<init>(Integer.java:660)
at Travel.compareTo(Travel.java:33)
at Travel.compareTo(Travel.java:1)
at java.util.Arrays.mergeSort(Arrays.java:1144)
at java.util.Arrays.sort(Arrays.java:1079)
at java.util.Collections.sort(Collections.java:117)
at lab6Ex1.main(lab6Ex1.java:110)
Java Result: 1

Basically, you are trying to call the collections sort() method, which will uses the Comparator interface... And your compareTo() method is trying to use the Integer comparator to compare two strings... And in converting the string, "S8470017G", to a Integer, it is failing -- as that is not a valid value for an integer.

[EDIT: Beaten to the answer again... ]

Henry

[Abhradeep Banerjee]

is it possible to use compareTo for Strings??

[Jan Hoppmann]

Yup, String has a CompareTo method, as you can see here:
http://download.oracle.com/docs/cd/E17409_01/javase/6/docs/api/java/lang/String.html

[Abhradeep Banerjee]

thanks Jan for the quick reply

[Michael Angstadt]

Remember that String is oblivious to numeric values. For example, "24" will come before "5" because the ascii value for "2" is less than the ascii value for "5".

[satish varma]

public int compareTo(Travel LL){  
    return new Integer(NRIC).compareTo(new Integer(LL.NRIC));
}   

instead of above code use below code, i think its work fine.(both are same)

public int compareTo(Object LL){
    Integer NRIC1=Integer.valueOf(NRIC);
    String s=((Travel)LL).NRIC;
    Integer NRIC2=Integer.valueOf(s);
    return NRIC1.compareTo(NRIC2); 
}
    

i think evrything is right in that code, the only problem is String characters entered as input values instead of Integer values, it causes NumberFormatException

[Abhradeep Banerjee]

i tried both ways as you have stated im still getting the error

Exception in thread "main" java.lang.NumberFormatException: For input string: "S8470017G"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:449)
at java.lang.Integer.<init>(Integer.java:660)
at Travel.compareTo(Travel.java:33)
at Travel.compareTo(Travel.java:2)
at java.util.Arrays.mergeSort(Arrays.java:1144)
at java.util.Arrays.sort(Arrays.java:1079)
at java.util.Collections.sort(Collections.java:117)
at lab6Ex1.main(lab6Ex1.java:110)
Java Result: 1

Can anyone help me please
Thanks

[Mithun Kulkarni]

As pointed out by Satish there is problem with your NRIC value. You need to parse the value from the input file and strip it to fetch only the number from that value.
Then it should work without any further change.

[Michael Angstadt]

Do you typically see letters inside of numbers? Is "123ABC456" a number? The answer is no because there are letters in it.

[Rob Spoor]

Michael Angstadt wrote:Do you typically see letters inside of numbers? Is "123ABC456" a number? The answer is no because there are letters in it.

Actually, I'd say yes, but only if you use HEX when parsing

[Michael Angstadt]

Rob Prime wrote:Actually, I'd say yes, but only if you use HEX when parsing

Oh hohoho, I've been had

[Campbell Ritchie]

Rob Prime wrote: . . . only if you use HEX when parsing

At least you were awake when you saw that. More than I was You can parse that with any radix ≥ 13.

[satish varma]

i tried both ways as you have stated im still getting the error

check what situations are causes NumberFormatException. see below example

Integer I=Integer.parseInt("10");//here no problem
Integer I=Integer.parseInt("TEN");//here raised NumberFormatException

i think same thing going on in this code, check once that only parse Integer values.