Problem with the "where" query.

[Deepti Gupta]

Hi,
I'm developing a small module and i'm facing a simple problem which i'm not able to solve.
I've to update my databse using the inputs from a JSP page.
the code for the updation is as follows:

  package net.roseindia;
import com.opensymphony.xwork2.ActionSupport;
import java.util.Date;
import java.sql.*;
import java.lang.*;

public class updateuser extends ActionSupport{
 public String execute() throws Exception{
  String url="jdbc:mysql://localhost/";
  String dbName="test";
  String driverName="com.mysql.jdbc.Driver";
  String userName="root";
  String password="";
  Connection con=null;

  Statement stmt=null;
  try{
      Class.forName(driverName).newInstance();
      con=DriverManager.getConnection(url+dbName,userName,password);
      stmt=con.createStatement();
     }
  catch(Exception e)
  {
     System.out.println(e.getMessage());
   }
   
  String oldusernme=getOldUsername();
  String usernme=getUsername();
  String pass=getPassword();
  String updateString = "update usergrp set username='"+usernme+"', pws='"+pass+"' where username='deepti'";
  int val = stmt.executeUpdate(updateString);
  if(val == 0)
 {
   addActionError("try again!");
   return ERROR;
}
 else
 {
   return SUCCESS;
}
}

private String oldusernme=null;
public String getOldUsername()
	{
	 return oldusernme;
	}

	void setOldUsername(String value)
	{
	 oldusernme=value;
    }
private String usernme = null;
public String  getUsername()
{
  return usernme;
}

public void setUsername(String value)
{
  usernme= value;
}

private String pass=null;
public String getPassword()
{
  return pass;
}

public void setPassword(String value)
{
 pass=value;
}



}
  

now in the line:

 String updateString = "update usergrp set username='"+usernme+"', pws='"+pass+"' where username='deepti'";
   

when i'm giving a constant after the "where" clause its working completely fine. But when i'm sending a variable using

 '"+oldusernme+"' 

or any other method its not working properly and is redirecting back to the jsp page to enter the details to be updated.

Please help

[Christophe Verré]

What does oldusernme contain ? Did you try to debug it ? I see you have a setter method with a funny name : void OldUsername(String value). Shouldn't this be void setOldUsername(String value) ?

[Deepti Gupta]

The oldusernme contains the user name that has to be updated. The update option gives us the facility to change the user name as well.

I've corrected the mistake and now it is void setOldUsername(String value)

[Christophe Verré]

Debug updateString. What does it contain ?

[Deepti Gupta]

i'm not using any IDE or editor. i'm using simple notepad. So i dont have any idea as to how to debug it.

[Christophe Verré]

It's ok. Use System.out.println(updateString); , and check the output logs.

[Deepti Gupta]

Can you suggest me where to use the System.out.println(updateString);

[Christophe Verré]

You have to check the content of the SQL, so :

String updateString = "update usergrp set username='"+usernme+"', pws='"+pass+"' where username='"+oldusernme+"'";  
System.out.println(updateString);
int val = stmt.executeUpdate(updateString);

[Deepti Gupta]

The problem is that the page gets redirected to either the update page or the gets directed to the page that has to be opened after the success of the operation. So i'm not able to see anything thats being printed. I need to hold the page from getting redirected.

[Christophe Verré]

Are you sure ? Did you check the logs ? I'm not talking about the web browser. Check the logs of your web container.

[Deepti Gupta]

This is what it is showing in the logs:

 2010-07-23 12:34:05,812 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.ListPeopleAction
2010-07-23 12:34:05,812 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.ListPeopleAction parent:null current:org.apache.struts2.showcase.person
2010-07-23 12:34:05,812 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.NewPersonAction
2010-07-23 12:34:05,812 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.NewPersonAction parent:null current:org.apache.struts2.showcase.person
2010-07-23 12:34:05,812 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.EditPersonAction
2010-07-23 12:34:05,812 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.EditPersonAction parent:null current:org.apache.struts2.showcase.person
update usergrp set username='deepti', pws='sed' where username='deepti'
update usergrp set username='deepti', pws='sed' where username='deepti'
   

[Christophe Verré]

Well, it looks fine Do you still have a user whose username is 'deepti' in your database ?

[Christophe Verré]

I think I smell the problem. You first executed :

"update usergrp set username='"+usernme+"', pws='"+pass+"' where username='deepti'"

This updated the 'deepti' user's username to a new name. Now there is no user called 'deepti' anymore. As I said in my previous post, check the database.

[Deepti Gupta]

Its working fine when i'm passing a constant after the where clause. But i need to pass a variable instead. I mean the code is:

  String updateString = "update usergrp set username='"+usernme+"', pws='"+pass+"' where username='"+oldusernme+"'";  

its not working then and the log shows:

 2010-07-23 12:44:40,015  INFO (com.opensymphony.xwork2.util.ResolverUtil:31) - Scanning for classes in [/C:/Program Files/Apache Software Foundation/Tomcat 6.0/webapps/struts2-showcase-2.1.8.1/WEB-INF/classes/org/apache/struts2/showcase/person/] matching criteria: org.apache.struts2.config.ClasspathPackageProvider$1@5e9db7
2010-07-23 12:44:40,031 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.EditPersonAction
2010-07-23 12:44:40,031 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.EditPersonAction parent:null current:org.apache.struts2.showcase.person
2010-07-23 12:44:40,031 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.NewPersonAction
2010-07-23 12:44:40,031 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.NewPersonAction parent:null current:org.apache.struts2.showcase.person
2010-07-23 12:44:40,031 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.ListPeopleAction
2010-07-23 12:44:40,031 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.ListPeopleAction parent:null current:org.apache.struts2.showcase.person
update usergrp set username='des', pws='desw' where username='null'   

see.. its not passing the oldusername to the database

[Christophe Verré]

That's a new step towards the solution oldusernme is null. Which means that setOldUsername is probably not called. You are using struts. What is the name of the input textfield ? Can you post your jsp file (or whatever file it is) as well ?

[Deepti Gupta]

ya sure.

This is my JSP file from where i'm sending the inputs:

<%@ taglib prefix="s" uri="/struts-tags" %>
<%@ page language="java" import="java.sql.*" %>
<html>
<head>
<title>Update User!</title>


</head>
<body>
<div align=right>
<a href="/struts2tutorial/roseindia/pages/losu.jsp">Main page</a>
<a href="<%= request.getContextPath() %>/roseindia/logout.action">Logout</a>

</div>

<center>
<img src="http://www.informationmadness.com/cms/images/stories/travel/abhibus.jpg"  width="150" height="100"/>
<s:form action="updateuser" method="POST">
<h4>Enter the details of the user</h4>
<tr>
<td colspan="2">

</td>

</tr>

  <tr>
   <td colspan="2">
         <s:actionerror />
         <s:fielderror />
   </td>
   <td>old details</td>
  </tr>

<s:textfield name="oldusername" label="Login name"/>


<tr>
 <td colspan="2">
      <s:actionerror />
	  <s:fielderror />
</td>
<td>new details</td>
<s:textfield name="username" label="Login name" />
<s:password name="password" label="Password" />
<s:submit value="update" align="center"/>

</s:form>

<br/>
<br/>
<br/>
<br/>
<footer>
© abhibus.com
</footer>
</center>
</body>

</html>

and this is the JAVA file:

  package net.roseindia;
import com.opensymphony.xwork2.ActionSupport;
import java.util.Date;
import java.sql.*;
import java.lang.*;

public class updateuser extends ActionSupport{
 public String execute() throws Exception{
  String url="jdbc:mysql://localhost/";
  String dbName="test";
  String driverName="com.mysql.jdbc.Driver";
  String userName="root";
  String password="";
  Connection con=null;

  Statement stmt=null;
  try{
      Class.forName(driverName).newInstance();
      con=DriverManager.getConnection(url+dbName,userName,password);
      stmt=con.createStatement();
     }
  catch(Exception e)
  {
     System.out.println(e.getMessage());
   }
   
  String oldusernme=getOldUsername();
  String usernme=getUsername();
  String pass=getPassword();
  String updateString = "update usergrp set username='"+usernme+"', pws='"+pass+"' where username='"+oldusernme+"'";
  int val = stmt.executeUpdate(updateString);
  if(val == 0)
 {
   addActionError("try again!");
   return ERROR;
}
 else
 {
   return SUCCESS;
}
}

private String oldusernme=null;
public String getOldUsername()
	{
	 return oldusernme;
	}

	void setOldUsername(String value)
	{
	 oldusernme=value;
    }
private String usernme = null;
public String  getUsername()
{
  return usernme;
}

public void setUsername(String value)
{
  usernme= value;
}

private String pass=null;
public String getPassword()
{
  return pass;
}

public void setPassword(String value)
{
 pass=value;
}



}  

[Christophe Verré]

Your field is called "oldusername", so the getter/setter should be respectively called getOldusername and setOldusername (note that the 'u' is not capitalized).

[Deepti Gupta]

I made the changes you suggested... but its still not working.

I am unable to give you the log since there is some problem with it and its not responding

[Christophe Verré]

Deepti Gupta wrote:I made the changes you suggested... but its still not working.

I am unable to give you the log since there is some problem with it and its not responding

Mmmhh... Restart the web container.

[Deepti Gupta]

I did.. I even restarted my machine twice...
but still its not responding.
The problem started after I used the System.out.println statement for checking the value of the password for the login page. The login pages is not logging after that and it is taking time to load that finally i have to cancel the process.

[Deepti Gupta]

I just solved the problem with my log.

now it is:

 2010-07-23 13:34:36,093  INFO (com.opensymphony.xwork2.util.ResolverUtil:31) - Scanning for classes in [/C:/Program Files/Apache Software Foundation/Tomcat 6.0/webapps/struts2-showcase-2.1.8.1/WEB-INF/classes/org/apache/struts2/showcase/person/] matching criteria: org.apache.struts2.config.ClasspathPackageProvider$1@13a1778
2010-07-23 13:34:36,109 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.ListPeopleAction
2010-07-23 13:34:36,109 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.ListPeopleAction parent:null current:org.apache.struts2.showcase.person
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.NewPersonAction
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.NewPersonAction parent:null current:org.apache.struts2.showcase.person
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.EditPersonAction
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.EditPersonAction parent:null current:org.apache.struts2.showcase.person
update usergrp set username='dees', pws='des' where username='null'   

The problem still remains

[Christophe Verré]

After opening the log file, did you leave it open ? If yes, close it.

[Christophe Verré]

Also, make the setOldusername public :

public void setOldusername(String value) {  
	oldusernme=value;  
}

[Deepti Gupta]

The problem is still there:

  2010-07-23 13:34:36,093  INFO (com.opensymphony.xwork2.util.ResolverUtil:31) - Scanning for classes in [/C:/Program Files/Apache Software Foundation/Tomcat 6.0/webapps/struts2-showcase-2.1.8.1/WEB-INF/classes/org/apache/struts2/showcase/person/] matching criteria: org.apache.struts2.config.ClasspathPackageProvider$1@13a1778  
2010-07-23 13:34:36,109 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.ListPeopleAction   
2010-07-23 13:34:36,109 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.ListPeopleAction parent:null current:org.apache.struts2.showcase.person   
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.NewPersonAction   
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.NewPersonAction parent:null current:org.apache.struts2.showcase.person   
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - ClasspathPackageProvider: Processing class org.apache.struts2.showcase.person.EditPersonAction   
2010-07-23 13:34:36,125 DEBUG (org.apache.struts2.config.ClasspathPackageProvider:57) - class:class org.apache.struts2.showcase.person.EditPersonAction parent:null current:org.apache.struts2.showcase.person   
update usergrp set username='dees', pws='des' where username='null'     
  

[Deepti Gupta]

solved....


Thanks...

[Christophe Verré]

I'm glad it's fixed.