Jtable CellEditor

[Antony Amicone]

hi i have a table t, i fill the table with database query ( 5 column )

textfieldcelleditor = new JTextField();
celleditor = new DefaultCellEditor(textfieldcelleditor);
t.getColumnModel().getColumn(1).setCellEditor(celleditor);

i should have the first column editable if i understood how it works, why it doesnt?


this is the table, but then i fill with a database query

   jTable1.setAutoCreateRowSorter(true);
        jTable1.setModel(new javax.swing.table.DefaultTableModel(
            new Object [][] {

            },
            new String [] {
                "Recipes"
            }
        ) {
            Class[] types = new Class [] {
                java.lang.String.class
            };

            public Class getColumnClass(int columnIndex) {
                return types [columnIndex];
            }
        });
        jTable1.setEditingColumn(0);
        jTable1.setEditingRow(0);
        jTable1.setName("jTable1"); // NOI18N
        jTable1.setSelectionMode(javax.swing.ListSelectionModel.SINGLE_SELECTION);
        jScrollPane1.setViewportView(jTable1);
        jTable1.getColumnModel().getSelectionModel().setSelectionMode(javax.swing.ListSelectionModel.SINGLE_SELECTION);
        jTable1.getColumnModel().getColumn(0).setHeaderValue(resourceMap.getString("jTable1.columnModel.title0")); // NOI18N
 

[Rob Camick]

Editing is controlled by the isCellEditable() method of the TableModel or the JTable. By default when using a DefaultTableModel all cells are editable so I don't know what your problem is.

Post your SSCCE showing the problem.

[Antony Amicone]

my classes are really big to get easily a SSCCE cause i used netbeans to make dialogs

on the upper post i posted the code related to table.
is it possibile to find the error there??

i think my problem is in CellEditor, dunnow good how to use it

 url = "jdbc:odbc:Driver={Microsoft Access Driver (*.mdb)};DBQ=";
                url += "C:\\Database3.mdb;DriverID=22;READONLY=false";
                query = "SELECT Recipe,Servings,timeToEat,levela,Recipekind FROM Recipes";

                rstm = new Datab("sun.jdbc.odbc.JdbcOdbcDriver",url,query);
                t.setModel(rstm);
                textfieldcelleditor = new JTextField();
                celleditor = new DefaultCellEditor(textfieldcelleditor);
                String xcol[] = {"1","2","3","4","5"};                
                ColumnIdentifier colindentif = new ColumnIdentifier(xcol);// error here
                t.getColumnModel().getColumnIndex(colidentif);.setCellEditor(celleditor);
                System.out.println(t.getColumnModel().getColumn(1));

[pete stein]

Antony Amicone wrote:my classes are really big to get easily a SSCCE cause i used netbeans to make dialogs

Which is hampering your ability to learn Swing. I strongly urge you to do your Swing coding by hand and to study the Swing tutorials, and you won't be having this and your other problems (i.e., in your Dialogs thread).

Just my 2 cents worth.

[Antony Amicone]

oh i know, i usually write dialog by hand, but this time i wanted to try
can you help me with that?

[Antony Amicone]

  public Datab(String driver, String url, String query) throws SQLException, ClassNotFoundException {
    Class.forName(driver);
    conn = DriverManager.getConnection(url);
    st = conn.createStatement(rs.TYPE_SCROLL_INSENSITIVE,rs.CONCUR_READ_ONLY);
    if ( query.substring(0,3).equalsIgnoreCase("INS") ) { st.executeUpdate(query); }
    else { rs = st.executeQuery(query); 
    rsmd = rs.getMetaData();
    rs.last();
    rows = rs.getRow();
    }
    fireTableStructureChanged();
}  

can be here my problem? i tried to change rs. not just to readonly and not insensitive, but is the same

[Paul Clapham]

If your table cell is not editable, and you don't know why, the problem is in how you configured the table. Database code could
have absolutely nothing to do with that.

[Antony Amicone]

Paul Clapham wrote:If your table cell is not editable, and you don't know why, the problem is in how you configured the table. Database code could
have absolutely nothing to do with that.

and what is wrong in the table??? i put upside the code but i think is all ok

[Antony Amicone]

helpppppppp

[Rob Camick]

You've been given plenty of help, but refuse to post a SSCCE so we can't give you anymore help.

[Antony Amicone]

it takes a lot but hope all is ok now for you to check, heeeeeeeeeeeeeelp me

  /*
 * DesktopApplication1SCCView.java
 */

package desktopapplication1scc;

import org.jdesktop.application.Action;
import org.jdesktop.application.ResourceMap;
import org.jdesktop.application.SingleFrameApplication;
import org.jdesktop.application.FrameView;
import org.jdesktop.application.TaskMonitor;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.Timer;
import javax.swing.Icon;
import javax.swing.JDialog;
import javax.swing.JFrame;
import java.net.*;
import java.sql.*;

/**
 * The application's main frame.
 */
public class DesktopApplication1SCCView extends FrameView {

    public DesktopApplication1SCCView(SingleFrameApplication app) {
        super(app);

        anto = DesktopApplication1SCCView.this;
        initComponents();
        ResourceMap resourceMap = getResourceMap();
        int messageTimeout = resourceMap.getInteger("StatusBar.messageTimeout");
        TbEvent handler2 = new TbEvent(jButton1,url,conn,jTable1);
        jButton1.addActionListener(handler2);
    }

    // <editor-fold defaultstate="collapsed" desc="Generated Code">
    private void initComponents() {

        mainPanel = new javax.swing.JPanel();
        jScrollPane1 = new javax.swing.JScrollPane();
        jTable1 = new javax.swing.JTable();
        jButton1 = new javax.swing.JButton();
        mainPanel.setName("mainPanel"); // NOI18N
        jScrollPane1.setName("jScrollPane1"); // NOI18N
        jTable1.setModel(new javax.swing.table.DefaultTableModel(
        ));
        jTable1.setName("jTable1");
        jScrollPane1.setViewportView(jTable1);
        jScrollPane1.setName("jScrollPane1"); // NOI18N

        jTable1.setAutoCreateRowSorter(true);
        jTable1.setModel(new javax.swing.table.DefaultTableModel(
            new Object [][] {

            },
            new String [] {
                "Recipes"
            }
        ) {
            Class[] types = new Class [] {
                java.lang.String.class
            };

            public Class getColumnClass(int columnIndex) {
                return types [columnIndex];
            }
        });
        jTable1.setCellSelectionEnabled(true);
        jTable1.setEditingColumn(0);
        jTable1.setEditingRow(1);
        jTable1.setSelectionMode(javax.swing.ListSelectionModel.SINGLE_SELECTION);
        jScrollPane1.setViewportView(jTable1);
        jTable1.getColumnModel().getSelectionModel().setSelectionMode(javax.swing.ListSelectionModel.SINGLE_SELECTION);
        jTable1.getColumnModel().getColumn(0).setHeaderValue("jTable1.columnModel.title0"); // NOI18N

        org.jdesktop.application.ResourceMap resourceMap = org.jdesktop.application.Application.getInstance(desktopapplication1scc.DesktopApplication1SCC.class).getContext().getResourceMap(DesktopApplication1SCCView.class);
        jButton1.setText(resourceMap.getString("jButton1.text")); // NOI18N
        jButton1.setName("jButton1"); // NOI18N

        javax.swing.GroupLayout mainPanelLayout = new javax.swing.GroupLayout(mainPanel);
        mainPanel.setLayout(mainPanelLayout);
        mainPanelLayout.setHorizontalGroup(
            mainPanelLayout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(mainPanelLayout.createSequentialGroup()
                .addContainerGap()
                .addGroup(mainPanelLayout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
                    .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 442, Short.MAX_VALUE)
                    .addComponent(jButton1))
                .addContainerGap())
        );
        mainPanelLayout.setVerticalGroup(
            mainPanelLayout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(javax.swing.GroupLayout.Alignment.TRAILING, mainPanelLayout.createSequentialGroup()
                .addContainerGap(23, Short.MAX_VALUE)
                .addComponent(jButton1)
                .addGap(18, 18, 18)
                .addComponent(jScrollPane1, javax.swing.GroupLayout.PREFERRED_SIZE, 298, javax.swing.GroupLayout.PREFERRED_SIZE)
                .addContainerGap())
        );

        setComponent(mainPanel);
    }// </editor-fold>

    private javax.swing.JButton jButton1;
    private javax.swing.JScrollPane jScrollPane1;
    private javax.swing.JTable jTable1;
    private javax.swing.JPanel mainPanel;
    private Connection conn;
    private String url;
    private DesktopApplication1SCCView anto;

}
 

 
package desktopapplication1scc;

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import javax.swing.table.*;
import java.net.*;
import java.sql.*;
import java.util.Vector;
import javax.swing.table.DefaultTableModel;

public class TbEvent implements ActionListener {

    private JButton searchButton;
    private String url;
    private Connection c;
    private JTable t;
    
    private ResultSet rs;
    private ResultSetMetaData rsmd;
    private Datab rstm;
    private int rows;

    private String query;
    private Recipes r;
    private DesktopApplication1SCCView a;
    private JTextField textfieldcelleditor;
    private DefaultCellEditor celleditor;


    public void actionPerformed(ActionEvent event) {

        try{
            
     
         if ( event.getSource() == searchButton ) {
                
                url = "jdbc:odbc:Driver={Microsoft Access Driver (*.mdb)};DBQ=";
                url += "C:\\Database3.mdb;DriverID=22;READONLY=false";
                query = "SELECT Recipe,Servings,timeToEat,levela,Recipekind FROM Recipes";

                rstm = new Datab("sun.jdbc.odbc.JdbcOdbcDriver",url,query);
                t.setModel(rstm);
                textfieldcelleditor = new JTextField();
                celleditor = new DefaultCellEditor(textfieldcelleditor);
                t.setCellEditor(celleditor);
                Vector xcol = new Vector();
                xcol.add("Recipe"); xcol.add("Servings");
               // setColumnIdentifiers(xcol);
               // t.getColumnModel().getColumnIndex("Recipe").setCellEditor(celleditor);
                System.out.println(t.getColumnModel().getColumn(1));


            }


        }catch(Exception e){
           e.printStackTrace();
        }
    }

public TbEvent(JButton t3, String out, Connection conn, JTable table) {
    searchButton = t3;
    url = out;
    c = conn;
    t = table;
}

}
  

  package desktopapplication1scc;

import java.util.*;
import java.sql.*;
import javax.swing.table.*;
/**
 *
 * @author Antonio
 */
public class Datab extends AbstractTableModel {

    private Connection conn;
    private Statement st;
    private ResultSet rs;
    private ResultSetMetaData rsmd;
    private int rows;

public Datab(String driver, String url, String query) throws SQLException, ClassNotFoundException {
    Class.forName(driver);
    conn = DriverManager.getConnection(url);
    st = conn.createStatement(rs.TYPE_SCROLL_INSENSITIVE,rs.CONCUR_READ_ONLY);
    if ( query.substring(0,3).equalsIgnoreCase("INS") ) { st.executeUpdate(query); }
    else { rs = st.executeQuery(query); 
    rsmd = rs.getMetaData();
    rs.last();
    rows = rs.getRow();
    }
    fireTableStructureChanged();
}


 public String getColumnName(int column){
    try{
        return rsmd.getColumnName(column+1);
    }catch(Exception e){
        e.printStackTrace();
    }
    return "";
}

public int getColumnCount(){
    try{
        return rsmd.getColumnCount();
    }catch(Exception e){
        e.printStackTrace();
    }
    return 0;
}

public int getRowCount(){
     try{
        return rows;
    }catch(Exception e){
        e.printStackTrace();
    }
    return 0;
}

public Object getValueAt(int row, int column){
    try{
        rs.absolute(row+1);
        return rs.getObject(column+1);
    }catch(Exception e){
        e.printStackTrace();
    }
    return "";
}


}

  

[Antony Amicone]

and this is the main class

/*
 * DesktopApplication1SCC.java
 */

package desktopapplication1scc;

import org.jdesktop.application.Application;
import org.jdesktop.application.SingleFrameApplication;

/**
 * The main class of the application.
 */
public class DesktopApplication1SCC extends SingleFrameApplication {

    /**
     * At startup create and show the main frame of the application.
     */
    @Override protected void startup() {
        show(new DesktopApplication1SCCView(this));
    }

    /**
     * This method is to initialize the specified window by injecting resources.
     * Windows shown in our application come fully initialized from the GUI
     * builder, so this additional configuration is not needed.
     */
    @Override protected void configureWindow(java.awt.Window root) {
    }

    /**
     * A convenient static getter for the application instance.
     * @return the instance of DesktopApplication1SCC
     */
    public static DesktopApplication1SCC getApplication() {
        return Application.getInstance(DesktopApplication1SCC.class);
    }

    /**
     * Main method launching the application.
     */
    public static void main(String[] args) {
        launch(DesktopApplication1SCC.class, args);
    }
}

[Paul Clapham]

Unfortunately that code requires us to be running Netbeans and it requires us to have a MS Access database of a
certain form at a certain place in the root directory of our C drive on our computer which is required to be running
Windows.

There's a lot more stuff in that code which isn't relevant to your question, too.

So if you remove the database access and replace it by hard-coded data, and get rid of all of the Netbeans-related
classes (that's org.desktop.whatever), that would be a good start. All you need to study this problem is a simple class
which has a JTable and nothing else.

[Antony Amicone]

Paul Clapham wrote:Unfortunately that code requires us to be running Netbeans and it requires us to have a MS Access database of a
certain form at a certain place in the root directory of our C drive on our computer which is required to be running
Windows.

There's a lot more stuff in that code which isn't relevant to your question, too.

So if you remove the database access and replace it by hard-coded data, and get rid of all of the Netbeans-related
classes (that's org.desktop.whatever), that would be a good start. All you need to study this problem is a simple class
which has a JTable and nothing else.

cant you help me with this code? dont consider the db if is not needed, or i can attach the file

[Antony Amicone]

     
            DefaultTableModel model = new DefaultTableModel();
                t.setModel(model);
JTable table = new JTable(model);

// Create a couple of columns
model.addColumn("Col1");
model.addColumn("Col2");

// Create the first row
model.insertRow(0, new Object[]{"r1"});

// Insert a row so that it becomes the first row
model.insertRow(0, new Object[]{"r2"});  

i changed the database value with this, and the table allow me editing so the problem is probably in the database... WHERE?!?!?!?!

I changed my Datab class extension, instead of an AbstractTableModel i put DefaultTableModel... and works
is there another way?

[Rob Camick]

The database has nothing to do with editing. All the database does is provide data.

Editing is controlled by the isCellEditable() method of the TableModel. When using a DefaultTableModel this method allows all columns to be edited. When extending the AbstractTableModel the default is to not allow editing. So if you want editing you need to implement the method in your custom model.

[Antony Amicone]

Rob Camick wrote:The database has nothing to do with editing. All the database does is provide data.

Editing is controlled by the isCellEditable() method of the TableModel. When using a DefaultTableModel this method allows all columns to be edited. When extending the AbstractTableModel the default is to not allow editing. So if you want editing you need to implement the method in your custom model.

ok so i just change
public class Datab extends AbstractTableModel {
in
public class Datab extends DefaultTableModel {

and it let me edit, but when i click on one cell it show this error

Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 2 >= 0
at java.util.Vector.elementAt(Vector.java:427)
at javax.swing.table.DefaultTableModel.setValueAt(DefaultTableModel.java:648)
at javax.swing.JTable.setValueAt(JTable.java:2719)
at javax.swing.JTable.editingStopped(JTable.java:4721)
at javax.swing.AbstractCellEditor.fireEditingStopped(AbstractCellEditor.java:125)
at javax.swing.DefaultCellEditor$EditorDelegate.stopCellEditing(DefaultCellEditor.java:350)
at javax.swing.DefaultCellEditor.stopCellEditing(DefaultCellEditor.java:215)
at javax.swing.JTable$GenericEditor.stopCellEditing(JTable.java:5475)
at javax.swing.plaf.basic.BasicTableUI$Handler.mousePressed(BasicTableUI.java:986)
at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:263)
at java.awt.Component.processMouseEvent(Component.java:6260)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:6028)
at java.awt.Container.processEvent(Container.java:2041)
at java.awt.Component.dispatchEventImpl(Component.java:4630)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4235)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
at java.awt.Container.dispatchEventImpl(Container.java:2085)
at java.awt.Window.dispatchEventImpl(Window.java:2475)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)



then when i edit a cell, it continue to be on "edit" till i press ESC, why?

which method should i care bout?

[Rob Camick]

You haven't posted a proper SSCCE so I don't know the answer and will not bother to answer again until I see a SSCCE.