Why is my string still writing data to my file that i've asked it not to?

[Nick Rowe]

Basically i have a program to read in the contents of a folder and capture instances of a substring stored between two strings. I want the instances of the substring called "resourceline" to be stored within an array and then sorted and printed into a new document.

However i only want the instances to be stored IF they dont already exist and if the string does not contain certain symbols. I am doing this because i get too much irrelevant data come accross.
The problem is the progam is working but still writing data that i dont want.

please help
regards S

my code is below

 
  
 /** Imported Java Libraries */
import java.io.BufferedReader;   
import java.io.File;   
import java.io.FileNotFoundException;   
import java.io.FileReader;   
import java.io.IOException;   
import java.util.ArrayList;   
import java.util.regex.Matcher;   
import java.util.regex.Pattern;   
import java.util.Collections;   
import java.util.List;   
import java.io.PrintWriter;   
import java.io.FileWriter;   
  
/** class to find string */  
public class Find {   
  
    BufferedReader br = null;   
  
    /** method to find the value between the beginning and end of a string*/  
    public Find(String fileName, String begin, String end,String whereToWrite) throws java.io.IOException {   
        try {   
            /** read in file */  
            String resourceline = null;   
            ArrayList<String> arrayList = new ArrayList<String>();   
            File myDir = new File("C:\\Documents and Settings\\Kieren McDonald\\Desktop\\Nick\\Java\\Test\\resources");   
            if (myDir.exists() && myDir.isDirectory()) {   
                File[] files = myDir.listFiles();   
                for (int i = 0; i < files.length; i++) {   
                    br = new BufferedReader(new FileReader(files[i]));   
                    while ((resourceline = br.readLine()) != null) {   
                        resourceline = find(begin, end, resourceline);   
                        if (resourceline != null) {
							resourceline = resourceline.trim();
						    boolean checkContains1=resourceline.contains("$");
							boolean checkContains2=resourceline.contains("=");
							boolean checkContains3=resourceline.contains("\>");
							boolean checkContains4=resourceline.contains(":");
							boolean checkContains4=resourceline.contains(".");
							if (checkContains1 || checkContains2 || checkContains3 || checkContains4 || checkContains5)
							{
								  
							}
							if (arrayList.contains(resourceline)){
								  
							}
						
						    else{      
                                 arrayList.add(resourceline);   
  
                                }
						}								
  
					}  
                    System.out.println("/**This Is A List Of Includes Within The Component*/");					
                    sortAndPrint(arrayList);
                    System.out.println("/*******This Is The End Of The list Of Includes*******/");					
                    writeResults(arrayList, "C:\\Documents and Settings\\Kieren McDonald\\Desktop\\Nick\\Java\\Test\\filetest.txt");   
                }   
            } else {   
                System.out.println("This is not a directory");   
            }   
  
            /**  
             * declaring string identifiers for beginning and end of string  
             * aswel as one other line string to store the data between  
             */  
            /** while line is not equal to null then find 3 string values */  
        } catch (FileNotFoundException ex) {   
            ex.printStackTrace();   
        } finally {   
            br.close();   
        }   
    }   
  
    /** method to sort and print the array collection */  
    private void sortAndPrint(List<String> results) {   
        Collections.sort(results, String.CASE_INSENSITIVE_ORDER);   
        for (String resourceline : results) {   
            System.out.println(resourceline);   
        }   
    }   
  
    /** method to find the value between the beginning and end of a string  
     */  
    public String find(String beg, String end, String resourceline) {   
        /** match pattern to store string between strings and match to line */  
        Pattern p = Pattern.compile(beg + "(.*)" + end);   
        Matcher m = p.matcher(resourceline);   
        return m.find() ? resourceline.substring(m.start(1), m.end(1)) : null;   
    }   
  
    /** method to print the results of the array into a new document */  
    private void writeResults(ArrayList<String> arrayList, String filename) {   
        try {   
            PrintWriter writer = new PrintWriter(filename);   
  
            for (String resourceline : arrayList) {   
                writer.println(resourceline);   
            }   
            System.err.println("/***Your Data Has Been Written To The File Successfully ");   
            writer.close();   
        } catch (Exception e) {   
            System.out.println("can't create output file \"" + filename + "\"");   
            e.printStackTrace();   
        }   
    }    
  
    /** main method to find the resource name calling */  
	public static void main(String[] args) throws IOException
    {   
       Find f = new Find("myDir", "<\\$", "=", "C:\\Documents and Settings\\Kieren McDonald\\Desktop\\Nick\\Java\\Test\\filetest.txt");   
	}   
	 
	 
	 
	} 

[akhter wahab]

provide one example what you are providing the input, what it gives the output and what you want to desire from this code ........

[Prabhakar Reddy Bokka]

  if (checkContains1 || checkContains2 || checkContains3 || checkContains4 || checkContains5)   
                            {   
                                     
                            }   

Use && in place of || and check. Hope it works fine now.

[David Newton]

Prabhakar Reddy Bokka wrote:Use && in place of || and check.

No, that would mean the "blank" code would execute only if *all* of the conditions are met; my understanding is that if *any* of the characters are found it's a match.

(I realize it's hard to tell because of the strange nature of the code.)

[David Newton]

@Nick: Again--PLEASE post compilable code. There are three errors in this source.

[Ernest Friedman-Hill]

As I see it, this should follow your requirement about duplicates, but ignore your requirement about special characters. There are two completely unconnected conditionals: the first one, "if (checkContains1...", controls access to an empty block, so it does absolutely nothing. Then the next conditional is tested regardless of the outcome of the first. It checks for duplicates, and otherwise then adds the line to the list.

If your "checkContains" check had a "continue" in it, or if it was attached to the later conditional with an "else", then we'd be getting somewhere.