random numbers, returns a negative number?

[matthew christensen]

hey guys im new to coderanch.

im having some problem wit this code. its generating a random number, but its negative and i cant figure out why. im writing a text-based-rpg-combat-system.

   


package grogvskroh;

import java.util.*;
import java.math.*;
import java.io.*;
import java.awt.*;

public class grog extends  StartGame
{
 

    public void grogAttack()
    {
     Random grogRand = new Random();
     // makes random numberfor grogs attack pwoer

     grogattkpwer =  1+grogRand.nextInt(9); // problem here
     // damage being done to AI

     int dmg = grogattkpwer - AIdef;

     System.out.println("SYSTEM_TEST: damage done " + dmg + " attack power" + grogattkpwer);

     AIhp = AIhp - dmg;

     System.out.println("SYSTEM_TEST: " + AIhp);
        if(AIdef >= grogattkpwer) // checks to see if the ai's def is greater or equal to grogs attak power
        {
            System.out.println("AI deflected damage!");

        }
    }
    public void GrogIsDead()
    {
        // work is progress
    }
}


 

it gets its variables from this class

   



package grogvskroh;

import java.util.*;
import java.math.*;
import java.io.*;
import java.awt.*;

public class StartGame extends Main
{

    public int groghp = 100;
    public int grogmana = 150;
    public int grogattkpwer;
    public int grogdef = 5;
    // grogs stats

    public int AIhp = 100;
    public int AImana = 150;
    public int AIattkpwer;
    public int AIdef = 5;
    // AI stats

    public void StartGame()
    {
        System.out.println("Game started");

        for(int attacks = 0; attacks <= 5; attacks++)
        {
            grog grogobj = new grog();
            grogobj.grogAttack();

            AI aiobj = new AI();
            aiobj.AIattack();
        }
    }
}

not sure what the big deal is, no compiler errors come up
im using netbeans 6.9.1 and jdk 6_21

[fred rosenberger]

not sure why you say you're getting negative numbers...taking the least amount of your code as possible:

import java.util.*;

public class Grog
{
    public static void main(String [] args)
    {
     Random grogRand = new Random();
     int grogattkpwer =  1+grogRand.nextInt(9); // problem here
     System.out.println("value is " + grogattkpwer);
    }
}

I didn't get a negative value once.

I'd suggest putting more S.o.p.'s in your code and see what it's really doing.

[David Newton]

Agreed; there's no way the random number itself is negative.

[Campbell Ritchie]

. . . and welcome to the Ranch

[Mohamed Omar]

sorry if this is a late reply, I saw this post just now.

the problem with your code is that your subtracting the dmg (which is already negative) from AIhp resulting an increase in the AIhp. you should change it to

  
AIhp = AIhp + dmg;
  

[Campbell Ritchie]

Mohamed Omar, welcome to JavaRanch And thank you for finally finding the error

[Mohamed Omar]

Your welcome