spring mvc validator

[indu iyengar]

hi all,

code for StudentLogin-servlet.xml

  <bean id="logOnController" class="com.controllers.LoginController">
       <property name="validator"><ref bean="logValidator"/></property>
       <property name="formView" value="LoginForm"></property>
	   <property name="successView" value="LoginSuccess"></property>
	   <property name="commandName" value="student"></property>
	   <property name="commandClass" value="student.LoginStudent"></property>
	   <property name="sessionForm"><value>true</value></property> 
   </bean>
   
    <bean id="urlMapping" class="org.springframework.web.servlet.handler.SimpleUrlHandlerMapping">
      <property name="urlMap">
		<map>
		<entry key="/login.htm"><ref bean="logOnController"/></entry>
	</map>
     	</property>
     </bean>
<bean id="logValidator" class="com.validate.LogonValidator"></bean>  

results in the exception

 java.lang.IllegalArgumentException: Cannot convert value of type [com.validate.LogonValidator] to required type [org.springframework.validation.Validator] for property 'validator': no matching editors or conversion strategy found   

please help to solve this..
thanks
indu

[David O'Meara]

Does your LoginValidator class extend Validator? (or implement, since it is an interface)

[indu iyengar]

thanks for your reply,
yes, my loginvalidator implements validator by implementing supports() and validate() methods..

 public boolean supports(Class clazz) {
		// TODO Auto-generated method stub
		return LoginStudent.class.isAssignableFrom(clazz);
	}
	@Override
	public void validate(Object command, Errors errors) {
		System.out.println("in validate ****** ");
		LoginStudent student = (LoginStudent)command;
						
		ValidationUtils.rejectIfEmpty(errors, "stid", "required.username");
    	ValidationUtils.rejectIfEmpty(errors, "stpw", "required.password");

    	if (student.getStid().length()==0)
    		errors.rejectValue("stid","user.required");
    	if (student.getStpw().length()==0)
    		errors.rejectValue("stpw","pw.required");
	}   

 org.springframework.beans.BeanInstantiationException: Could not instantiate bean class [org.springframework.context.MessageSource]: Specified class is an interface   

why am getting these type of erros ?

code in my StudentLogin-servlet.xml

<bean id="viewResolver" class="org.springframework.web.servlet.view.InternalResourceViewResolver">
        <property name="viewClass" value="org.springframework.web.servlet.view.JstlView"/>
        <property name="prefix" value="/"/>
        <property name="suffix" value=".jsp"/>
    </bean>
   
    <bean name="/login.htm" class="com.controllers.LoginController">
       <property name="validator"><ref bean="logValidator"/></property>
       <property name="formView" value="LoginForm"></property>
	   <property name="successView" value="LoginSuccess"></property>
	   <property name="commandName" value="student"></property>
	   <property name="commandClass" value="student.LoginStudent"></property>
	   <property name="sessionForm" value="true"></property> 
   </bean>
        
       <bean id="logValidator" class="com.validate.LogonValidator"></bean>
  <!--  registering the error properties file -->
  
  <bean id="messageSource" class="org.springframework.context.MessageSource">
     <property name="basename" value="messages"></property>
  </bean>    

please any one have an idea ?please help me..

[Prasad Krishnegowda]

In your StudentLogin-servlet.xml, the below part

  <bean id="messageSource" class="org.springframework.context.MessageSource">  
      <property name="basename" value="messages"></property>  
   </bean>          

should be changed to

  <bean id="messageSource" class="org.springframework.context.support.ResourceBundleMessageSource">  
      <property name="basename" value="messages"></property>  
   </bean>          

Since, MessageSource is an interface not a class, and ResourceBundleMessageSource is a class..

[David O'Meara]

You may not care, but I prefer

 public boolean supports(Class<?> clazz) {  
         return LoginStudent.class.isAssignableFrom(clazz);  
     }      

(note the <?> in the method signature)

[indu iyengar]

thanks for your quick reply..
I changed as you said

<bean id="messageSource" class="org.springframework.context.support.ResourceBundleMessageSource">
     <property name="basename" value="messages"></property>
  </bean>    

now it shows the exception as ...

org.springframework.beans.factory.BeanNotOfRequiredTypeException: Bean named 'messageSource' must be of type [org.springframework.context.MessageSource], but was actually of type [org.springframework.context.support.ResourceBundleMessageSource]
    

oh! sorry David, just now I saw your reply.. when I change as you said , it is not accepting ..its showing the error as "NameClash"

public boolean supports(Class<?> clazz) {
		// TODO Auto-generated method stub
		return LoginStudent.class.isAssignableFrom(clazz);
	}    

[indu iyengar]

Hi all ,can anyone have an idea on this ? I strucked at this
thanks
indu

[Prasad Krishnegowda]

indu iyengar wrote:
now it shows the exception as ...

org.springframework.beans.factory.BeanNotOfRequiredTypeException: Bean named 'messageSource' must be of type [org.springframework.context.MessageSource], but was actually of type [org.springframework.context.support.ResourceBundleMessageSource]
    

This exception is because, you are having the wrong version of commons-logging.jar in your classpath..

oh! sorry David, just now I saw your reply.. when I change as you said , it is not accepting ..its showing the error as "NameClash"

public boolean supports(Class<?> clazz) {
		// TODO Auto-generated method stub
		return LoginStudent.class.isAssignableFrom(clazz);
	}    

Can you please elaborate on this? like it is an error or an exception, In which line of the code, error is coming up..

[indu iyengar]

Hi Prasad thanks for reply,
am using JBoss 5.1 with Spring 2.5 . Is it compatible ? I didnt add add commons-logging.jar in Jboss library...

[Prasad Krishnegowda]

It is compatible, just add commons-logging-1.1.jar to your applications WEB-INF/lib folder..

[indu iyengar]

thanks Prasad... That exception has gone by adding commons-logging 1.1.1 jar ...

----------
indu

[Prasad Krishnegowda]

indu iyengar wrote: thanks Prasad... That exception has gone by adding commons-logging 1.1.1 jar ...

----------
indu

You are Welcome..