Hi i am trying to connect to postgresql database using struts 1.2..i have used datasource

[maggie karve]

Hi...i have read in forums that using datasource is not a good option...how can i connect to database using struts 1....i want to do it in both in Struts 1 as well as Struts2..
When i use datasource in my stuts-config.xml,i get an error

struts-config.xml

 <?xml version="1.0" encoding="ISO-8859-1" ?>
<!DOCTYPE struts-config PUBLIC
          "-//Apache Software Foundation//DTD Struts Configuration 1.3//EN"
          "http://struts.apache.org/dtds/struts-config_1_3.dtd">
<struts-config>
 
    <form-beans>
        <form-bean name="addForm" type="src.com.java.AddForm"/>
   </form-beans>
 
    <global-forwards>
        <forward name="add" path="/add.do"/>
    </global-forwards>
 
    <action-mappings>
        <action path="/add" type="src.com.java.AddAction" name="addForm">
           <forward name="success" path="/success.jsp" />
        </action>
    </action-mappings>
    <data-sources>

<data-source type="org.apache.commons.dbcp.BasicDataSource">
    <set-property property="driverClassName" value="org.postgresql.Driver" />
    <set-property property="url" value="jdbc:postgresql://localhost/testdb" />
    <set-property property="name" value="name" />
    <set-property property="address" value="address" />
    
</data-source>
</data-sources>

    </struts-config>   

and my Action class:AddAction.java

  
package src.com.java;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.sql.DataSource;

import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;

public class AddAction extends Action{
    
    static final long serialVersionUID = -1L; 
    
    public ActionForward execute(ActionMapping mapping,ActionForm form,
            HttpServletRequest request,HttpServletResponse response)throws Exception{
        
        javax.sql.DataSource dataSource;
        dataSource = getDataSource(request);
        AddForm ffm=(AddForm)form; 
        String x=ffm.getName();
        String y=ffm.getAddress();
        Connection con=null;
        con = dataSource.getConnection();
        PreparedStatement pstmt = null;
            
        String sqlstr="INSERT INTO bil.\"Bill1\"(\"name\", address)VALUES (?, ?)";

        pstmt = con.prepareStatement(sqlstr);
        pstmt.setString(1,x);
        pstmt.setString(2,y);
            
        request.setAttribute("x1",x);
        request.setAttribute("y1",y);
        con.close();
    
            return mapping.findForward("success");
}
    private DataSource getDataSource(HttpServletRequest request) {
        // TODO Auto-generated method stub
        return null;
    }

}

  

[Joe Ess]

Please SearchFirst. The same question has been asked several times before.

[maggie karve]

but i didnt get an appropriate reply..i have read that its a bad style to use datasource now...
but can you tell me whether will i be able to acccess database using struts 1..i know we can in struts 2....using hibernate..

please reply

[Joe Ess]

Did you read the FAQ entry I posted in the thread I linked to?