Review the WS Code

[Rajkumar Katudia]

Guys,

Please comment on the client code

Need Expert comments for the WS that I have created, deployed and consumed.

I am learning webservices.

I need somebody "expert at Webservices" to have a look at the client I have written and tell me if it has been written the way it has to be?

Is there any scope for improvement?
Is there any mistake or blunder that I have made?

I am asking this as I have written the code on my own without studying any existing client.


Here is the WS that I have copied by googling (WS from JAVA)

package examples.webservices.simple;


import javax.jws.WebMethod;
import javax.jws.WebService;
import javax.jws.soap.SOAPBinding;

@WebService(name="SimplePortType", serviceName="SimpleService", targetNamespace="http://example.org")
@SOAPBinding(style=SOAPBinding.Style.DOCUMENT, use=SOAPBinding.Use.LITERAL, parameterStyle=SOAPBinding.ParameterStyle.WRAPPED)
public class SimpleImpl {
	@WebMethod()
	public String sayHello(String message) {
	System.out.println("sayHello:" + message);
		return "Here is the message: '" + message + "'";
	}
}

Here is the URL and WSDL after deployment
URL

http://10.15.10.203:7001/SimpleImpl/SimpleService?WSDL

WSDL

  <?xml version="1.0" encoding="UTF-8" ?> 
 <!--  Published by JAX-WS RI at http://jax-ws.dev.java.net. RI's version is Oracle JAX-WS 2.1.3-07/10/2008 08:41 PM(bt). 
  --> 
 <!--  Generated by JAX-WS RI at http://jax-ws.dev.java.net. RI's version is Oracle JAX-WS 2.1.3-07/10/2008 08:41 PM(bt). 
  --> 
 <definitions xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:tns="http://example.org" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="http://schemas.xmlsoap.org/wsdl/" targetNamespace="http://example.org" name="SimpleService">
 <types>
 <xsd:schema>
  <xsd:import namespace="http://example.org" schemaLocation="http://10.15.10.203:7001/SimpleImpl/SimpleService?xsd=1" /> 
  </xsd:schema>
  </types>
 <message name="sayHello">
 <part name="parameters" element="tns:sayHello" /> 
  </message>
 <message name="sayHelloResponse">
  <part name="parameters" element="tns:sayHelloResponse" /> 
  </message>
 <portType name="SimplePortType">
 <operation name="sayHello">
  <input message="tns:sayHello" /> 
  <output message="tns:sayHelloResponse" /> 
  </operation>
  </portType>
 <binding name="SimplePortTypePortBinding" type="tns:SimplePortType">
  <soap:binding transport="http://schemas.xmlsoap.org/soap/http" style="document" /> 
 <operation name="sayHello">
  <soap:operation soapAction="" /> 
 <input>
  <soap:body use="literal" /> 
  </input>
 <output>
  <soap:body use="literal" /> 
  </output>
  </operation>
  </binding>
 <service name="SimpleService">
 <port name="SimplePortTypePort" binding="tns:SimplePortTypePortBinding">
  <soap:address location="http://10.15.10.203:7001/SimpleImpl/SimpleService" /> 
  </port>
  </service>
  </definitions>

I generated the client using the AXIS 2

Here is the consumer class that I have written

import java.rmi.RemoteException;

import org.apache.axis2.AxisFault;
import org.example.SimpleServiceStub;
import org.example.SimpleServiceStub.SayHello;
import org.example.SimpleServiceStub.SayHelloE;
import org.example.SimpleServiceStub.SayHelloResponseE;


public class ClientFirst {
	public static void main(String[] args) {
		try {
			SimpleServiceStub serviceStub = new SimpleServiceStub(null,"http://10.15.10.203:7001/SimpleImpl/SimpleService");
			SayHelloE helloE = new SimpleServiceStub.SayHelloE();
			SayHello hello = new SayHello();
			hello.setArg0("Praveen");
			helloE.setSayHello(hello);
			SayHelloResponseE responseE = serviceStub.sayHello(helloE);
			System.out.println("THIS IS THE RESPONSE "+(responseE.getSayHelloResponse()).get_return());
		} catch (AxisFault e) {
			System.err.println("-+-+-+-+-+-+AXIS FAULT EXCEPTION");
			e.printStackTrace();
		} catch (RemoteException e) {
			System.err.println("-+-+-+-+-+-+REMOTE EXCEPTION FAULT");
			e.printStackTrace();
		}
	}
}

I am getting the expected output however, I need somebody "expert at Webservices" to have a look at the client I have written and tell me if it has been written the way it has to be?

Is there any scope for improvement?
Is there any mistake or blunder that I have made?

I am asking this as I have written the code on my own without studying any existing client.