Forum:

Custom validation ignored

Ranch Hand

Posts: 108

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi,
I have a login page where the page is submitted via a command button action attribute. The attribute points to a method that processes the page.
A username text box on the page has a custom validator that validates the username format which is an email. When an incorrect format is entered the validator does not throw a validator error in the PHASE PROCESS_VALIDATIONS phase. Instead it goes onto the PHASE INVOKE_APPLICATION phase where it throws an authentication error.
How do I get the page to throw the validation error?

Thanks.

suresh dasari

Ranch Hand

Posts: 121

I like...

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Gina,

Have you used immediate attribute by any chance in the command button?
as you said it is a custom validation, have you registered the custom validation in configuration file, could you post the login page code?

Sun Certified Java Programmer with 93 percent

Gina vernon

Ranch Hand

Posts: 108

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Suresh,
I did not use the immediate attribute and yes the validator is registered. When I debug I can actually see the application go throuhg each line of the validator but just doesn't throw the error it just goes on to the submit action. Here is the code:
JSF:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<%@ page contentType="text/html;charset=windows-1252" buffer="none"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ include file="/header.jsp"%>

<f:view>
  <html>
    <head>
      <meta http-equiv="Content-Type"
            content="text/html; charset=windows-1252"/>
      <title>login</title>
    </head>
    <body>

<h:form id="form1">
      <div id="IntContentArea">
      <h:panelGrid columns="3" id="loginGrid">
      <label>Email address:<span class="required">*</span></label>
      <h:inputText binding="#{backing_login.emaillogval}" id="emaillogval"
       required="true">
       <f:validator validatorId="emailvalid"/>
       </h:inputText>
       <h:message for="emaillogval" styleClass="required"/>

<label>Password:<span class="required">*</span></label>
       <h:inputSecret binding="#{backing_login.pwdlogval}" id="pwdlogval"
                         required="true"/>
        <h:message for="pwdlogval" styleClass="required"/>
          </h:panelGrid>
      <h:panelGrid columns="2" id="submitlogGrid" style="width:50.0%;">
      <h:commandButton value="Login" id="logbutton" action="#{backing_login.validateLogin}"/><h:commandButton value="Register" id="regbutton"/>
      </h:panelGrid>
        </div>
      </h:form>
    </body>
     <jsp:include page="/footer.jsp"/>
  </html>
</f:view>

Validator:

public class EmailValidator implements Validator {
    public void validate(FacesContext facesContext, UIComponent uIComponent,
                         Object object) throws ValidatorException 
    {
      Pattern emailp = Pattern.compile("a*b");
      //Pattern emailp = Pattern.compile("^[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\\.)+(?:[A-Z]{2}|nl|be|de|com|org|net|gov|mil|biz|info|mobi|name|aero|jobs|museum)$");
      String email = (String)object;
      Matcher emailm = emailp.matcher("email");
      boolean emailcheck = emailm.matches();
      if(!emailcheck)
      {
          FacesMessage emailmsg = new FacesMessage();
          emailmsg.setSeverity(FacesMessage.SEVERITY_ERROR);
          emailmsg.setSummary("Email format is invalid.");
          emailmsg.setDetail("Please enter date in the format mm/dd/yyyy.");
          facesContext.addMessage(uIComponent.getClientId(facesContext), emailmsg);            
      }

}
}

Thanks.

suresh dasari

Ranch Hand

Posts: 121

I like...

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Gina,

your adding the message to facesmessages but not throwing exception, thats why control is directly going to action method.

you should throw the vlidatorException, see the code below:

public class EmailValidator implements Validator {  
     public void validate(FacesContext facesContext, UIComponent uIComponent,  
                          Object object) throws ValidatorException   
     {  
       Pattern emailp = Pattern.compile("a*b");  
       //Pattern emailp = Pattern.compile("^[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\\.)+(?:
       //[A-Z]{2}|nl|be|de|com|org|net|gov|mil|biz|info|mobi|name|aero|jobs|museum)$");  
       String email = (String)object;  
       Matcher emailm = emailp.matcher("email");  
       boolean emailcheck = emailm.matches();  
       if(!emailcheck)  
       {  
           FacesMessage emailmsg = new FacesMessage();  
           emailmsg.setSeverity(FacesMessage.SEVERITY_ERROR);  
           emailmsg.setSummary("Email format is invalid.");  
           emailmsg.setDetail("Please enter date in the format mm/dd/yyyy.");  
           throw new ValidatorException(new FacesMessage(emailmsg));
       }   
     }  
 }

Sun Certified Java Programmer with 93 percent

Gina vernon

Ranch Hand

Posts: 108

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Suresh, here is the my modified code as per your post. It still does not work.

Thanks.

suresh dasari

Ranch Hand

Posts: 121

I like...

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Gina,

I tried from my workspace, its perfectly working, something else is wrong. The code perfectly works.
is the control is going to validator method, if that is the case its very general that whenever an exception is thrown it shouldnt go to backingbean.

Sun Certified Java Programmer with 93 percent

Gina vernon

Ranch Hand

Posts: 108

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Suresh, did you setup the component exactly as in my jsp code above? If not, could you please try that?

The validation code is working, but the error message is still not seen. So, when I enter an invalid email, 'Email required message' is thrown, not the validation message.

I dont think I included this in my posts, but since the component uses the binding attribute and not the value attribute the following code needs to be added to the set accessor method of the component:

If not the h:message tag throws a standard error message when the field is empty.

Thanks.

Gina vernon

Ranch Hand

Posts: 108

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I did some further debugging and generated the following phase and messages information:

The validator messages is enqueued in the RENDER_RESPONSE phase. I read on some forum I can't remember that messages that are enqueued in this phase are not displayed.

suresh dasari

Ranch Hand

Posts: 121

I like...

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I think you are making things complicated, Is there any specific reason of using binding attribute for the email?
I guess emailogval is a string variable how come you can use emailogval.getClientId(----) method.
without using a value attribute how can JSF set error messages wrt to that pirticular control.

could you please make it clear?

Thanks,
suresh.

Sun Certified Java Programmer with 93 percent

Gina vernon

Ranch Hand

Posts: 108

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Ok, I finally got what I was doing wrong. The code in the set accessor method was messing up the message queue. Once I got rid of it, everything worked fine.
Thanks, Suresh for your help.

I once met a man from Nantucket. He had a tiny ad

Free, earth friendly heat - from the CodeRanch trailboss

https://www.kickstarter.com/projects/paulwheaton/free-heat