Cookie not being sent back to browser

[Frank Serkland]

I'm not sure if the Struts forum is the appropriate folder for this, so since I think the problem is is happening in my DAO class, I'll post it here. I'm trying to create a poll where the user sees it in the JSP if he hasn't voted. Once he does vote, his vote is processed and a cookie is sent back to tell the JSP to show the results rather than the ballot. The tag that is supposed to read the cookie is returning a NullPointerException, which I've traced to the line HttpSession currentSession = (HttpSession) request.getSession();. Here is my DAO's code so you can see everything in context. Any help out there?

package dao;

import java.util.Iterator;

import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;

import model.Poll1;

import org.apache.struts2.interceptor.ServletRequestAware;
import org.apache.struts2.interceptor.ServletResponseAware;
import org.hibernate.Query;
import org.hibernate.Session;
import org.hibernate.SessionFactory;
import org.hibernate.Transaction;
import org.hibernate.cfg.Configuration;

public class Poll1DAO implements ServletRequestAware, ServletResponseAware {
	private HttpServletRequest request;

	@SuppressWarnings("unchecked")
	public boolean tallyVote(String vote) {
		boolean successfulWrite;
		SessionFactory sessionFactory = new Configuration().configure()	.buildSessionFactory();
		Session session = sessionFactory.openSession();
		try {
			// Get previous results
			Transaction tx1 = session.beginTransaction();
			Query myQuery = session.createQuery("from Poll1");
			tx1.commit();
			
			// Update results
			Iterator<Poll1> iterate = myQuery.iterate();
			Poll1 poll1 = iterate.next();
			if (vote.equals("1")) {
				poll1.setYes(poll1.getYes() + 1);
			} else if (vote.equals("2"))  {
				poll1.setNo(poll1.getNo() + 1);
			}
			
			// Write new results back to database;
			Transaction tx2 = session.beginTransaction();
			session.update(poll1);
			tx2.commit();
			session.close();
			
			// Set cookie to indicate the user has voted
			Cookie cookie = new Cookie("poll1", "voted");
			cookie.setMaxAge(60 * 60 * 24 * 365);	// Cookie set for a year
			successfulWrite = true;
			
			// Send cookie back to browser
			HttpSession currentSession = (HttpSession) request.getSession();
			System.out.println("HttpSession retrieved");
			currentSession.setAttribute("poll1", cookie);
			System.out.println("Cookie put into session");
		} catch (Exception e) {
			System.out.println(e.toString());
			successfulWrite = false;
		} finally {
			session.close();
		}
		
		return successfulWrite;
	}

	public void setServletRequest(HttpServletRequest request) {
		this.request = request;
	}

	public void setServletResponse(HttpServletResponse arg0) {
	}
}

[Frank Serkland]

I resolved the NullPointerException by adding this line.

request = ServletActionContext.getRequest();

However, the cookie still isn't being sent back to the browser? Can anyone help me with this, or is this a question for another forum?

[Tom Reilly]

I believe you're supposed to set the cookie in the response object; not the session object.

[Frank Serkland]

Tom Reilly wrote:I believe you're supposed to set the cookie in the response object; not the session object.

It had to be something simple like that, didn't it? Thank you, Tom. Your suggestion is the one that worked.