java.sql.SQLException: [Microsoft][ODBC Driver Manager] Invalid cursor state

[anna george]

hi i'm new to this site .
A first time user .

I hope i'l find answers to my queries please do help me.
I am learning Java for the first time and I am trying to create a login application using Jframe with the editor netbeans.

the following is my code

//code

package Project;
import javax.swing.JOptionPane;
import java.sql.*;


public class login extends javax.swing.JFrame {
  String userName;
  String password;

public login() {
        initComponents();

    }

 private void btnLoginActionPerformed(java.awt.event.ActionEvent evt) {                                         
                      
        try{
        Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
        Connection con =DriverManager.getConnection("jdbc:odbc:Employ");  //the dsn Employ is created in database Employ in an SQL server 
        System.out.println("Connection is created ");
       Statement s=con.createStatement();

    ResultSet rs1= s.executeQuery("Select * from savelogin");   //savelogin is a table created in database Employ that contains username and      password as its field
    
//    userName=rs1.getString(1);
// password=rs1.getString(2);                                

  
//     System.out.println("-------------------------------------------");
          while(rs1.next())
            {
 System.out.println(rs1.getString(1)+" "+rs1.getString(2));
               
            }
      userName=rs1.getString(1);
 password=rs1.getString(2);
       s.close();
        con.close();
        System.out.println("disconnected");
       

    }
    catch(Exception err)
    {
        System.out.println("Error :" +err);

    }
//
//userName="Select username from savelogin";
//password="select password from savelogin";

        if(( jPasswordField1.getText().equals(password)) && txtuserName.getText().equals(userName)){
            JOptionPane.showMessageDialog(rootPane,"Login Successful!");
            welcome page=new welcome();
                        page.setVisible(true);
        } else if(!(jPasswordField1.getText().equals(password)) || !( txtuserName.getText().equals(userName)))
            JOptionPane.showMessageDialog(rootPane,"Enter proper username and password");


        else if(jPasswordField1.getText().isEmpty() && txtuserName.getText().isEmpty())
            JOptionPane.showMessageDialog(rootPane,"Please enter username and  your password.");

        else if(jPasswordField1.getText()==null || txtuserName.getText().equals(userName) ) //(txtPassword.getText().equals(password) || txtuserName.getText()==null))
            JOptionPane.showMessageDialog(rootPane,"Please enter password.");

        else if(jPasswordField1.getText().equals(password) || txtuserName.getText()==null)
            JOptionPane.showMessageDialog(rootPane,"Please enter username.");

        //         else if(!(txtPassword.getText().equals(password)) || !( txtuserName.getText().equals(userName)))
        //             JOptionPane.showMessageDialog(rootPane,"Enter proper username and password");

    }                                        

private void lblForgotPasswordMousePressed(java.awt.event.MouseEvent evt) {                                               
    // TODO add your handling code here:
    
}                                              

 public static void main(String args[]) {
        java.awt.EventQueue.invokeLater(new Runnable() {
            public void run() {
                new login().setVisible(true);
            }
        });
    }

    // Variables declaration - do not modify                     
    private javax.swing.JButton btnCancel;
    private javax.swing.JButton btnLogin;
    private javax.swing.JPanel jPanel1;
    private javax.swing.JPanel jPanel2;
    private javax.swing.JPasswordField jPasswordField1;
    private javax.swing.JProgressBar jProgressBar;
    private javax.swing.JLabel lblChangePassword;
    private javax.swing.JLabel lblForgotPassword;
    private javax.swing.JLabel lblPassword;
    private javax.swing.JLabel lblUserName;
    private javax.swing.JTextField txtuserName;
    // End of variables declaration                   



}

this is the output i get when i run the program

Connection is created
laconic laconic
Error :java.sql.SQLException: [Microsoft][ODBC Driver Manager] Invalid cursor state

here laconic is the value stored in the table. It gets printed in the System .out.println statement but doesnot get stored in a string variable.

Not getting why ? please help

i donot understand why it gives error at the following place in the above program:

userName=rs1.getString(1);
password=rs1.getString(2);

[Alex Hurtt]

My guess is the first calls to getString(1) and getString(2) moved the result set cursor forward and you cannot automatically move it back again just by calling getString(1) and getString(2) again without moving to the next row...but you're already on the last row since you've exited your while(rs.next()) loop. By default a JDBC ResultSet is like an iterator...each call to rs.next() moves the cursor forward one row and you can't move backwards. I would suggest taking a few minutes to read the Javadoc for the ResultSet interface. There is one part in there in particular which says "For maximum portability, result set columns within each row should be read in left-to-right order, and each column should be read only once." You problem is probably related to this in that you are trying to read the same values from the last row of the result set twice. Read the columns once (in your loop) and store them in String reference variables.

[Rob Spoor]

Welcome to the Ranch, Anne!

Could you please UseCodeTags next time? I've added them for you this time. And I'm moving this thread to our JDBC forum where I think you'll have a bit more replies.

[Jan Cumps]

You are reading (in line 35 and 36) after you closed the while loop in line 34.
At that point, the cursor is beyond the last record.
Rerieving column values is an invalid action in that situation.