Not authenticating the user

[Kunal Lakhani]

I am Providing a bean class, dao and servlet.
My database contains a table named 'users' which contains USERNAME & PASSWORD Columns.

On running this application in tomcat, its showing "Illegal argument in call"

what is wrong in this code?

UserLoginBean.java:

package org.Cmtes.Imm.Bean;

import java.io.Serializable;

public class UserLoginBean implements Serializable {

	private String username;
	private String Password;
	
	public UserLoginBean() {}

	public String getUsername() {
		return username;
	}

	public void setUsername(String username) {
		this.username = username;
	}

	public String getPassword() {
		return Password;
	}

	public void setPassword(String password) {
		Password = password;
	}
	

}

UserDao

package org.Cmtes.Imm.Dao;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.Statement;


import org.Cmtes.Imm.Bean.UserLoginBean;

public class UserDao {
	boolean state=false;
	
	public boolean authenticateUser(UserLoginBean ul){
		try {
			Class.forName("oracle.jdbc.driver.OracleDriver");
			Connection con = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:oracle");
			Statement st = con.createStatement();
			ResultSet rs = st.executeQuery("Select * from users");
			System.out.println(rs.getString("username"));
			if(rs.next()){
				if(ul.getUsername().equals(rs.getString("username"))&& ul.getPassword().equals(rs.getString("password"))){
					System.out.println("They are equal");
					 state=true;
					
				}
				else {
					state=false;
				}
			}
			
			
			
		} catch(Exception e) {
			e.printStackTrace();
			state= false;
		}
		
		return state;
		
		
	}

}

UserLoginServlet

package org.Cmtes.Imm.Servlet;

import java.io.IOException;

import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.Cmtes.Imm.Bean.UserLoginBean;
import org.Cmtes.Imm.Dao.UserDao;

public class UserLoginServlet extends HttpServlet {


	public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		String username = request.getParameter("t1");
		String password = request.getParameter("t2");
		System.out.println(username);
		System.out.println(password);
		UserLoginBean ul = new UserLoginBean();
		ul.setUsername(username);
		ul.setPassword(password);
		UserDao ud = new UserDao();
		boolean state = ud.authenticateUser(ul);
		String targetJsp="";
		if(state==true){
			targetJsp="Success.jsp";
		}
		else {
			targetJsp="Failure.jsp";
		}
		RequestDispatcher rd=request.getRequestDispatcher("./"+targetJsp);
		rd.forward(request, response);
		
		
	}

}

[Mohamed Sanaulla]

Can you provide the Stacktrace?

[David O'Meara]

why not change to:

sql="select from user where username=? and password=?";
PreparedStatement ps = conn.prepareStatement(sql);
ps.setString(1, username);
ps.setString(2, password);
if(ps.executeQuery().next())
{
    //is good
}
else
{
    //not so good
}

[Kunal Lakhani]

The application posted above shows the following stack trace :

INFO: Reloading this Context has started
admin
abc
java.sql.SQLException: invalid arguments in call
        at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java
:112)
        at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java
:146)
        at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java
:208)
        at oracle.jdbc.driver.T4CConnection.logon(T4CConnection.java:236)
        at oracle.jdbc.driver.PhysicalConnection.<init>(PhysicalConnection.java:
414)
        at oracle.jdbc.driver.T4CConnection.<init>(T4CConnection.java:165)
        at oracle.jdbc.driver.T4CDriverExtension.getConnection(T4CDriverExtensio
n.java:35)
        at oracle.jdbc.driver.OracleDriver.connect(OracleDriver.java:801)
        at java.sql.DriverManager.getConnection(Unknown Source)
        at java.sql.DriverManager.getConnection(Unknown Source)
        at org.Cmtes.Imm.Dao.UserDao.authenticateUser(UserDao.java:17)
        at org.Cmtes.Imm.Servlet.UserLoginServlet.doPost(UserLoginServlet.java:3
0)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:290)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:206)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:233)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:191)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:127)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j
ava:102)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal
ve.java:109)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav
a:298)
        at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java
:857)
        at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.proce
ss(Http11Protocol.java:588)
        at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:48
9)
        at java.lang.Thread.run(Unknown Source)

[Kunal Lakhani]

.

[Mohamed Sanaulla]

Please cross check the connection String in line 17 of UserDao.java.

[Kunal Lakhani]

mohamed sanaullah, I don't find any mistake there. you please look into that once

[Mohamed Sanaulla]

Is this "jdbc:oracle:thin:@localhost:1521:oracle" supposed to be this : "jdbc:oracle:thin:@localhost:1521:orcl"

Update: Which version/type of Oracle Database are you using?

[Kunal Lakhani]

i am using Oracle 10g. That's ok as other applications are working

[Mohamed Sanaulla]

Kunal Lakhani wrote:i am using Oracle 10g. That's ok as other applications are working

Which are the other applications?

I searched around on the web and found that the connection string format is supposed to be:

jdbc:oracle:thin:[user/password]@[host][:port]:SID
jdbc:oracle:thin:[user/password]@//[host][:port]/SID

[Kunal Lakhani]

I have successfully executed other applications relating to insert , update, deleting the data. So, there is some problem with this code.

[Mohamed Sanaulla]

Kunal Lakhani wrote:I have successfully executed other applications relating to insert , update, deleting the data. So, there is some problem with this code.

I see that at org.Cmtes.Imm.Dao.UserDao.authenticateUser(UserDao.java:17) is the cause for this exception (from the stacktrace)

[Kunal Lakhani]

yes, you were right. line no 17 was the cause. I didn't included user and password for db connection.

Now, after adding scott and tiger as user and password, the following stack trace is displayed:

java.sql.SQLException: ResultSet.next was not called
at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:146)
at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:208)
at oracle.jdbc.driver.OracleResultSetImpl.getString(OracleResultSetImpl.java:387)
at oracle.jdbc.driver.OracleResultSet.getString(OracleResultSet.java:1515)
at org.Cmtes.Imm.Dao.UserDao.authenticateUser(UserDao.java:21)
at org.Cmtes.Imm.Servlet.UserLoginServlet.doPost(UserLoginServlet.java:30)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:261)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
at java.lang.Thread.run(Thread.java:619)

[Paul Sturrock]

Looks like you are trying to use the ResultSet before you have move the cursor on. The normal pattern is:

Create a ResultSet

Move the cursor to the first result

Access a value from the ResultSet

[Mohamed Sanaulla]

Line 20 in UserDao.java is the culprit. As Paul has already mentioned how to go about accessing the values from the ResultSet. At line 20 you are trying to get the username even before the cursor is pointing to actual data from the table.