Need help with this code

[Tom Huddersfield]

Hiya, I'm writing a java application which renders a pie chart based on input. So far I havn't added the rendering of the actual pie chart, but I keep getting a really annoying runtime error when I try to test the data (i.e. click OK). I'm relatively new to java coding so I don't understand what is wrong.

Here is the code:

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.awt.geom.*;

public class PieChartMainMenu extends JFrame {
	
        public static  JTabbedPane dataTab = new JTabbedPane();
        
	public static int numData = 1;
	
        public static JPanel mainPanel = new JPanel();        
		
	public PieChartMainMenu(DataPanelMain[] dataPanels, JTabbedPane dataTab, int numData)  {
		super("Pie Chart Options");
		setSize(320, 440);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		
		
		BoxLayout box = new BoxLayout(mainPanel, BoxLayout.Y_AXIS);
		mainPanel.setLayout(box);
		
		TopPanelMain topPanel = new TopPanelMain();
		BottomPanelMain bottomPanel = new BottomPanelMain();
		
		addDataPane(dataPanels, numData, dataTab);
		
		mainPanel.add(topPanel);
		mainPanel.add(dataTab);
		mainPanel.add(bottomPanel);
		
		add(mainPanel);
		setVisible(true);
		
	}
	
	public TopPanelMain returnTopPanel() {
		Component[] components = this.mainPanel.getComponents(); 
		TopPanelMain topPanel = (TopPanelMain)components[0];
		
		return(topPanel);
	}
	
	public JTabbedPane returnDataTab() {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		
		return(tabPanel);
	}
	
	
	public DataPanelMain returnDataPanel(int i) {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		DataPanelMain dPanel = (DataPanelMain)tabPanel.getComponentAt(i);
		
		return(dPanel);
	}
	
	
	
	public void addDataPane(DataPanelMain[] dataPanels, int numData, JTabbedPane dataTab1) {
	
		if (numData == 1) {
			DataPanelMain Data1 = dataPanels[0];
			dataTab.addTab("Data 1", Data1);
		}
		
		if (numData == 2) {
			DataPanelMain Data1 = dataPanels[1];
			dataTab.addTab("Data 2", Data1);
		}
		
		if (numData == 3) {
			DataPanelMain Data1 = dataPanels[2];
			dataTab.addTab("Data 3", Data1);
		}
		repaint();
		increaseNumData();
		 

	}
	
	public void increaseNumData() {
		PieChartMainMenu.numData++;
	}
		



	
public class TopPanelMain extends JPanel {
    GridBagLayout gridbag = new GridBagLayout();
        
   
    JLabel titleLabel = new JLabel("Title :");
    JTextField title = new JTextField();
    JLabel unitsLabel = new JLabel("Units :");
    JTextField units = new JTextField();
    
    public TopPanelMain() {
        super();
        
        GridBagConstraints constraints;
        setLayout(gridbag);
        
     
        addComponent(titleLabel, 1, 1, 4, 1, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(title, 7, 1, 9, 1, 9, 1,
            GridBagConstraints.HORIZONTAL, GridBagConstraints.CENTER);
        addComponent(unitsLabel, 1, 3, 4, 1, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(units, 7, 3, 9, 1, 9, 1,
            GridBagConstraints.HORIZONTAL, GridBagConstraints.CENTER);
    
    }

    private void addComponent(Component component, int gridx, int gridy,
        int gridwidth, int gridheight, int weightx, int weighty, int fill,
        int anchor) {
    
        GridBagConstraints constraints = new GridBagConstraints();
        constraints.gridx = gridx;
        constraints.gridy = gridy;
        constraints.gridwidth = gridwidth;
        constraints.gridheight = gridheight;
        constraints.weightx = weightx;
        constraints.weighty = weighty;
        constraints.fill = fill;
        constraints.anchor = anchor;
        gridbag.setConstraints(component, constraints);
        add(component);
    }
}







static public class DataPanelMain extends JPanel {
    GridBagLayout gridbag = new GridBagLayout();
        
   JLabel dataLabel = new JLabel("Data " + numData);
        JLabel nameLabel = new JLabel("Name :");
        JTextField name = new JTextField();
        JLabel sizeLabel = new JLabel("Size :");
        JTextField size = new JTextField();
        JLabel colourLabel = new JLabel("Colour :");
    
    public DataPanelMain(int numData) {
        super();
        
        GridBagConstraints constraints;
        setLayout(gridbag);
        
        
        
        JComboBox colour = new JComboBox();
        String[] colours = { "Red", "Blue", "Green", "Yellow", "Black", "Pink" };
        for (int i = 0; i < colours.length; i++)
        	colour.addItem(colours[i]);
        
     
        addComponent(dataLabel, 1, 1, 4, 1, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(nameLabel, 1, 3, 4, 1, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(name, 7, 3, 9, 1, 9, 1,
            GridBagConstraints.HORIZONTAL, GridBagConstraints.CENTER);
        addComponent(sizeLabel, 1, 5, 4, 1, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(size, 7, 5, 9, 1, 9, 1,
            GridBagConstraints.HORIZONTAL, GridBagConstraints.CENTER);
        addComponent(colourLabel, 1, 7, 4, 1, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(colour, 7, 7, 9, 1, 9, 1,
            GridBagConstraints.HORIZONTAL, GridBagConstraints.CENTER);
    
    }

    private void addComponent(Component component, int gridx, int gridy,
        int gridwidth, int gridheight, int weightx, int weighty, int fill,
        int anchor) {
    
        GridBagConstraints constraints = new GridBagConstraints();
        constraints.gridx = gridx;
        constraints.gridy = gridy;
        constraints.gridwidth = gridwidth;
        constraints.gridheight = gridheight;
        constraints.weightx = weightx;
        constraints.weighty = weighty;
        constraints.fill = fill;
        constraints.anchor = anchor;
        gridbag.setConstraints(component, constraints);
        add(component);
    }
    
    public int returnSize() {
    	    return(Integer.parseInt(this.size.getText()));
    }
}



public class BottomPanelMain extends JPanel implements ActionListener {
    GridBagLayout gridbag = new GridBagLayout();
      
    JButton newDataButton = new JButton("New Data");
        JButton okButton = new JButton("OK");
        JButton exitButton = new JButton("Exit");  
   
        public BottomPanelMain() {
        super();
        
        GridBagConstraints constraints;
        setLayout(gridbag);
        
        
        okButton.addActionListener(this);
        newDataButton.addActionListener(this);
        
        addComponent(newDataButton, 6, 1, 4, 2, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(okButton, 2, 6, 4, 2, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
        addComponent(exitButton, 11, 6, 4, 2, 4, 1,
            GridBagConstraints.NONE, GridBagConstraints.CENTER);
    
    }


    private void addComponent(Component component, int gridx, int gridy,
        int gridwidth, int gridheight, int weightx, int weighty, int fill,
        int anchor) {
    
        GridBagConstraints constraints = new GridBagConstraints();
        constraints.gridx = gridx;
        constraints.gridy = gridy;
        constraints.gridwidth = gridwidth;
        constraints.gridheight = gridheight;
        constraints.weightx = weightx;
        constraints.weighty = weighty;
        constraints.fill = fill;
        constraints.anchor = anchor;
        gridbag.setConstraints(component, constraints);
        add(component);
    }
    
    public void actionPerformed(ActionEvent evt) {
	Object source = evt.getSource();
    	
	if (source == newDataButton) {
	   DataPanelMain[] dataPanels = new DataPanelMain[10];
	   dataPanels[0] = new DataPanelMain(1);
	   dataPanels[1] = new DataPanelMain(2);
	   dataPanels[2] = new DataPanelMain(3);
	   int numData1 = PieChartMainMenu.numData;
	   JTabbedPane dataTab1 = PieChartMainMenu.dataTab;
	 
	  addDataPane(dataPanels, numData1, dataTab1);
	}
	
	if (source == okButton) {
		PieChartGraphicPage thePie = new PieChartGraphicPage();
	}

}
}

public class PieGraphicPanel extends JPanel {
	
	public void paintComponent(Graphics comp) {
		Graphics2D comp2D = (Graphics2D)comp;
		
		int dataTotal = 0;
		
		DataPanelMain[] theDatas = new DataPanelMain[3];
		
		for (int i = 0; i <= PieChartMainMenu.dataTab.getTabCount(); i++) {					
			theDatas[i] = returnDataPanel(i);			
		}
		
		int[] values = new int[3];
		
		 for (int i = 0; i < theDatas.length; i++) {
			
				dataTotal += Integer.parseInt(theDatas[i].size.getText());
				values[i] = Integer.parseInt(theDatas[i].size.getText());
	
			
		} 
		
		double[] percentages = new double[3];
		
		if (dataTotal == 0) dataTotal = 1;
		
		for (int i = 0; i < percentages.length; i++) {
			percentages[i] = values[i] / dataTotal;
		}
			
			
		
		TopPanelMain topData = returnTopPanel();
		
		String pieTitle = topData.title.getText();
		String pieUnits = topData.units.getText();
		comp2D.drawString(pieTitle, 120, 20);
		comp2D.drawString(pieUnits, 120, 140);
	}
}
		

		
		




public class PieChartGraphicPage extends JFrame {
	
	public PieChartGraphicPage() {
		super("Pie Chart");
		setSize(420, 320);
		setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
		
		PieGraphicPanel pieGraphic = new PieGraphicPanel();
		
		add(pieGraphic);
		setVisible(true);		
		
	}		
	

}

public static void main(String[] arguments) {
        
		
        DataPanelMain[] dataPanels1 = new DataPanelMain[10];
	dataPanels1[0] = new DataPanelMain(1);
	dataPanels1[1] = new DataPanelMain(2);
	dataPanels1[2] = new DataPanelMain(3);


	
	PieChartMainMenu iDidItYay = new PieChartMainMenu(dataPanels1, dataTab, numData);
		
}

}

[pete stein]

Hello and welcome to the Ranch!

So, what error message are you seeing, and what line of code causes the error? The more information you can give us, the better we'll be able to help you.

Much luck and again, welcome!

[Tom Huddersfield]

The error message I get is:

C:\JavaWork>java PieChartMainMenu
Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException:
1 >= 1
at java.util.Vector.elementAt(Unknown Source)
at javax.swing.JTabbedPane.getComponentAt(Unknown Source)
at PieChartMainMenu.returnDataPanel(PieChartMainMenu.java:55)
at PieChartMainMenu$PieGraphicPanel.paintComponent(PieChartMainMenu.java
:285)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JLayeredPane.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paintToOffscreen(Unknown Source)
at javax.swing.BufferStrategyPaintManager.paint(Unknown Source)
at javax.swing.RepaintManager.paint(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at java.awt.GraphicsCallback$PaintCallback.run(Unknown Source)
at sun.awt.SunGraphicsCallback.runOneComponent(Unknown Source)
at sun.awt.SunGraphicsCallback.runComponents(Unknown Source)
at java.awt.Container.paint(Unknown Source)
at java.awt.Window.paint(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.seqPaintDirtyRegions(Unknown Source)
at javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(Unknow
n Source)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

This happens when I press the okButton with one data tab. I don't really understand why I get an ArrayIndexOutOfBoundsException.

[Campbell Ritchie]

Why are you using Vector, rather than one of the more modern implementations of List? Is it that it is required by one of the Components? I know there are things like Combo-boxes which still require Vector.
You are trying to gain access to the second (=index 1) member of a 1-member array or list.
Or: to put it another way: You have one element in the Vector and you are trying to access its second element.
Remember the first member of a List or array is no 0.

[pete stein]

In your code:

	public JTabbedPane returnDataTab() {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		
		return(tabPanel);
	}
	
	
	public DataPanelMain returnDataPanel(int i) {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		DataPanelMain dPanel = (DataPanelMain)tabPanel.getComponentAt(i);
		
		return(dPanel);
	}

You're getting components by using getComponents() and then using an array index to get the components. This is a very fragile way of getting a reference to an object. Why not use the variable that you already have in your class? As it is, it is likely that components[1] doesn't exist ([0] is probably the contentPane).

[pete stein]

Campbell Ritchie wrote:Why are you using Vector, rather than one of the more modern implementations of List? Is it that it is required by one of the Components? I know there are things like Combo-boxes which still require Vector.
You are trying to gain access to the second (=index 1) member of a 1-member array or list.
Or: to put it another way: You have one element in the Vector and you are trying to access its second element.
Remember the first member of a List or array is no 0.

I think that he's not explicitly using Vector but rather is trying to get a reference to a component from a Container which likely uses a Vector to hold all of its components.

[Tom Huddersfield]

pete stein wrote:In your code:

	public JTabbedPane returnDataTab() {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		
		return(tabPanel);
	}
	
	
	public DataPanelMain returnDataPanel(int i) {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		DataPanelMain dPanel = (DataPanelMain)tabPanel.getComponentAt(i);
		
		return(dPanel);
	}

You're getting components by using getComponents() and then using an array index to get the components. This is a very fragile way of getting a reference to an object. Why not use the variable that you already have in your class? As it is, it is likely that components[1] doesn't exist ([0] is probably the contentPane).

Which variable do you mean...?

Also, I'm not intentionally using vectors, where does that come?

[pete stein]

Dss Ss wrote:
Which variable do you mean...?

You're trying to get the JTabbedPane. How many JTabbedPane variables does your program have? On a side note, why are any of the variables static?

Also, I'm not intentionally using vectors, where does that come?

I think that Containers hold their Components in an internal Vector. The JFrame holds only one Component, the contentPane, so in the components array it is held in position [0]. You're trying to get componets[1] which simply doesn't exist. But even if it did, this is not a good way to get your data. Rather your data should be accessible via a class getter method.

[Darryl Burke]

The JFrame holds only one Component, the contentPane

I guess you meant to say root pane

The JFrame holds the rootPane, which holds the glassPane and layeredPane, the latter of which holds the contentPane and menu (if any).

[Tom Huddersfield]

The JFrame holds only one Component, the contentPane, so in the components array it is held in position [0]. You're trying to get componets[1] which simply doesn't exist. But even if it did, this is not a good way to get your data. Rather your data should be accessible via a class getter method.

So this is the code causing the problem:

public DataPanelMain returnDataPanel(int i) {
		Component[] components = this.mainPanel.getComponents(); 
		JTabbedPane tabPanel = (JTabbedPane)components[1];
		DataPanelMain dPanel = (DataPanelMain)tabPanel.getComponentAt(i);
		
		return(dPanel);
	}

In the second line, this. refers to the frame and mainPanel refers to the panel I use to hold the three other panels for the first swing interface. Surely that means there are 3 elements in mainPanel? The tabbed pane is the second component added to the mainPanel so it should be at index [1] and there should be at least one pane in the tabbed pane. How else can I access the panes held in the tabbed pane?

Also, the variables weren't meant to be static, I changed that. I can only see one JTabbedPane in my code.

[Tom Huddersfield]

Ok I changed the for loop in line 282 to have a condition of < not <=, but now I get this error message

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
at PieChartMainMenu$PieGraphicPanel.paintComponent(PieChartMainMenu.java
:301)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JLayeredPane.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paintToOffscreen(Unknown Source)
at javax.swing.BufferStrategyPaintManager.paint(Unknown Source)
at javax.swing.RepaintManager.paint(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at java.awt.GraphicsCallback$PaintCallback.run(Unknown Source)
at sun.awt.SunGraphicsCallback.runOneComponent(Unknown Source)
at sun.awt.SunGraphicsCallback.runComponents(Unknown Source)
at java.awt.Container.paint(Unknown Source)
at java.awt.Window.paint(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.seqPaintDirtyRegions(Unknown Source)
at javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(Unknow
n Source)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Any help?

[Campbell Ritchie]

Tom Huddersfield wrote: . . .
Also, I'm not intentionally using vectors, where does that come?

I presume Pete Stein's explanation in the post previous to that is correct; there is a Component which hides a Vector in its implementation somewhere, rather than a more efficient and modern implementation (eg ArrayList).
You will find Vector towards the top of the stack trace printed from your exception.

[Tom Huddersfield]

How can I fix that?

[Rob Spoor]

Let's give you a little lesson in how to read exception stack traces. Let's take your first example:

Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException:
 1 >= 1

That's the exception that has occurred (java.lang.ArrayIndexOutOfBoundsException), its message (1 >= 1) and the thread it occurred in ("AWT-EventQueue-0", the EDT).

        at java.util.Vector.elementAt(Unknown Source)

That's the actual piece of code the exception occurred at. With your own code you can usually see the file and line number, but you can usually only see those of the core Java classes when running the JDK's java tool, not the JRE's.

        at javax.swing.JTabbedPane.getComponentAt(Unknown Source)

That's the piece of code that was calling the above line.

        at PieChartMainMenu.returnDataPanel(PieChartMainMenu.java:55)

Again, the piece of code that was calling the above line. This is your code; the file is PieChartMainMenu.java and the line is 55.

        at PieChartMainMenu$PieGraphicPanel.paintComponent(PieChartMainMenu.java:285)

Again, the piece of code that was calling the above line.
You usually start at the top, and ignore all the classes you did not write. The first line of your code (line 55) is where you need to start checking. Mostly, if that's not the top line, you provided an incorrect method argument. It's possible there is a bug in the library you are using (in this case the core API) but usually that's not the case.

Now your second example:

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException

OK, a NullPointerException. No message is given.

        at PieChartMainMenu$PieGraphicPanel.paintComponent(PieChartMainMenu.java:301)

And there's your class at the top. Line 301 is exactly where you need to check. Somewhere you have something at the left hand side of a . that is null. In this case, I suspect "theDatas[i].size.getText()". You have an array of size 3 of which you only set as many elements as you have tabs. If you only have 0 or 1 tabs then you will have 2 or 1 null elements (you're using <= for the number of tabs). As such, for i = 1 and/or i = 2, theDatas[i] is null.


Oh, and you definitely want to call super.paintComponent(g) as the first statement of your paintComponent method - which should remain protected, not coderanch.

[Tom Huddersfield]

That was really helpful, I managed to fix the problem now

[Rob Spoor]

You're welcome