Here i am again with if/else statement now

[Michael Humphreys]

Well, I am still struggling with the control statements in my program., and I am now getting an error on the "main" method . I am lost with both errors. I just don't understand what I am missing. I do appreciate all of the help i have gotten I hope you don't get tiered of me. (smiles) Here is my code

/**
 * @author Michael Humphreys
 * This program was origanaly written in TandyBasic many years ago
 * This is an updated java program.
 *
 */
public class chickens {
		private static final int yield = 0;
		private static final int cost = 0;
		private static final String loss = null;
		public static void main(String [] args) {
            int chickens = 110;
            int hens = 100;
            double numberOfEggsLaid = 110;
            double costOfFeed = 200.00;
            double cost = 0;
            double priceOfEggs=(2.25 / 12);
            double yeild;
            double profit;
            double loss = 0;
            double yield = 0;
            double cost1 = costOfFeed / chickens;            
            double yeild1 = numberOfEggsLaid * priceOfEggs;
            double profit1 = yield - cost1;
            double loss1 = yield - cost1;
            double profitLoss = (yield-cost1);
System.out.println("Number Of Hens =" + hens);
System.out.println("Number Of Eggs Laid =" + numberOfEggsLaid);
System.out.println("CostOf Feed =" + costOfFeed);	
	if (yield-cost1 == 0.00);{
		 profitLoss = (yield - cost1);}
		}else{
			System.out.println("You Broke Even. Bummer!!");}
			if (yield - cost > 0.00 == true);{
					Object profit = (yield - cost);
				}else{
					double profit;
					System.out.println("Profit=" + profit);}
					System.out.println("You Made A Profit. Way To Go!!!");
						if (yeild - cost < 0.00 == true);{
							int loss = (yield - cost);
						}else{
							System.out.println("Loss="+loss);
							System.out.println("OH No, You had a loss!! What's the price of chicken meat???");}
						
			}

}

Thanks again for your help.

[Tom Reilly]

You can usually find these types of problems by formatting your code. Here's my attempt. Notice the paucity of braces at the bottom. Also each one of your if statements have the same flaw. Do you recognise it?

/**
 * @author Michael Humphreys
 * This program was origanaly written in TandyBasic many years ago
 * This is an updated java program.
 *
 */
public class chickens
{
    private static final int yield = 0;
    private static final int cost = 0;
    private static final String loss = null;
    
    public static void main(String [] args)
    {
        int chickens = 110;
        int hens = 100;
        double numberOfEggsLaid = 110;
        double costOfFeed = 200.00;
        double cost = 0;
        double priceOfEggs = (2.25 / 12);
        double yeild;
        double profit;
        double loss = 0;
        double yield = 0;
        double cost1 = costOfFeed / chickens;            
        double yeild1 = numberOfEggsLaid * priceOfEggs;
        double profit1 = yield - cost1;
        double loss1 = yield - cost1;
        double profitLoss = (yield-cost1);
        
        System.out.println("Number Of Hens =" + hens);
        System.out.println("Number Of Eggs Laid =" + numberOfEggsLaid);
        System.out.println("CostOf Feed =" + costOfFeed);
        
        if (yield-cost1 == 0.00);
        {
            profitLoss = (yield - cost1);
        }
        } else {
            System.out.println("You Broke Even. Bummer!!");
        }
        
        if (yield - cost > 0.00 == true);
        {
            Object profit = (yield - cost);
        } else {
            double profit;
            System.out.println("Profit=" + profit);}
            System.out.println("You Made A Profit. Way To Go!!!");
            if (yeild - cost < 0.00 == true);
            {
                int loss = (yield - cost);
            } else {
                System.out.println("Loss="+loss);
                System.out.println("OH No, You had a loss!! What's the price of chicken meat???");}
            }
}

[Tom Reilly]

Also, having a member variable yield and a local variable yeild (spelling error) is what they call a "bug waiting to happen" if it isn't already

[fred rosenberger]

check your semi-colons.

[Michael Humphreys]

Hi Tom I have looked and looked at this code till I am blue in my face....I can not for the life of me figure out what it is. and I didn't conceder your other point yet I have to figure out this if/else statement. It is my next step tho. Thank you for your comments Tom.

[Tom Reilly]

One problem is you have an extra brace at line 38.

[Michael Humphreys]

Thank you Tom I found thew extra brace. I took a look at the semi-colons and I have one for each statement so am I to assume that I don't need one or more???
Thank you again
Michael

[Paul Clapham]

Here's one of your if-statements:

if (yield-cost1 == 0.00);

It says "If yield-cost1 is equal to 0, then don't do anything".

I seem to recall posting this before, though. Was that on one of your threads? Anyway go off and look at some example code written by other people. A tutorial, for example. Does that other example put a semicolon in that position?

[Dhruva Mistry]

Hi Michael,

You needed to remove extra un imp commas after if and else statements & before the if block starts with an open curly brace. and some extra ending curly braces.
apart from that, here is the code you may need :

public class TestIfElse {   
    private static final int yield = 0;   
    private static final int cost = 0;   
    private static final String loss = null;   
    public static void main(String [] args) {   
    	int chickens = 110;   
        int hens = 100;   
        double numberOfEggsLaid = 110;   
        double costOfFeed = 200.00;   
        double cost = 0;   
        double priceOfEggs=(2.25 / 12);   
        double yeild;   
//      double profit;
//	initialization needed here as "local variables"(var in methods) must be (manually)initialized before they r used
        double profit = 0;
        double loss = 0;   
        double yield = 0;   
        double cost1 = costOfFeed / chickens;               
        double yeild1 = numberOfEggsLaid * priceOfEggs;   
        double profit1 = yield - cost1;   
        double loss1 = yield - cost1;   
        double profitLoss = (yield-cost1);   
        
        System.out.println("Number Of Hens =" + hens);   
        System.out.println("Number Of Eggs Laid =" + numberOfEggsLaid);   
        System.out.println("CostOf Feed =" + costOfFeed);      
        if (yield-cost1 == 0.00)
        {   
        	profitLoss = (yield - cost1);   
        }
        else if (yield - cost > 0.00 == true){   
//     		Object profit = (yield - cost);			profit is already used and profit1 too 
        	Object profit3 = (yield - cost);
        }
        else{   
//     		double profit;						   	profit is already used and profit1 too
        	System.out.println("Profit=" + profit);}   
        	System.out.println("You Made A Profit. Way To Go!!!");   
//     		if (yeild - cost < 0.00 == true){       spelling of yield is wrong
        	if (yield - cost < 0.00 == true){  
//         	int loss = (yield - cost);				loss is already used
        		loss = (yield - cost); 
        	}
        	else{   
        		System.out.println("Loss="+loss);   
                System.out.println("OH No, You had a loss!! What's the price of chicken meat???");
        	}   
                       
    }   

}

[Michael Humphreys]

Hi all,
I want to ask a question of etiquette on a forum. Should I keep this thread going as I sill have questions in regards to this program although some issues have been solved Others come up as a consequence of those we have talked about already. I guess what I am asking is should i start a new thread for each new issue or continue this thread and add new issues as they come up. Thanks for all the help so far.
Michael

[Campbell Ritchie]

I suggest you keep this thread for questions arising from previous questions. It is a bad idea to have two threads about the same thing.

Beware of long lines in code tags; they are difficult to read. Use space not tab for indentation; if you have a decent text editor (eg NotePad2, NotePad++, jEdit) you can set an option to convert a tab to 4 spaces.

[Campbell Ritchie]

Beware: you have a local variable called yield and one called yeild. You are only using one, so should delete the other.

[Michael Humphreys]

Hi all,
I would like to thank Dhruva,Paul,and Tom for their help on this issue. I have spent some time and worked out all the issues that we have talked about so far. I sill have one issue remaining. As the program runs it is supposed to evaluate the first "if then else" flow control. If the statement is true then print 0.00. If false move to the next control flow statement and evaluate the "if-then-else" If true print Profit2. If false move to the next statement and print loss.

Now when I run the program all works until i have a "loss" which causes the second control flow statement to print a negative amount for profit2, instead of moving on to the third flow control statement and printing a loss. If you would like to see the code here it is followed by the output.

/**
 * @author Michael Humphreys
 * This program was origanaly written in TandyBasic many years ago
 * This is an updated java program.
 *
 */
public class chickens {
    private static final int yield = 0;
    private static double loss = 0;
    public static void main(String [] args){
        int chickens = 110;
        int hens = 100;
        int numberOfEggsLaid = (110 * 30);
        double costOfFeed = 100.00;
        double priceOfEggs = 2.25;
        double cost = costOfFeed;        
        double yeild = (priceOfEggs *( numberOfEggsLaid / 12)); 
            
        System.out.println("Number Of Chickens =" + chickens);   
        System.out.println("Number Of Hens = " + hens);
        System.out.println("Number Of Eggs Laid = " + numberOfEggsLaid);
        System.out.println("CostOf Feed =" + costOfFeed);

        if (yield - cost == 0.00){      
            double breakEven = (yield - cost);
            System.out.println("You made NOTHIN'" + breakEven);
        }  
        else if (yield - cost > 0.00 == true){  
        }  
        else{     
            double profit2 = (yeild-cost);
        }                     
        System.out.println("Profit = " + profit2);     
        System.out.println("You Made A Profit. Way To Go!!!");     
		
        if (yield - cost < 0.00 == false){
            loss = (yield - cost);   
        }
        else{     
            System.out.println("Loss = "+loss);     
            System.out.println("OH No, You had a loss!! What's the price of chicken meat???");  
        }                
    }
}

OUTPUT:

Number Of Chickens =110
Number Of Hens = 100
Number Of Eggs Laid = 3300
CostOf Feed =400.0
Profit = -56.25
You Made A Profit. Way To Go!!!

Once again thanks for all the help.

Michael

[Campbell Ritchie]

I have tried to improve your indentation; incorrect indentation makes code hard to read and risks errors with {} not being matched.
Never write == true. Just delete all the == trues in your code.
Never write == false. Change if (b == false) to if (!b) . . . Remember you may bneed () after the ! to maintain precedences
You have one else if followed by {}. Why are you using an empty block?
You are using == 0.00. Remember you may never reach 0 using floating-point numbers because of their inherent imprecision.

[Campbell Ritchie]

You still need to check the spelling of yield and yeild.

[Michael Humphreys]

Hey Hey thanks Campbell I got it you gave some great pointers. One thing I have learned is that I have to READ more closely. I am making stupid mistakes. Any way here is the code:

/**
 * @author Michael Humphreys
 * This program was origanaly written in TandyBasic many years ago
 * This is an updated java program.
 *
 */
public class chickens {

	private static final int yield = 0;
	private static double loss = 0;
	public static void main(String [] args){
		int chickens = 110;
		int hens = 100;
		int numberOfEggsLaid = (90 * 30);
		double costOfFeed = 450.00;
		double priceOfEggs = 1.95;
		double cost = costOfFeed;        
		double yield = (priceOfEggs *( numberOfEggsLaid / 12)); 

		System.out.println ("The price of eggs? " + priceOfEggs);           
		System.out.println("Number Of Chickens =" + chickens);   
		System.out.println("Number Of Hens = " + hens);
		System.out.println("Number Of Eggs Laid = " + numberOfEggsLaid);
		System.out.println("CostOf Feed =" + costOfFeed);

		if (yield - cost == 0.00){      
			double breakEven = (yield - cost);
			System.out.println("You made NOTHIN'" + breakEven);
		}
		else{
			if (yield - cost > 0.00 != false){
				double profit = (yield - cost);                      
				System.out.println("Profit = " + profit);     
				System.out.println("You Made A Profit. Way To Go!!!");
			}
			else{

				if (yield - cost < 0.00 != false){
					loss = (yield - cost);   
					System.out.println("Loss = "+ loss);     
					System.out.println("OH No, You had a loss!! What's the price of chicken meat???");  
				}     
			}               
		}     
	}
}

[Campbell Ritchie]

You're welcome
You seem to have a != false in there somewhere; you should delete that as it does nothing at all.
Rather than yield - cost == 0, try yield == cost. As I said earlier, you may not get that exactly, because of imprecisions in floating-point arithmetic, so try
if (Math.abs(yield - cost) < 0.005) . . .
Your breakEven in that case ought to be 0; since you only use the breakEven value in that single if block, you may be able to dispense with it and simply write 0. Note you won't get 0.00 printed unless you use a special instruction. There are several possible instructions, of which printf( . . . %.2f . . . ) might be the easiest.

That means you are allowing up to ½ cent as a margin for errors and still regarding the profit as zero.

[Michael Humphreys]

Happy New Year Everyone!!

I have read all of your comments, thanks again Campbell, and came up with a working copy of code. (Campbell, I haven't addressed the issue with the Break even point yet but that will be my next refinement.) I have learned a lot from you all. TY Here is my code:

/**
 * @author Michael Humphreys
 * This program was origanaly written in TandyBasic many years ago
 * This is an updated java program.
 *
 */
public class chickens {

	private static final int yield = 0;
	private static double loss = 0;
	public static void main(String [] args){
		int chickens = 110;
		int hens = 100;
		int numberOfEggsLaid = (90 * 30);
		double costOfFeed = 5+50.00;
		double priceOfEggs = 1.95;
		double cost = costOfFeed;        
		double yield = (priceOfEggs *( numberOfEggsLaid / 12)); 
		
		System.out.println ("The price of eggs? " + priceOfEggs);           
		System.out.println("Number Of Chickens =" + chickens);   
		System.out.println("Number Of Hens = " + hens);
		System.out.println("Number Of Eggs Laid = " + numberOfEggsLaid);
		System.out.println("CostOf Feed =" + costOfFeed);

		if (yield - cost == 0.00){      
			double breakEven = (yield - cost);
			System.out.println("You made NOTHIN'" + breakEven);
		}
		else{
			if (yield - cost > 0.00 != false){
				double profit = (yield - cost);                      
				System.out.println("Profit = " + profit);     
				System.out.println("You Made A Profit. Way To Go!!!");
			}
			else{

				if (yield - cost < 0.00 != false){
					loss = (yield - cost);   
					System.out.println("Loss = "+ loss);     
					System.out.println("OH No, You had a loss!! What's the price of chicken meat???");  
				}     
			}               
		}     
	}
}