Servlet Filter Issue

[Naveen puttu]

Hi,

Below is a servlet filter code

/**
 * 
 */
import java.io.IOException;

import javax.servlet.Filter;
import javax.servlet.FilterChain;
import javax.servlet.FilterConfig;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;



/**
 * @author mnaveen
 *
 */
public class FrontControllerFilter implements Filter {

	
	protected static final String BUYER 	= "BUYER";
	protected static final String SUPPLIER 	= "SUPPLIER";
	FilterConfig fConfig = null;
	public void destroy() {

	}

	/* (non-Javadoc)
	 * @see javax.servlet.Filter#doFilter(javax.servlet.ServletRequest, javax.servlet.ServletResponse, javax.servlet.FilterChain)
	 */
	public void doFilter(ServletRequest request, ServletResponse response,
			FilterChain chain) throws IOException, ServletException {
		HttpServletRequest req = (HttpServletRequest)request;
		HttpServletResponse res = (HttpServletResponse)response;
		String eventId = request.getParameter("eventId");
		String url = null;
		if(null != eventId){
			SourcingEvent event = SourcingRestWebUtil.getEventWithEventConfig(req);
			if("BUYER".equals(getRole(req,event))){
				if("PUBLISHED".equals(event.getStatus().toString())){
					url = fConfig.getInitParameter("buyerPub");
					res.sendRedirect(url);
//					req.getRequestDispatcher(url).forward(request, response);
				}
				else if("LIVE".equals(event.getStatus().toString())){
					url = fConfig.getInitParameter("buyerLive");
					res.sendRedirect(url);
					return;
//					req.getRequestDispatcher(url).forward(request, response);
				}
				else{
					forwardToUrl(request,response,chain);
				}
			}
			else{
				if("PUBLISHED".equals(event.getStatus().toString())){
					url = fConfig.getInitParameter("buyerPub");
					req.getRequestDispatcher(url).forward(request, response);
				}
				else if("LIVE".equals(event.getStatus().toString())){
					url = fConfig.getInitParameter("buyerPub");
					req.getRequestDispatcher(url).forward(request, response);
				}
				else{
					forwardToUrl(request,response,chain);
				}
			}
		}

	}
	
	private void forwardToUrl(ServletRequest request, ServletResponse response,
			FilterChain chain) throws IOException, ServletException {
		chain.doFilter(request, response);
	}
	
	private String getRole(HttpServletRequest request, SourcingEvent event){
		String role = "";
		String username = SourcingRestWebUtil.getClientUserId(request);
		String userId = SourcingRestWebUtil.getClientEvaluatorId(request); 
		if (event.getCreatedBy().equals(userId)) {
			return BUYER;
		}
		else{
			return SUPPLIER;
		}
	}
	
	/* (non-Javadoc)
	 * @see javax.servlet.Filter#init(javax.servlet.FilterConfig)
	 */
	public void init(FilterConfig config) throws ServletException {
		this.fConfig = config;

	}

}

I get IllegalStateException if try to redirect or use RequestDispatcher . It says "Cannot forward after response is committed"

Please help

Cheers
Naveen

[Malatesh Karabisti]

Can you please post head of the error stack trace ?

[Naveen puttu]

Here is the stack trace

java.lang.IllegalStateException
     at org.apache.catalina.connector.ResponseFacade.sendRedirect(ResponseFacade.java:432)
     at com.ketera.sourcing.filter.FrontControllerFilter.doFilter(FrontControllerFilter.java:55)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at com.ketera.sourcing.filter.SourcingAuthFilter.forwardToUrl(SourcingAuthFilter.java:207)
     at com.ketera.sourcing.filter.SourcingAuthFilter.doFilter(SourcingAuthFilter.java:74)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at org.displaytag.filter.ResponseOverrideFilter.doFilter(ResponseOverrideFilter.java:125)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at com.ketera.sourcing.filter.SessionFinalizerFilter.doFilter(SessionFinalizerFilter.java:33)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at com.ketera.web.util.KeteraSessionInitializer.doFilter(KeteraSessionInitializer.java:65)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at edu.yale.its.tp.cas.client.filter.CASFilter.doFilterWrapped(CASFilter.java:1033)
     at edu.yale.its.tp.cas.client.filter.CASFilter.doFilter(CASFilter.java:591)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at com.ketera.sourcing.web.util.UTF8Filter.doFilter(UTF8Filter.java:41)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
     at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
     at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
     at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:175)
     at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:74)
     at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
     at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
     at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
     at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
     at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
     at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
     at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
     at org.apache.tomcat.util.net.MasterSlaveWorkerThread.run(MasterSlaveWorkerThread.java:112)
     at java.lang.Thread.run(Thread.java:595)

By the way the control goes in this flow only at the moment

else if("LIVE".equals(event.getStatus().toString())){  
                    url = fConfig.getInitParameter("buyerLive");  
                    res.sendRedirect(url);  
                    return;  
//                  req.getRequestDispatcher(url).forward(request, response);  
                }

To add to the misery . The filter works perfectly fine once the server is restarted , but then throws this exception after a while (lets say when session times out )

I dont know whatz happening

Cheers
Naveen

[Malatesh Karabisti]

else if("LIVE".equals(event.getStatus().toString())){     
                    url = fConfig.getInitParameter("buyerLive");     
                    res.sendRedirect(url);     
                    // return;     
//                  req.getRequestDispatcher(url).forward(request, response);     
                }  

have you tried by commenting the "return" in the block just try this

[Naveen puttu]

Did that , still NO GO

[parampreet sethi]

You can try putting return after each forward and response.sendredirect method calls.

The forward and sendredirect method calls does not mean that the rest of the code will be ignored. Yesterday I was having the same issue and putting return after each sendRedirect and forward fixed this issue.

Hope it helps.

[Naveen puttu]

parampreet sethi wrote:You can try putting return after each forward and response.sendredirect method calls.

The forward and sendredirect method calls does not mean that the rest of the code will be ignored. Yesterday I was having the same issue and putting return after each sendRedirect and forward fixed this issue.

Hope it helps.

I tried that , as explained earlier . It works fine until the session times out . After that we are back to square one