Downloaded file contains garbage value

[Shounak Kundu]

Hi,

I want to download a .doc file from my DB2 database.

The uploading portion , works fine.

But , when I am trying to download, the downloaded file contains garbage value.

<%
				ResultSet rs  = null;
				
				PreparedStatement ps = null;
				
				Connection con = null;
				
				try
				{
					InitialContext ctx = new InitialContext();
					
					DataSource ds = (DataSource)ctx.lookup("java:comp/env/jdbc/MyDataSource");
					
					con = ds.getConnection();
					
					String query = "SELECT * FROM JSKCV";
					
					ps = con.prepareStatement(query);
					
					rs = ps.executeQuery();
					
					while(rs.next())
					{
						
						out.println("<a href=\"download2.jsp?uploadid="+rs.getString("UPLOADID")+"\">"+rs.getString("FILENAME"));
						
						out.println("<br>");
						
					}
					
					
					
					
					
				}catch(NamingException ne)
				{
					
					
					
				}catch(SQLException se)
				{
					
				}
				
				
				







%>

and here 's the main culprit :


download2.jsp:

<%

			ResultSet rs  = null;
			
			PreparedStatement ps = null;
			
			Connection con = null;
			
			String uploadid = request.getParameter("uploadid").toString();
			
			
			
			String Content=new String("");
			
		
			
			try
			{
				String filename="data"+uploadid+".doc";
				
				InitialContext ctx = new InitialContext();
				
				DataSource ds = (DataSource)ctx.lookup("java:comp/env/jdbc/MyDataSource");
				
				con = ds.getConnection();
				
				String query1 = "SELECT BINARYFILE FROM JSKCV WHERE UPLOADID=?";
				
				ps = con.prepareStatement(query1);
				
				ps.setString(1,uploadid);
				
				rs = ps.executeQuery();
				
				while(rs.next())
				{
					Content=rs.getString("BINARYFILE");
					
				}
				
				byte requestBytes[] = Content.getBytes();
				
				out.println(" No. of bytes :"+requestBytes);
				
				response.setContentType( "application/msword" );
				
				response.setHeader("Content-Disposition","attachment; filename=\""+filename+"\"");
				response.setHeader("cache-control", "no-cache");

				
				ServletOutputStream outs = response.getOutputStream();
				outs.write(requestBytes);
				outs.flush();
				outs.close();
				
				
								
								
			}
			catch(NamingException ne)
			{
				
				
			}
			catch(SQLException se)
			{
				
			}

			%>

Here's my table structure :

Table JSKCV
(
    UPLOADID VARCHAR(15) PRIMARY KEY,
    FILENAME VARCHAR(35)    NOT NULL,
    BINARYFILE BLOB 1MB NOT NULL
   



)

Can you tell me where's the problem ?

Thanks in advance...

[Shounak Kundu]

Ok, the problem has been resolved..

I was damn foolish to rs.getString the BINARYFILE. Later , I changed to rs.getBytes , and everything worked fine.

But, now I have one problem:

How can I print the content of the .doc file on the browser ?

I mean , what MIME type I have to use ?

I have tried using "application/msword" , but it is prompting to download rather than printing the content .

the "text/plain" and "text/html" are printing unwanted ascii characters and that looks horrible

Can you please help me ?

[Rob Spoor]

Let's move this to our JSP forum.

Shounak Kundu wrote:

String Content=new String("");

Please don't use this String constructor, ever. Just use

String Content = "";

And Content should of course start with a lower case c.

out.println(" No. of bytes :"+requestBytes);
				
response.setContentType( "application/msword" );
				
response.setHeader("Content-Disposition","attachment; filename=\""+filename+"\"");
response.setHeader("cache-control", "no-cache");

ServletOutputStream outs = response.getOutputStream();
outs.write(requestBytes);
outs.flush();
outs.close();

You're writing to the response using both the Writer ("out") and the ServletOutputStream ("outs"). That's not going to work. You should either write to the Writer, or to the ServletOutputStream. Not to both. Warning: any enters in the JSP file outside of the JSP tags are still sent to the Writer. This includes enters between JSP directives like imports etc. That's why JSP files are not that great for handling binary files.

[Rob Spoor]

Shounak Kundu[b wrote:How can I print the content of the .doc file on the browser ?[/b]

I mean , what MIME type I have to use ?

I have tried using "application/msword" , but it is prompting to download rather than printing the content .

the "text/plain" and "text/html" are printing unwanted ascii characters and that looks horrible

When you use text/plain or text/html the binary contents are printed as if they were text. That's definitely not going to work.
In fact, there is nothing at all you can do about this. You already have the right MIME type. The problem is in the browser. Browsers can display text, HTML, XML and most images. For most other content they need a plugin. PDF and Flash are well-known plugins for browsers. So you'll need to install a plugin that will display the Word file for you. Unfortunately, I have never heard of any such plugin.

[Shashank Ag]

Well rob that is not entirely correct, probably you can look in to apache tika.
Its a two min api to learn.

So, you can pass stream of bytes and convert you word document to html on the fly.
Only drawback is, it is little CPU intensive. Other libraries are mostly paid.