losing data

[andrew cassato]

I cant figure out why i am losing the data here, when i press compute scores i get 0.0. the array score takes in the data just fine but i cant figure out where it goes at the end... error is at line 88 in the GUI class
JUDGING

view plaincopy to clipboardprint?
import java.util.Scanner;  
import javax.swing.*;  
import javax.swing.JOptionPane;  
import java.awt.*;  
import java.awt.event.*;  
import java.applet.Applet;  
/** 
 * Write a description of class Judging here. 
 *  
 * @author (your name)  
 * @version (a version number or a date) 
 */  
public class Judging  
{  
    private int n =0;  
    private double[] score = new double[n];  
    private double maxScore=0, minScore=11, totalScore=0, finalScore=0;  
    private double result =finalScore;  
    //Judging judge = new Judging();  
    public Judging(int n)  
    {  
        score = new double[n];  
        this.n = n;  
        Scanner console = new Scanner(System.in);  
        String answer = "", name="";  
    }  
    public  void setScores(double[] score)  
    {  
        this.score = score;  
    }  
    public void inputScores()  
    {  
        Scanner console = new Scanner(System.in);  
        int n=0;  
        String name = "", scoresS="";  
        double[] score = new double[n];  
        for (int i = 0; i < n; i++)  
        {  
           score[i] = Double.parseDouble(JOptionPane.showInputDialog (null,"enter score "+(i+1)));  
           if((score[i]) > 10)  
           {  
               JOptionPane.showMessageDialog(null,  
               "You can't score higher than 10",  
               "OOPS!",  
               JOptionPane.ERROR_MESSAGE);  
               i--;  
            }  
           else  
           {  
               i++;  
            }  
        }  
    }  
    public void calculateScore()  
    {  
        int n=8;  
        double[] score = new double[n];  
        //max score  
        for (int i = 0; i < n; i++)  
        {  
           if (score[i] > maxScore)  
           {  
              maxScore=score[i];  
            }  
        }  
        //min score  
        for (int i = 0; i < n; i++)  
        {  
           if (score[i] < minScore)  
           {  
               minScore = score[i];  
            }  
        }  
         //total score  
        for (int i = 0; i<n; i++)  
        {  
            totalScore = (totalScore + score[i]);  
        }  
        //final score  
        finalScore = (totalScore - (minScore+maxScore));  
    }  
    public double[] getScores()  
    {  
        return score;  
    }  
    public double getResult()  
    {  
        return result;  
    }  
}  

GUI

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.applet.Applet;

/**
 * Class JudgingApplet - write a description of the class here
 * 
 * @author (your name) 
 * @version (a version number)
 */
public class JudgingGUI extends JFrame
{
    int n = 8;
    double result;
    private final int APPLET_WIDTH = 450;
    private final int APPLET_HEIGHT = 200;
    private JLabel contestantName,scoreLabel,resultL;
    private JTextField name;
    private JTextField scores[] = new JTextField[n];
    private JLabel judges[] = new JLabel[n];
    private double[] score;
    String resultString = Double.toString(result);
    
    JButton scoreB;
    JButton resetB;
    
    Judging judge;
    
    public JudgingGUI(int n)
    {
        setSize(APPLET_WIDTH,APPLET_HEIGHT);
        setLayout(new FlowLayout());
        
        judge = new Judging(n);
        
        scoreB = new JButton("Compute Score");
        JudgeListener cbHandler;
        cbHandler = new JudgeListener();
        scoreB.addActionListener(cbHandler);
        
        resetB = new JButton("Reset Scores for Next Contestant");
        JudgeListener rbHandler;
        rbHandler = new JudgeListener();
        resetB.addActionListener(rbHandler);
        
        contestantName = new JLabel("Name of contestant");
        scoreLabel = new JLabel("Contestant's score:");
        name = new JTextField(25);
        judges = new JLabel[n];
        
        resultL = new JLabel(resultString);

        add(contestantName);
        add(name);        
        for(int i=0; i<n; ++i)
        {
            judges[i] = new JLabel("Judge "+(i+1));
            add(judges[i]);
            scores[i] = new JTextField(4);
            add(scores[i]);
        } 
        add(scoreB);
        add(scoreLabel);
        add(resultL);
        add(resetB);
        
    }
    private class JudgeListener implements ActionListener
    {
       public void actionPerformed(ActionEvent e)
       {  
            int n=8;
            double result=0;
            double[] score = new double[n];
            Object source = e.getSource();
            if(e.getSource()==scoreB)
            { 
                for(int i=0; i<n; i++)
                {
                    score[i] = Double.parseDouble(scores[i].getText());
                }
                judge.setScores(score);
                judge.calculateScore();
                judge.getScores();
                judge.getResult();

                System.out.println(result);
            }     
            
            if(e.getSource()==resetB)
            {
                for(int i=0; i<n; i++)
                {
                    score[i]=(0);
                    scores[i].setText("");
                } 
            }
       }
     }
}

TEST

 
view plaincopy to clipboardprint?
public class TestJudging  
{  
    public static void main(String[] args)  
    {  
        int n=8;  
        JudgingGUI example = new JudgingGUI(n);  
        example.setVisible(true);  
    }  
}  

Thanks for taking a look for me

[marc weber]

Okay, that's a lot of code; so to be honest, I haven't looked at it.

But my suggestion is to add lots of println statements at various points, to determine what the values are at each stage.

[Jesper de Jong]

Look at the actionPerformed method of your JudgeListener; especially lines 73 - 89.

In line 74, you declare a variable called result which you set to 0. In line 88, you are printing the value of that variable. But nowhere in between lines 74 and 88 are you assigning any other value to result, so it will still be 0 when the program reaches line 88, and it will always print 0.

Probably you meant to write this in line 86:

result = judge.getResult();

[andrew cassato]

tried
result = judge.getResult();
but still wont work. i have used the debugger to make sure the data is ok up until this last part where its gone because i am not storing it after getResult (i think) - but i am not sure how to do that.

[fred rosenberger]

when you make these calls:

judge.getScores();  
judge.getResult();  

you are not saving what comes back. Therefore, the values are lost. As Jesper says, you need to save these values, and then print the variable where you saved them.

[andrew cassato]

i understand i need to save them, that makes perfect sense, i just dont know where to do so...

when i have the contestants final score come up does that belong in a JTextField or JLabel?

[Campbell Ritchie]

You can put the results anywhere you want; if you want a Component which the user can't alter, setting the text on a JLabel sounds a good idea.

[fred rosenberger]

andrew cassato wrote:i understand i need to save them, that makes perfect sense, i just dont know where to do so...

In your actionPerformed() method of the JudgeListener class, you have a variable called "result". I would suggest you use this to store the result.

result = judge.getResult();