JdbcTemplate and IllegalArgumentException

[Deepaks Deshpande]

Hey guys,

I am trying the JdbcTemplate example given in the Spring in Action book. My classes are the following

package test.spring.jdbc.domain;


public class Motorist {

	private int id;
	private String email;
	private String password;
	private String firstName;
	private String lastName;
	
	/**
	 * @param lastName 
	 * @param firstName 
	 * @param password 
	 * @param email 
	 * @param id 
	 * 
	 */
	public Motorist(int id, String email, String password, String firstName, String lastName) {
		// TODO Auto-generated constructor stub
		this.id = id;
		this.email = email;
		this.password = password;
		this.firstName = firstName;
		this.lastName = lastName;
	}

	public Motorist() {
		// TODO Auto-generated constructor stub
	}
	/**
	 * @return the id
	 */
	public int getId() {
		return id;
	}

	/**
	 * @param id the id to set
	 */
	public void setId(int id) {
		this.id = id;
	}

	/**
	 * @return the email
	 */
	public String getEmail() {
		return email;
	}

	/**
	 * @param email the email to set
	 */
	public void setEmail(String email) {
		this.email = email;
	}

	/**
	 * @return the password
	 */
	public String getPassword() {
		return password;
	}

	/**
	 * @param password the password to set
	 */
	public void setPassword(String password) {
		this.password = password;
	}

	/**
	 * @return the firstName
	 */
	public String getFirstName() {
		return firstName;
	}

	/**
	 * @param firstName the firstName to set
	 */
	public void setFirstName(String firstName) {
		this.firstName = firstName;
	}

	/**
	 * @return the lastName
	 */
	public String getLastName() {
		return lastName;
	}

	/**
	 * @param lastName the lastName to set
	 */
	public void setLastName(String lastName) {
		this.lastName = lastName;
	}

	

	/* (non-Javadoc)
	 * @see java.lang.Object#toString()
	 */
	@Override
	public String toString() {
		return "Motorist [email = " + email + ", firstName = " + firstName
				+ ", id = " + id + ", lastName = " + lastName + ", password = "
				+ password + ", toString() = " + super.toString() + "]";
	}

}

package test.spring.jdbc.dao;

import test.spring.jdbc.domain.Motorist;

public interface MotoristService {
	void saveMotorist(Motorist motorist);
	Motorist getMotoristById(int id);
}

package test.spring.jdbc.doaimpl;

import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.List;

import javax.sql.DataSource;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.dao.DataAccessException;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.RowMapper;

import test.spring.jdbc.dao.MotoristService;
import test.spring.jdbc.domain.Motorist;

public class MotoristServiceImpl extends JdbcTemplate implements MotoristService{
	protected final Log logger = LogFactory.getLog(getClass());
	private JdbcTemplate jdbcTemplate;
	/**
	 * 
	 */
	
	public void setJdbcTemplate(JdbcTemplate jdbcTemplate){
		this.jdbcTemplate = jdbcTemplate;
	}
	
	public void setDataSource(DataSource dataSource) {
		this.jdbcTemplate = new JdbcTemplate(dataSource);
	}
	
	public JdbcTemplate getTemplate(){
		return jdbcTemplate;
		
	}

	@Override
	public void saveMotorist(Motorist motorist) {
		// TODO Auto-generated method stub
		String sqlQuery = "INSERT INTO coderanch.motorist(id, email, password, firstname, lastname) VALUES (?,?,?,?,?)";
		logger.info(":::::: Going to execute query ::::::: "+sqlQuery);
		jdbcTemplate.update(sqlQuery,
				new Object[] { motorist.getId(), motorist.getEmail(),
				motorist.getPassword(), motorist.getFirstName(),
				motorist.getLastName()});
	}

	@Override
	public Motorist getMotoristById(int id) {
		// TODO Auto-generated method stub
		String sqlQuery = "SELECT * FROM coderanch.motorist WHERE id = ?";
		logger.info(":::::: Going to execute query ::::::: "+sqlQuery);
		List<Object> matches = jdbcTemplate.query(sqlQuery,
				new Object[] { Integer.valueOf(id) }, new RowMapper<Object>() {
					public Object mapRow(ResultSet rs, int rowNum)
							throws SQLException, DataAccessException {
						Motorist motorist = new Motorist();
						motorist.setId(rs.getInt(1));
						motorist.setEmail(rs.getString(2));
						motorist.setPassword(rs.getString(3));
						motorist.setFirstName(rs.getString(4));
						motorist.setLastName(rs.getString(5));
						return motorist;
					}
				});
		return matches.size()>0 ? (Motorist) matches.get(0) : null;
	}
}

My application context file [named as springapp-servlet.xml] is :

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xmlns:jdbc="http://www.springframework.org/schema/jdbc"
	xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd
		http://www.springframework.org/schema/jdbc http://www.springframework.org/schema/jdbc/spring-jdbc-3.0.xsd">
	
	<bean id="propertyConfigurer" class="org.springframework.beans.factory.config.PreferencesPlaceholderConfigurer">
		<property name="location" value="classpath:database.properties" />
	</bean>
	
	<bean id="jdbcTemplate" class="org.springframework.jdbc.core.JdbcTemplate">
		<property name="dataSource" ref="dataSource" />
	</bean>
	
	<bean id="dataSource" class="org.springframework.jdbc.datasource.DriverManagerDataSource">
		<property name="driverClassName" value="${jdbc.driverClassName}" />
		<property name="url" value="${jdbc.url}" />
		<property name="username" value="${jdbc.username}" />
		<property name="password" value="${jdbc.password}" />
	</bean>
	
	<bean id="motoristService" class="test.spring.jdbc.doaimpl.MotoristServiceImpl" depends-on="dataSource">
		<property name="jdbcTemplate" ref="jdbcTemplate" />
	</bean>
</beans>

And my main class is :

package test.spring.jdbc.executor;

import org.springframework.context.ApplicationContext;
import org.springframework.context.support.ClassPathXmlApplicationContext;

import test.spring.jdbc.dao.MotoristService;
import test.spring.jdbc.domain.Motorist;

public class ExecuteMotorist {

	/**
	 * @param args
	 */
	public static void main(String[] args) {
		// TODO Auto-generated method stub
		ApplicationContext ctx = new ClassPathXmlApplicationContext(
				"./springapp-servlet.xml");
		MotoristService service = (MotoristService) ctx
				.getBean("motoristService");
		try {
			Motorist motorist = new Motorist(10, "[e-mail]", "gaja123",
					"gajanan", "Machewar");
			service.saveMotorist(motorist);
		} catch (Exception e) {
			// TODO: handle exception
			System.out.println("E");
		}
		System.out
				.println("One row of data inserted successfully....One row affected.");
		System.out.println("The row inserted now is ::::::::::::");
		System.out.println(service.getMotoristById(9).toString());
	}

}

When ever I execute this class i am getting the following error and i am not able to know the reason for the error.

Exception in thread "main" org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'motoristService' defined in class path resource [springapp-servlet.xml]: Invocation of init method failed; nested exception is java.lang.IllegalArgumentException: Property 'dataSource' is required
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1412)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:456)
	at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:291)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:288)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:190)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:574)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:895)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:425)
	at org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:139)
	at org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:83)
	at test.spring.jdbc.executor.ExecuteMotorist.main(ExecuteMotorist.java:23)
Caused by: java.lang.IllegalArgumentException: Property 'dataSource' is required
	at org.springframework.jdbc.support.JdbcAccessor.afterPropertiesSet(JdbcAccessor.java:134)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1469)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1409)
	... 12 more

Please tell me whats the reason for this error and how am i going to resolve it. Thank you

[Deepaks Deshpande]

I have solved the problem my self. In my DaiOmpl class I was trying to extend the JdbcTemplate class. It was quite silly of me to have done that.

Thank you.