• Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

non duplicates in a Set

 
Rob McBryde
Greenhorn
Posts: 16
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi All,

I am in the process of writing a small program where I have created a very simple class called Vertex that has a String as a field. I am now attempting to add a number of instances of my Vertex class into a HashSet. However, my resultant HashSet has duplicates in it.

I have added a equals method and compareTo method in my Vertex class to attempt to allow my HashSet to uniquely identify Vertexes but I am clearly missing something. Can anyone point me in the right direction. Do I need to override the HashCode in my Vertex class?








This results in a Set of [A, B, A, C] when I would like to have no duplicates, hence my choice in using a Set.

Thanks in advance
 
Matthew Brown
Bartender
Posts: 4568
9
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Rob McBryde wrote:Do I need to override the HashCode in my Vertex class?

Yes, that's it. You should always override hashCode() whenever you override equals(), as they should be consistent with each other (see the contract descriptions in the Javadocs for Object). HashSet relies on hashCode() working correctly (the "Hash" in the name is not a coincidence!).
 
Rob Spoor
Sheriff
Pie
Posts: 20611
63
Chrome Eclipse IDE Java Windows
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
And your equals method has a huge bug. If you pass null or an instance of an incompatible class the method should return false. Your implementation will throw a NullPointerException / ClassCastException.
 
Stephan van Hulst
Bartender
Pie
Posts: 6128
74
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Not only is it bugged, it uses a poor construct:
 
Rob McBryde
Greenhorn
Posts: 16
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thanks for the advice, I have re-written my equals method and overridden the hashCode() method within my Vector class. Have tested this and no duplicate Vectors are being added to my HashSet. Hurray!






I appreciate the comments, a little unsure about Stephan's comment about the poor construct of my initial equals method. Would you be able to further advise why it is poor and what I should be doing to improve it ?

Thanks
 
Paul Beckett
Ranch Hand
Posts: 96
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I think what Stephan is getting at is that you can replace:


with:

thus improving the readability of your code.
 
Rob McBryde
Greenhorn
Posts: 16
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thanks Paul,

Makes perfect sense to me now. I've updated my code and will I ensure I stick to the more readable and less verbose approach from now on.

 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic