Need help with small problems

[Don Seracino]

So I'm pretty new to Java and this is my first semester. Can anybody help me out and tell me what I'm getting wrong here in my "okUserName() method"? I keep trying to work on it but I'm definitely stumped. Also I have an alternate driver class with a main method & a file in the same folder, but everything is perfect there.

*mind the awful indentation I just copy and pasted from my ide.

      import java.util.Scanner;
   import java.io.*;

/**
 * WoWAccount.java
 * holds data for WoWDriver
 * @author Don Seracino
 * @version 3.0
 */

   public class WoWAccount
   {
      private String username;
      private String password;
      public String filename;
   
   /**
    * WoWAccount Constructor
    */
      public WoWAccount()
      {
         username = "DEFAULT";
         password = "DEFAULT";
         filename = "DEFAULT";
      }
   
   /**
    * WoWAccount Constructor
    * @param usrName
    * @param pwd
    */
      public WoWAccount(String usrName, String pwd)
      {
         username = usrName;
         password = pwd;
      }
   
   /**
    * Sets user name
    * @param usrName
    */
      
      public void setUsrName(String usrName)
      {
         username = usrName;
      }
   
   /**
    * Sets password
    * @param pwd
    */
      public void setPassword(String pwd)
      {
         password = pwd;
      }
   
   /**
    * Get user name
    * @return username
    */
      public String getUsrName()
      {
         return username;
      }
   
   /**
    * Get password
    * @return password
    */
      public String getPassword()
      {
         return password;
      }
   
   /** 
    * Writes Username & Password to a file
    * @param usrName
    * @param pwd
    */
      public static void writeFile(String fname,String usrName, String pwd)
      {  
         fname = "users.txt";
         File file = new File("users.txt");
         Scanner input = null;
      
         try
         {  
            input = new Scanner(fname);
         
            while (input.hasNext());
            {
               System.out.println("Your username of " + usrName);
               System.out.println("& password of " + pwd);
               System.out.println("has been written to the file");
            }
         }
            catch(FileNotFoundException e)
            {
               System.out.println("I'm sorry that file does not exist");
            }
         finally
         {
            if (input != null)
               input.close();
         } 
      }
   
   /**
    * Checks password
    * okPassword
    * @param pwd
    * @return boolean true \ false
    */
      public static boolean okPassword(String pwd, String filename)
      {
         int countU = 0,
            countL = 0,
            countD = 0;
         boolean passOk = true;
       
         if(pwd.length() >= 6 && pwd.length() <= 20)
         {  
            for(int i = 0; i < pwd.length(); i++)
            {
            
               if (Character.isUpperCase(pwd.charAt(i)))
               {
               
                  countU ++;
               }
               else if(Character.isLowerCase(pwd.charAt(i)))
               {
               
                  countL ++;        
               }
               else if(Character.isDigit(pwd.charAt(i)))
               {
               
                  countD ++;
               }
            }// end of for   
         
            if(countU > 0 && countL > 0 && countD > 0)
            {
               passOk = true;
            }
            else
            {
               passOk = false;
            }
         }// end of if statement
         else
         {
            return passOk = false;
         }// end of else statement
         return passOk; 
      }// end passwordOK
   
   /**
    * Checks user name in file
    * @param usrname
    * @param filename
    */
      public static boolean okUsername(String usrName, String filename)
      {
         boolean unique = true,
              rightLength = true;
         Scanner input = null;
      
         if (usrName.length() > 6 && usrName.length() < 12)
         {  
            try
            {        
               input = new Scanner(new File(filename));
            
               while(input.hasNext())     
               {
                  String curUsrName = input.next();
               
                  if(curUsrName == usrName)
                  {
                     return unique;
                  }
               
               }// end while
               unique = false;
            }
               catch(FileNotFoundException e)
               {
                  System.out.println("Sorry this file does not exist");
               }        
            finally
            {
               if(unique != false)
               {
                  input.close();
               }
            return rightLength;   
            }
         }// end if
         else
         {  
            System.out.println("Sorry User name must be Greater than"
                     + "6 characters\n & less than 12");
            rightLength = false;
         }  
      }
   }

[Rajasekar Krishnan]

Hi Don,

I don't know whether i understood completly your actual problem or not.

But when i take the code to my IDE, i found two compiler error.

1) writeFile(): no need of handling FileNotFoundException there, because no code throwing this checked exception.

2) okUsername(): should return boolean value. Method should have a default return type irrespective of the return statement which is there in condition scope.

Thanks,
Rajasekar.

[Greg Brannon]

Please, please, please post your code in code tags.

I believe the problem with your okUserName() method is that you have a return statement in an if clause (or in if clauses). When the compiler sees this, it assumes it is possible that the if clauses will never be executed so that a return may never occur, causing the error, method x() must return <something>. A way to correct this is with an else statement:

if ()
{
    return x;
}
else
{
    return y;
}

That way the compiler will see there will always be a value returned.