Can't find the error

[Agnit Chatterjee]

please tell me where is the error?

<%@ page language="java" %>
<%@ page import="java.lang.*" %>
<%@ page import="java.sql.*" %>
<%@ page import="java.io.*" %> 


<% 
	
try {
      Class.forName("oracle.jdbc.driver.OracleDriver");
  Connection conn3=DriverManager.getConnection("jdbc:oracle:thin:@Agnit-PC:1521:devdb","system","bababobby");
PreparedStatement ps3=conn3.prepareStatement
("select fdaccountno,customerid,amount,interest,to_char(account_start_date),duration,to_char(maturityday),
case
    when (sysdate-maturityday) > 0 then 'matured'
    when (sysdate-maturityday) = 0 then 'maturityday'
    when (sysdate-maturityday) < 0 then 'notmatured'
    end maturity
from fixed_deposit_account where customerid=? ");
ps3.setString(1,request.getParameter("id"));
ResultSet rs3=ps3.executeQuery();
%>
<TABLE cellpadding="15" border="1" style="background-color: #ffffcc;">
    <%
    while (rs3.next()) {
    %>
    <TR>
        <TD><%=rs3.getString(1)%></TD>
        <TD><%=rs3.getString(2)%></TD>
        <TD><%=rs3.getDouble(3)%></TD>
        <TD><%=rs3.getDouble(4)%></TD>
	   <TD><%=rs3.getString(5)%></TD>
        <TD><%=rs3.getDouble(6)%></TD>
	   <TD><%=rs3.getString(7)%></TD>
	   <TD><%=rs3.getString(8)%></TD>

    </TR>

	   <%   }    %>
    <%
    conn3.close();
} catch (Exception ex) {
    %>
    </font>
    <font size="+3" color="red"></b>
        <%
                out.println("Unable to connect to database.");
}
        %>
    </TABLE>
</font>
</body>
</html>

I get the following error:


An error occurred at line: 13 in the jsp file: /fdmonitorprops.jsp
String literal is not properly closed by a double-quote
10: Class.forName("oracle.jdbc.driver.OracleDriver");
11: Connection conn3=DriverManager.getConnection("jdbc:oracle:thin:@Agnit-PC:1521:devdb","system","bababobby");
12: PreparedStatement ps3=conn3.prepareStatement
13: ("select fdaccountno,customerid,amount,interest,to_char(account_start_date),duration,to_char(maturityday),
14: case
15: when (sysdate-maturityday) > 0 then 'matured'
16: when (sysdate-maturityday) = 0 then 'maturityday'


Stacktrace:
org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:95)
org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:330)
org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:367)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:345)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:332)
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:594)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:342)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:391)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
javax.servlet.http.HttpServlet.service(HttpServlet.java:722)

[Brett Maclean]

Hi Agnit,

You just need to concatenate the prepared statement string properly. The way I'd do it is to create the string first, e.g.

		
String stmt = "select fdaccountno,customerid,amount,interest,to_char(account_start_date),duration,to_char(maturityday),"+  
		"case "+  
	    	"when (maturityday) > 0 then 'matured'"+  
	    	"when (maturityday) = 0 then 'maturityday'"+  
	    	"when (maturityday) < 0 then 'notmatured'"+  
	    "end maturity "+
	    "from fixed_deposit_account where customerid=?) ";

and then plonk it in to the

 prepareStatement

method of your connection.

HTH

[Ulf Dittmer]

The obnoxious guy in me wants to point out that the error is to use Java code in JSPs.

[Brett Maclean]

You should always free your inner obnoxious guy :-). But yes good point.

[Bear Bibeault]

I agree: step 1 of fixing any such error is to stop writing JSPs as if it were 2001 and to refactor the Java code into Java classes where it belongs. It's 2011. Time to progress...