Spring/Hibernate - No Hibernate Session bound to thread, and configuration does not allow creation..

[Ben Thurley]

Dear ranchers,

I have started a project in my spare time to update my Java skills but I've reached a bit of a road block. I've been really impressed with spring and hibernate but the transactions are proving a bit tricky. For information I am using the annotation based declarative transactions. I keep getting the following exception when I make an HTTP request that tries to use the hibernate session factory.

org.hibernate.HibernateException: No Hibernate Session bound to thread, and configuration does not allow creation of non-transactional one here
	org.springframework.orm.hibernate3.SpringSessionContext.currentSession(SpringSessionContext.java:63)
	org.hibernate.impl.SessionFactoryImpl.getCurrentSession(SessionFactoryImpl.java:687)

I must have spent 8-10 hours so far trying to fix this one and I'm really at my wits end. If you google this exception then most of the solutions are either missing @Transactional or missing <tx:annotation-driven /> from the config. I have both of these already so I don't think this is my problem. Other bits of advice just say to read the manual, I have done this and as far as I can see I am doing everything required.

Here are the relevant bits of code.

The spring context XML looks like this:

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       xmlns:context="http://www.springframework.org/schema/context"
       xmlns:mvc="http://www.springframework.org/schema/mvc"
       xsi:schemaLocation="
		http://www.springframework.org/schema/beans
		http://www.springframework.org/schema/beans/spring-beans-3.0.xsd
		http://www.springframework.org/schema/context
		http://www.springframework.org/schema/context/spring-context-3.0.xsd
		http://www.springframework.org/schema/mvc 
		http://www.springframework.org/schema/mvc/spring-mvc-3.0.xsd">

  <!-- Activates various annotations to be detected in bean classes -->
  <context:annotation-config />

  <context:component-scan base-package="mypackage" />
  <mvc:annotation-driven />

  <bean id="viewResolver" class="org.springframework.web.servlet.view.InternalResourceViewResolver"> 
	<property name="prefix">
		<value>/WEB-INF/jsp/</value>
	</property>
	<property name="suffix">
		<value>.jsp</value>
	</property>
  </bean>
  
</beans>

This is the XML config for the data layer
<?xml version="1.0" encoding="UTF-8"?> <beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:tx="http://www.springframework.org/schema/tx" xsi:schemaLocation=" http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.0.xsd http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx-3.0.xsd"> <tx:annotation-driven /> <!-- Configure the MYSQL connection parms --> <bean id="dataSource" class="org.apache.commons.dbcp.BasicDataSource"> <property name="driverClassName"> <value>com.mysql.jdbc.Driver</value> </property> <property name="url"> <value>jdbc:mysql://localhost:3306/*******</value> </property> <property name="username"> <value>***</value> </property> <property name="password"> <value>***</value> </property> </bean> <bean id="sessionFactory" class="org.springframework.orm.hibernate3.annotation.AnnotationSessionFactoryBean"> <property name="dataSource" ref="dataSource" /> <property name="annotatedClasses"> <list> <value>mypackage.Customer</value> </list> </property> <property name="hibernateProperties"> <props> <prop key="hibernate.dialect">org.hibernate.dialect.MySQLDialect</prop> <prop key="show_sql">false</prop> </props> </property> </bean> <bean id="transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager"> <property name="sessionFactory" ref="sessionFactory" /> </bean> </beans>

Here is the service implementation class. The interface is just a straight interface with no annotations.

@Service("customerService")
@Transactional(propagation=Propagation.SUPPORTS, readOnly=true)
public class CustomerServiceImpl implements CustomerService 
{
	
	@Autowired
	private HibernateCustomerDao customerDao;

	@Override
	public List<Customer> getCustomers() 
	{
		return customerDao.getCustomers();
	}

}

Here is my DAO implementation. Again the interface is simple with no annotations.

@Repository("customerDao")
public class HibernateCustomerDao implements CustomerDao
{

	@Autowired
	private SessionFactory sessionFactory;

	@SuppressWarnings("unchecked")
	public List<Customer> getCustomers()
	{
		Query q = 
			sessionFactory.getCurrentSession().createQuery(
					"from Customer customer");
		q.setFirstResult(0);
		q.setMaxResults(10);
		List<Customer> customers = q.list();
		return customers;
	}

}

Finally here is my simple entity.

@Entity
@Table(name = "customer")
public class Customer 
{
	@Id @GeneratedValue
	@Column(name = "id")
	private Integer id;
	
	@Column(name = "name")
	private String name;
	
	/* The rest is just simple getters and setters */
}

I've had a look in debug and the sessionFactory is there but its transactionManager property is null. I must be missing something but I've checked countless tutorials etc and can't for the life of me find it. Hopefully someone can help me. Looking forward to your suggestions!

Thanks in advance
Ben

[Mark Spritzler]

I'd have to guess it is your Propagation setting of SUPPORTS. SUPPORTS never creates a new transaction, so I am assuming anytime anyone calls the service method it is calling without a Transaction and Hibernate requires a Transaction always. You can set the Repository to @Transactional and set its propagation to REQUIRED. Or you can change your service propagation.

Mark

[Ben Thurley]

Hi,

I tried this suggestion but it didn't make any difference. I also had this suggestion plus a couple others on the spring source site.
springsource topic

To save clicking the link here's the solution.

I also just noticed that you have a component-scan in your other xml file (probably your x-servlet.xml). You should also know that the tx:annotation-driven ONLY works on beans in the SAME applicationcontext. So if your tx:annotation-driven is in your root context (ContextLoaderListener) and you are scanning your services in your DispatcherServlet there is no transactional stuff going to happen.

Based on this advice I moved the tx:annotation-driven to the root context. This did the trick!

Thanks for taking the time to help.
Ben

[Mark Spritzler]

Ben Thurley wrote:Hi,

I tried this suggestion but it didn't make any difference. I also had this suggestion plus a couple others on the spring source site.
springsource topic

To save clicking the link here's the solution.

I also just noticed that you have a component-scan in your other xml file (probably your x-servlet.xml). You should also know that the tx:annotation-driven ONLY works on beans in the SAME applicationcontext. So if your tx:annotation-driven is in your root context (ContextLoaderListener) and you are scanning your services in your DispatcherServlet there is no transactional stuff going to happen.

Based on this advice I moved the tx:annotation-driven to the root context. This did the trick!

Thanks for taking the time to help.
Ben

It still doesn't sound completely correct. Here's why.

In a web environment you will have two ApplicationContext, one being the parent one the child. The parent should contain your middle tier objects, tx manager and sessionFactory. Is should also contain the tx:annotation-driven. This parent is created via the ContextLoaderListener.

The child ApplicationContext is the one loaded by the DispatcherServlet and should only load the Web tier beans. The Controllers, ViewResolvers etc. It should be scanning for Service classes, that goes in the parent ApplicationContext.

So now it look like you are loading your Services in the web layer child ApplicationContext and moved your tx:annotation-driven to your xml for the child ApplicationContext, and that isn't where you want it.

Mark

Ah, in the ContextLoaderListener it creates an ApplicationContext that should contain your beans for your middle tier and contain the tx:annotation-driven. Whereas the DispatcherServlet with its init-param will create a Separate child Application context for beans for your web layer. By doing that the parent Application(middle tier beans) can be injected into you web layer beans, but your web