How to Make Sure Class Finishes in Spite of Exception

[Steve Dyke]

In the following class how can I make sure the class completes its process eventhough on of the addresses might be bogus?

public void setSendEmailMessageJMail(String[] toRecp, String fromSender, String subject, String body, String host){
		
		//String to [] = {"[e-mail]","[e-mail]"};
		String to [] = toRecp;
		String from = fromSender;
		//String host = "SGAI-DOM1.ZODIAC.LAN";
	
		Properties props = new Properties();
		props.put("mail.smtp.host", host);
		Session session = Session.getInstance(props);
	
		try{
			Message msg = new MimeMessage(session); 
			msg.setFrom(new InternetAddress(from));
			InternetAddress[] address = new InternetAddress[to.length];
			for (int i = 0; i < to.length; i++) {
				
				address[i] = new InternetAddress(to[i]);
			}	
			
			msg.setRecipients(Message.RecipientType.TO, address);
			
			msg.setSubject(subject);
			msg.setSentDate(new Date());

			// Set message content
			msg.setText(body);

			//Send the message
			Transport.send(msg);
			
		}
		catch(SendFailedException se){
			System.out.println(se);
		}
		catch(AddressException ae){
			System.out.println(ae);
		}
		catch (MessagingException mex){
			System.out.println(mex);
			//mex.printStackTrace();
		}
	}

[Rob Spoor]

1) use a List<InternetAddress>
2) wrap the creation of the separate addresses in a try-catch block inside the loop; when successful add to the List.
3) when done convert the List into an array:

InternetAddress[] address = list.toArray(new InternetAddress[list.size()]);

[Paul Clapham]

I have a strong suspicion that your concern is not merely that the processing of that method terminates normally. I suspect your real question is that even if some of the e-mail addresses are bogus, you want the message to be sent to the remaining good e-mail addresses regardless of that.

Assuming that's the actual background for the post, let me refer you to this part of the JavaMail API documentation. Scroll down and read the description for the "mail.smtp.sendpartial" property. Does that help?

[Steve Dyke]

Paul Clapham wrote:I have a strong suspicion that your concern is not merely that the processing of that method terminates normally. I suspect your real question is that even if some of the e-mail addresses are bogus, you want the message to be sent to the remaining good e-mail addresses regardless of that.

Assuming that's the actual background for the post, let me refer you to this part of the JavaMail API documentation. Scroll down and read the description for the "mail.smtp.sendpartial" property. Does that help?

Thanks,

I have added this to my email code.

props.put("mail.smtp.sendpartial", new Boolean(true));

[Rob Spoor]

Never write "new Boolean(true)", "new Boolean(false)" or "new Boolean(b)" where "b" is any boolean variable. Use Boolean.TRUE, Boolean.FALSE or Boolean.valueOf(b) instead. That will use one of the two pre-existing objects Boolean.TRUE and Boolean.FALSE.

In fact, never use any of the Boolean constructors; they both have a matching valueOf method that uses the cached values.

[Paul Clapham]

And in this case you don't use anything to do with Boolean. If you look again at the documentation which I linked to you'll see this:

The SMTP protocol provider supports the following properties, which may be set in the JavaMail Session object. The properties are always set as strings; the Type column describes how the string is interpreted.

You might want to read the rest of that documentation page while you're at it, too. You never know what you might find in documentation.

[Steve Dyke]

Paul Clapham wrote:And in this case you don't use anything to do with Boolean. If you look again at the documentation which I linked to you'll see this:

The SMTP protocol provider supports the following properties, which may be set in the JavaMail Session object. The properties are always set as strings; the Type column describes how the string is interpreted.

You might want to read the rest of that documentation page while you're at it, too. You never know what you might find in documentation.

I beleive I have the sendpartial property set correctly now but still don't have the results I need. When the address array is being created in the loop I need it to skip bad email addresses.

public void setSendEmailMessageJMail(String[] toRecp, String fromSender, String subject, String body, String host){
		
		//String to [] = {"[e-mail]","[e-mail]"};
		String to [] = toRecp;
		String from = fromSender;
		//String host = "SGAI-DOM1.ZODIAC.LAN";
	
		Properties props = new Properties();
		props.put("mail.smtp.host", host);
		props.put("mail.smtp.sendpartial", "True");
		Session session = Session.getInstance(props);
	
		try{
			Message msg = new MimeMessage(session); 
			msg.setFrom(new InternetAddress(from));
			InternetAddress[] address = new InternetAddress[to.length];
			for (int i = 0; i < to.length; i++) {
				
				try{
					address[i] = new InternetAddress(to[i]);
				}
				catch(AddressException ae){
					System.out.println("Error in Address Loop: "+to[i]+" :"+ae);
					
				}
			}	
			
			msg.setRecipients(Message.RecipientType.TO, address);
			
			msg.setSubject(subject);
			msg.setSentDate(new Date());

			// Set message content
			msg.setText(body);

			//Send the message
			Transport.send(msg);
			
		}
		catch(SendFailedException se){
			System.out.println(se);
		}
		catch (MessagingException mex){
			System.out.println(mex);
			//mex.printStackTrace();
		}
	}

[Paul Clapham]

Steve Dyke wrote:I beleive I have the sendpartial property set correctly now but still don't have the results I need.

I'm not so sure you have it set correctly. Why do you set it to "True" instead of "true"?

When the address array is being created in the loop I need it to skip bad email addresses.

How about if you explain why? It would also help if you explained the technical terms "bad" and "bogus" as applied to e-mail addresses.

[Steve Dyke]

Paul Clapham wrote:

Steve Dyke wrote:I beleive I have the sendpartial property set correctly now but still don't have the results I need.

I'm not so sure you have it set correctly. Why do you set it to "True" instead of "true"?

When the address array is being created in the loop I need it to skip bad email addresses.

How about if you explain why? It would also help if you explained the technical terms "bad" and "bogus" as applied to e-mail addresses.

Okay, I set property to 'true'. I don't really have a reason why I typed in 'True'.

When a user logs onto my app there is a prference section where the user can type in an e-mail address. This is not a required field(yet) nor do I have code set in place for validation. In spite of this there are functions in the app that refer to the file where e-mail addresses are stored and build arrays for auto sent messages. I need my e-mail code to skip records where the e-mail address is empty and where the address was not keyed in correctly, example spaces or invalid characters.

[Paul Clapham]

Okay. Then I don't see why you shouldn't write code which skips those things. Something like (pseudocode)

for each address in array
  if it's not blank (or doesn't pass basic validation)
    msg.addRecipient(Message.RecipientType.TO, address)