Forums Register Login

Issues with if else statement

+Pie Number of slices to send: Send
Hi!

I am very new to java programming and am trying to get an if else statement to work in relation to calculating taxation amounts.

Basically I need it to say: If salary is less than XXXX then tax = 0, otherwise if salary is greater than or equal to XXXXX then tax = (calculation), otherwise if salary is greater than or equal to XXXXX then tax = (calculation) etc

But at the moment it is only calculating on the first level of the calculation.

I really need help! My issue is between lines 38 & 47.


I hope someone can help!

Thanks in advance
+Pie Number of slices to send: Send
Hi,

Welcome to JavaRanch!

Well, one problem is that the tests are going to be executed in order, but they all overlap. For example, if projectedAnnual is 100,000, the program is first going to check if it's less than or equal to 6000, which it's not, but then it's going to check if it's greater than or equal to 6000, which it is, so that piece of code will be executed, and that's it -- no more "else" clauses will be considered, since one was already satisfied. You need to either re-order them, or turn the tests around to be "less than" rather than "greater than", so the smaller tests won't apply for the bigger numbers.
+Pie Number of slices to send: Send
Linda Hi!

First thing that caught my eye was:

What if 'projectedAnnual' equaled exactly 6000? Which 'if' stmt do you want to be followed? (<= 6000 or >= 6000)?

Since 'projectedAnnual' tops out at 150000, perhaps that should be the first amount tested, no?

With an ascending set of values, your code will never get to anything past the 'greater-than' 6000... cuz it's all greater than 6000, i.e., 25000 > 6000, 75000 > 6000, 150000 > 6000.

Flip the sequence & you'll be a happy camper!
+Pie Number of slices to send: Send
You could accomplish what you're trying to do without them, but you could use multiple tests in your if statements. An advantage is that readability is improved, a disadvantage is that it's adding complexity, perhaps unnecessarily.

e.g.:

+Pie Number of slices to send: Send
You guys are legends!

I did what you said and flipped the statements around and it now calculated properly! YAY! YAY! YAY! I was up till 4am this morning trying to fix the issue!

I am forever in everyones debt!

For future reference the code now looks like this....



Thank you again!
+Pie Number of slices to send: Send
Linda, Hello again!

Hope you check back, because I have one additional comment.

You should remove the statement at line 50: if (projectedAnnual <= 6000)
and simply let the tax bracketing fall through to: yearTax = 0.00 ... the default tax amount

Besides that, what if the taxable amount is exactly 6000? It is referenced with equal signs in both lines 47 and 50.

Drop line 50 & you're on your way.
+Pie Number of slices to send: Send
Thanks I will give it a go.

Cheers
+Pie Number of slices to send: Send
Is it safe to assume that hoursWorked number is at least 38?
+Pie Number of slices to send: Send
Maybe that implies that you're also penalized at time-and-a-half if you don't wok a minimum of 38 hours

Good catch, Ilya!
After some pecan pie, you might want to cleanse your palatte with this tiny ad:
a bit of art, as a gift, that will fit in a stocking
https://gardener-gift.com


reply
reply
This thread has been viewed 2362 times.
Similar Threads
Output formatting
unreachable statement
Logic Errors
Not returning a value
payroll
More...

All times above are in ranch (not your local) time.
The current ranch time is
Mar 28, 2024 14:32:44.