Forum:

Problem in inserting data into oracle db from jsp

Ranch Hand

Posts: 47

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi

I am trying to insert data into Oracle database, when i click add button it does'nt perform action...This is my code...Please help me

<%@ page import="java.sql.*" %>
<%@ page import="java.io.*" %>

<HTML>
    <HEAD>
        <TITLE>Creation of Master List</TITLE>
    </HEAD>

<tr>
    <h1 align="center"> Creation of Master List</h1>
        <center>
       <input type="image" name="Inventory" value="Inventory" src="i.gif">
       <input type="image" name="n" value="n" src="n.gif">
       <input type="image" name="v" value="v" src="v.gif">
       <input type="image" name="e" value="e" src="e.gif">
       <input type="image" name="n" value="n" src="n.gif">
       <input type="image" name="t" value="t" src="t.gif">
       <input type="image" name="o" value="o" src="o.gif">
       <input type="image" name="r" value="r" src="r.gif">
       <input type="image" name="y" value="y" src="y.gif">
   </center>
</tr>
   <center>
    <input type="image" name="Back" value="Back" src="Btn_back.png" onClick="javascript:history.back()">
    <input type="image" name="Home" value="Home" src="Home.png" onClick="javascript:window.location='Home.jsp';">
    <input type="image" name="Master List" value="Master List" src="masterlist.png" onClick="javascript:window.location='masterlist.jsp';" >
    <input type="image" name="Material List" value="Material List" src="materiallist.png" onClick="javascript:window.location='materiallist.jsp';">
    <input type="image" name="Material Order" value="Material Order" src="materialorder.png" onClick="javascript:window.location='materialorder.jsp';">
    <input type="image" name="Show all" value="Show all" src="showall.png" onClick="javascript:window.location='showall.jsp';">
    <input type="image" name="Logout" value="Logout" src="logout.png">
</center>

<br><br>
    <form action="cmasterlist.jsp" method="post">
    <h2 align="center">Insert New Inventory Details</h2>
    <br><br>
    <table align="center" width="400px" style="border:1px solid #ffffff;background-color: white">
                   <TR>
                    <TH width="50%">Part No</TH>
                    <TD width="50%"><INPUT TYPE="text" NAME="Part No"></TD>
                </TR>
                <TR>
                    <TH width="50%">Material Number</TH>
                    <TD width="50%"><INPUT TYPE="text" NAME="Material Number"></TD>
                </TR>
                <TR>
                    <TH width="50%">Material Description</TH>
                    <TD width="50%"><INPUT TYPE="text" NAME="Material Description"></TD>

</TR>

</table>
        <center><TR>
            <TD><INPUT TYPE="Button" NAME="Add" VALUE="Add" ></TD>
            </TR></center>
    <%
             String partno = request.getParameter("partno");
             String material_number = request.getParameter("material_number");
             String material_desc = request.getParameter("material_desc");

String connectionURL = "jdbc:oracle:thin:@10.44.6.75:1529:nrsprd";
             String driver = "oracle.jdbc.driver.OracleDriver";
                    String user = "seemin";
                    String pass = "seemin123";
                        Connection connection = null;
                        PreparedStatement pstatement = null;
                       Class.forName(driver).newInstance();
                        int updateQuery = 0;
                        if (material_number != null && material_desc != null && partno != null ) {
                            if (material_number != "" && material_desc != "" && partno != "" ) {
                                connection = DriverManager.getConnection(connectionURL);
                                String queryString = "INSERT INTO batchfile(partno, material_number, material_desc) VALUES(?, ?, ?)";
                                    pstatement = connection.prepareStatement(queryString);
                                    pstatement.setString(1, partno);
                                    pstatement.setString(2,material_number );
                                pstatement.setString(3, material_desc);

pstatement.executeUpdate();
    %>
    <br>
            <TABLE align="center" style="background-color: white;"
                   WIDTH="30%" border="1">
                <tr><th>Data is inserted successfully
                        in database.</th></tr>
            </TABLE>
            <%
                                pstatement.close();
                                connection.close();
                            }
                        }
            %>
</form>
</BODY>
</HTML>

I dont knw where is the problem, but when i enter the values and click add it doen't perform action=cmasterlist.jsp command. Please help me.

Thanks in advance
Lissy.

David O'Meara

Rancher

Posts: 13459

I like...

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

This button doesn't do anything. did you mean to make the type 'submit'?

lisy jessica

Ranch Hand

Posts: 47

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Yes, add button means submit.

David O'Meara

Rancher

Posts: 13459

I like...

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

then you need to change the type to 'submit' instead of type="button"

Stefan Evans

Bartender

Posts: 1845

posted 13 years ago

1
Number of slices to send:

Optional 'thank-you' note:

Send

If you've read any posts in this forum you know that writing scriptlet code in a JSP is not the way to go.
Java code belongs in a java class.

Potential problems spotted in your code:

> if (material_number != "" && material_desc != "" && partno != "" ) {
This line of code doesn't do what you think it does.
When comparing string values, you should use the .equals method.

Bear Bibeault

Sheriff

Posts: 67752

173

I like...