Cannot download the whole text file

[Andrew Watson]

Hello

I am writing servlet which is to download files to my desktop app and then save it on my hdd. I have tested the code and it works fine for binary files like video ot images or even doc files but it doesn't work with txt. It looses text.

Here is the problem code:

final int BUFFER_SIZE = 4096;

FileInputStream in = new FileInputStream(file);
        OutputStream out = response.getOutputStream();

     byte buffer[] = new byte[BUFFER_SIZE];
              for (int nread = 0; (nread = in.read(buffer)) != -1; ) {

                out.write(buffer, 0, nread);

              }

            }
            out.flush();
            out.close();
            in.close();

And here is the desktop app code (I use HttpClient 4):

 response = httpclient.execute(httppost);
            resEntity = response.getEntity();



            InputStream in = resEntity.getContent();
in = new CipherInputStream(in, decipher);//AES decryption
FileOutputStream out= new FileOutputStream(path);


    byte[] buffer = new byte[4096];//field

    //method ...
        int numRead = 0;
                              while ( (count = in.read(buffer )) !=-1) {
                                out.write(buffer , 0, count);


                              }
                              out.flush();
                              out.close();

For example I have just downloaded a txt file so its original length is 1722bytes but the downloaded version contains 1696bytes ... So where I could lost its final 26 bytes ? I suspect the final chunk occures the problem but I don't know how to fix it. Please help


Any useful comment is appreciated.

[Bear Bibeault]

Have you compared the files? Could the difference be perhaps in how lines are terminated?

[Andrew Watson]

Bear Bibeault wrote:Have you compared the files? Could the difference be perhaps in how lines are terminated?

Yes, I opened it and watched its content... I don't know why but I get lost the final bytes Please help me to understand why

[Bear Bibeault]

So you are actually missing characters at the end of the file? Not just comparing lengths?

[Andrew Watson]

here is the original text:

I don't know when it happened.
I don't know when she came,
But, she's the one I always knew,
Grandma was her name.

She taught me how to tie my shoes.
She taught me how to talk.
And, though I can't remember,
I think she taught me how to walk.

When all the other kids in school
Would talk about Mom and Dad,
I wondered where my parents were,
That made me kinda’ sad.

here is the downloaded text:

I don't know when it happened.
I don't know when she came,
But, she's the one I always knew,
Grandma was her name.

She taught me how to tie my shoes.
She taught me how to talk.
And, though I can't remember,
I think she taught me how to walk.

When all the other kids in school
Would talk about Mom and Dad,
I wondered where my parents were,
That made

Why the code doesn't download the whole txt files ? As you can see the downloaded file missing text How to fix it?

[David O'Meara]

BeForthrightWhenCrossPostingToOtherSites
http://stackoverflow.com/questions/5505418/downloaded-txt-file-become-shrinked

[Bear Bibeault]

Your code indentation is all wonky, so I won't be reading the code, but check your loops to make sure that you're not dropping the last chunk on either writing or reading.

[Andrew Watson]

David O'Meara wrote:BeForthrightWhenCrossPostingToOtherSites
http://stackoverflow.com/questions/5505418/downloaded-txt-file-become-shrinked

It is not . They don't answer for long time so maybe they simply don't know how to help me with the question. So I hope you can

[Bear Bibeault]

Have you debugged your loop as I suggested?

[Andrew Watson]

Bear Bibeault wrote:Have you debugged your loop as I suggested?

Yes

I want to show you the decipher code:

the decipher defined the same as for encryping...:

KeyGenerator kgen = KeyGenerator.getInstance("AES");
          kgen.init(128);
          key = kgen.generateKey();

    byte[] ivar = new byte[]
                      {
                          0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09,0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f
                  };
AlgorithmParameterSpec params = new IvParameterSpec(ivar );
dcipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
dcipher.init(Cipher.DECRYPT_MODE, key, params );

How you think maybe there is a problem? I heard that to decrypt there should be some differ alg parameters but I am not sure...

[Kasper Pedersen]

Andrew Watson wrote:here is the original text:

I don't know when it happened.
I don't know when she came,
But, she's the one I always knew,
Grandma was her name.

She taught me how to tie my shoes.
She taught me how to talk.
And, though I can't remember,
I think she taught me how to walk.

When all the other kids in school
Would talk about Mom and Dad,
I wondered where my parents were,
That made me kinda’ sad.

here is the downloaded text:

I don't know when it happened.
I don't know when she came,
But, she's the one I always knew,
Grandma was her name.

She taught me how to tie my shoes.
She taught me how to talk.
And, though I can't remember,
I think she taught me how to walk.

When all the other kids in school
Would talk about Mom and Dad,
I wondered where my parents were,
That made

Why the code doesn't download the whole txt files ? As you can see the downloaded file missing text How to fix it?

I just noticed that you are missing the same number of characters as there are newlines in the text (suggesting some \n\r issue). Try doing the same with a text without any linebreaks ... just a thought.