Swing Calender, ComboBox and timer questions

[sean beacham]

im trying to code a program at the minute which when you set specific times to switch something on in this case a boiler (theretically)

So i need to have a switch on time and switch off time therefore i have used JComboBoxes then used a string array to hold the value for hours and minutes and then converted them into an interger for to use for if statements.

Now im quite stumped on what to do next i know i have to compare the times together with a realtime clock therefore i guess using the swing calender function???

So far i have come up with this code but even the simple if statement fails me it always reads ON even trying different cominations of >= <= == etc.... im a bit stuck how to compare the times. I would also like it to keep checking to see whether the boiler should still be active therefore i guess putting the whole thing into an infinate for loop?

Any tips or ideas would be greatful i have embedded my code for you to all look at also i am not the best programmer i will admit that and i have limited knowledge but any help would be helpful.

	public void boilertimer() {
		frame4 = new JFrame();
		frame4.setTitle("my Thermostat Boiler Timer");
		frame4.setSize(300, 200);

		//sets up panel
		panel4 = new JPanel();
		panel4.setBackground(Color.WHITE);
		panel4.setLayout(null);
		frame4.getContentPane().add(panel4);
		frame4.setVisible(true);
		panel4.setVisible(true);
		
		String[] hourStrings = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23"};
		String[] minuteStrings = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23","24", "25", "26" , "27", "28", "29", "30", "40", "41", "42", "43", "44", "45", "46" , "47", "48", "49", "50", "51", "52", "53","54", "55", "56" , "57", "58", "59"};

		String[] hourStringsoff = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23"};
		String[] minuteStringsoff = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23","24", "25", "26" , "27", "28", "29", "30", "40", "41", "42", "43", "44", "45", "46" , "47", "48", "49", "50", "51", "52", "53","54", "55", "56" , "57", "58", "59"};

		BoilerOn = new JLabel("Boiler Switch On");
		BoilerOn.setBounds(10,10,100,50);
		panel4.add(BoilerOn);
		
		BoilerOff = new JLabel("Boiler Switch Off");
		BoilerOff.setBounds(140,10,125,50);
		panel4.add(BoilerOff);
		
		final JComboBox hour = new JComboBox(hourStrings);
		hour.setBounds(10,50,45,25);
		panel4.add(hour);
		 hour.addActionListener(new ActionListener() {
				public void actionPerformed(ActionEvent e) {
					String hor = (String)hour.getSelectedItem();
				       int hourOn = Integer.parseInt(hor);
				       System.out.print(hourOn);
				}
				});

		final JComboBox minute = new JComboBox(minuteStrings);
		minute.setBounds(60,50,45,25);
		panel4.add(minute);
		minute.addActionListener(new ActionListener() {
				public void actionPerformed(ActionEvent e) {
					String min = (String)minute.getSelectedItem();
				       int minOn = Integer.parseInt(min);
				       System.out.print(minOn);
				}
				});

		final JComboBox houroff = new JComboBox(hourStringsoff);
		houroff.setBounds(140,50,45,25);
		panel4.add(houroff);
		 houroff.addActionListener(new ActionListener() {
				public void actionPerformed(ActionEvent e) {
					String hor = (String)houroff.getSelectedItem();
				       int hourOff = Integer.parseInt(hor);
				       System.out.print(hourOff);
				}
				});

		final JComboBox minuteoff = new JComboBox(minuteStringsoff);
		minuteoff.setBounds(190,50,45,25);
		panel4.add(minuteoff);
		minuteoff.addActionListener(new ActionListener() {
				public void actionPerformed(ActionEvent e) {
					String min = (String)minuteoff.getSelectedItem();
				       int minOff = Integer.parseInt(min);
				       System.out.print(minOff);
				}
				});
		
		timerset = new JButton("Confirm");
		timerset.setBounds(155,115,80,40);
		panel4.add(timerset);
		timerset.addActionListener(new ActionListener()
		{public void actionPerformed(ActionEvent event) 
		{
			 if (hourOn == hourOff){
				 	        System.out.println("Boiler Is ON");
				 	         
				 	    }
				 	    else{
				 	        System.out.println("Boiler Is OFF");
				 	         
				     }
			
		}});
				
		
	}

[Abhilash Etikala]

Use GregorianCalendar() to get the current time and compare with the selected time...

Here is the sample code. to get time..

Calendar calendar = new GregorianCalendar();
    int hour = calendar.get(Calendar.HOUR);
    int minute = calendar.get(Calendar.MINUTE);

Since,String arrays contains the integer values you can use the below code to initialize the combo box..

Integer n[] = new Integer[30];
for(int i=0;i<30;i++)
n[i]=i;
jComboBox1.setModel(new javax.swing.DefaultComboBoxModel(n))

hope this helps u...

[sean beacham]

Abhilash Etikala wrote:Use GregorianCalendar() to get the current time and compare with the selected time...

Here is the sample code. to get time..

Calendar calendar = new GregorianCalendar();
    int hour = calendar.get(Calendar.HOUR);
    int minute = calendar.get(Calendar.MINUTE);

Since,String arrays contains the integer values you can use the below code to initialize the combo box..

Integer n[] = new Integer[30];
for(int i=0;i<30;i++)
n[i]=i;
jComboBox1.setModel(new javax.swing.DefaultComboBoxModel(n))

hope this helps u...

i dont know what this code does!

i know the first 3 lines get the current hour and minute thats fine.

ive started to write some code so far so good.... a few more tips and i think i should get thre by tomorrow

	public void boilertimer() {
		frame4 = new JFrame();
		frame4.setTitle("my Thermostat Boiler Timer");
		frame4.setSize(300, 200);

		//sets up panel
		panel4 = new JPanel();
		panel4.setBackground(Color.WHITE);
		panel4.setLayout(null);
		frame4.getContentPane().add(panel4);
		frame4.setVisible(true);
		panel4.setVisible(true);

		Calendar cal = new GregorianCalendar();

		//Get the components of the time
		final int timerhour24 = cal.get(Calendar.HOUR_OF_DAY);     // 0..23
		final int timermin = cal.get(Calendar.MINUTE);             // 0..59

		System.out.println(timerhour24 + ":" + timermin);

		String[] hourStrings = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23"};
		String[] minuteStrings = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23","24", "25", "26" , "27", "28", "29", "30", "40", "41", "42", "43", "44", "45", "46" , "47", "48", "49", "50", "51", "52", "53","54", "55", "56" , "57", "58", "59"};

		String[] hourStringsoff = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23"};
		String[] minuteStringsoff = { "00", "01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12", "13", "14", "15", "16" , "17", "18", "19", "20", "21", "22", "23","24", "25", "26" , "27", "28", "29", "30", "40", "41", "42", "43", "44", "45", "46" , "47", "48", "49", "50", "51", "52", "53","54", "55", "56" , "57", "58", "59"};

		BoilerOn = new JLabel("Boiler Switch On");
		BoilerOn.setBounds(10,10,100,50);
		panel4.add(BoilerOn);

		BoilerOff = new JLabel("Boiler Switch Off");
		BoilerOff.setBounds(140,10,125,50);
		panel4.add(BoilerOff);

		final JComboBox hour = new JComboBox(hourStrings);
		hour.setBounds(10,50,45,25);
		panel4.add(hour);
		hour.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				String hor = (String)hour.getSelectedItem();
				int hourOn = Integer.parseInt(hor);
				System.out.print(hourOn);
			}
		});

		final JComboBox minute = new JComboBox(minuteStrings);
		minute.setBounds(60,50,45,25);
		panel4.add(minute);
		minute.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				String min = (String)minute.getSelectedItem();
				int minOn = Integer.parseInt(min);
				System.out.print(minOn);
			}
		});

		final JComboBox houroff = new JComboBox(hourStringsoff);
		houroff.setBounds(140,50,45,25);
		panel4.add(houroff);
		houroff.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				String hor = (String)houroff.getSelectedItem();
				int hourOff = Integer.parseInt(hor);
				System.out.print(hourOff);
			}
		});

		final JComboBox minuteoff = new JComboBox(minuteStringsoff);
		minuteoff.setBounds(190,50,45,25);
		panel4.add(minuteoff);
		minuteoff.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				String min = (String)minuteoff.getSelectedItem();
				int minOff = Integer.parseInt(min);
				System.out.print(minOff);
			}
		});

		timerset = new JButton("Confirm");
		timerset.setBounds(155,115,80,40);
		panel4.add(timerset);
		timerset.addActionListener(new ActionListener()
		{public void actionPerformed(ActionEvent event) 
		{
			if (hourOn && minOn == timerhour24 && timermin){

				System.out.print("Boiler is On");
			}

		}});
}

code doesnt work its come up with this 
The operator && is undefined for the argument type(s) int, boolean

[Darryl Burke]

Use parentheses for logical grouping of conditional expressions.