Forum:

JDBC and Relational Databases

Problem in updating the fields to database

lisy jessica

Ranch Hand

Posts: 47

posted 6 years ago

Hi

I am trying to display records then onclick edit button the fileds will edit then update button , onclick this button the database shd update with the fields, I am getting NullPointer Exception, Dont knw wats the problem, Here is my code

OutransEdit.java

package update;

import java.io.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.sql.*;

public class OutransEdit extends HttpServlet {

public void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        response.setContentType("text/html");
        PrintWriter out = response.getWriter();
        out.println("<title>Update Page</title>" + "<h1 align=\"center\"></h1>" + "<body bgcolor=#99CCFF>");
        out.println("<center><td  width=\"37\"> <strong>" +
               "<img title=\"Go back\" src=\"Btn_back.png\" width=\"20\" height=\"20\" onClick=\"javascript:history.back()" +
               "\" style=\"vertical-align:middle;\" onMouseOver=\"this.style.cursor='hand';\"></strong></td></center><br>");
        System.out.println("Oracle 10g Connect Example.");
        Connection conn = null;
        String url = "jdbc:oracle:thin:@localhost:1529:xe";
        String driver = "oracle.jdbc.driver.OracleDriver";
        String user = "hr";
        String pass = "hr";
        if (request.getParameter("SerialNo") != null && request.getParameter("SerialNo") != "") {

String SerialNo = request.getParameter("SerialNo").toString();
            String PartNo = request.getParameter("PartNo").toString();
            String Material_Number = request.getParameter("Material_Number").toString();
            String Material_Desc = request.getParameter("Material_Desc").toString();
            String Pegasus_Work_Order_No = request.getParameter("Pegasus_Work_Order_No").toString();
            String Project_Code = request.getParameter("Project_Code").toString();
             String Dt_of_OUT_Transaction = request.getParameter("Dt_of_OUT_Transaction").toString();
            String Transaction_Status = request.getParameter("Transaction_Status").toString();
            String Inventory_Qty = request.getParameter("Inventory_Qty").toString();
            String Requested_By = request.getParameter("Requested_By ").toString();
            String Issued_By  = request.getParameter("Issued_By ").toString();
            String Received_By= request.getParameter("Received_By").toString();

Statement stmt;
            try {
                Class.forName(driver).newInstance();
                conn = DriverManager.getConnection(url, user, pass);
                System.out.println("Connected to the database");
                String query = "UPDATE InventoryDB_Main SET SerialNo = '"+ SerialNo +"',PartNo='"+ 
                          PartNo+"',Material_Number='" + Material_Number + "',Material_Desc='"+ 
                          Material_Desc + "',Pegasus_Work_Order_No='"+ Pegasus_Work_Order_No +
                          "', Project_Code='"+Project_Code+"',Dt_of_OUT_Transaction='"+ Dt_of_OUT_Transaction +
                          "',Transaction_Status='"+ Transaction_Status +"',Inventory_Qty='"+Inventory_Qty+"',Requested_By='"+
                          Requested_By +"',Issued_By='"+ Issued_By +"',Received_By='"+ Received_By+"' WHERE SerialNo='" +
                          SerialNo + "'";
                stmt = conn.createStatement();
                int i = stmt.executeUpdate(query);
                System.out.println("query" + query);
                   if (i > 0) {
                   out.print("<br>");
                   out.print("<table  align=\"center\" font=\"18\" style=\"background-color:#efefef\"width=\"50%\" border=\"1\">");
                   out.print("<tr><th>Data Modified Successfully</th></tr>");
                   out.print("</table>");
                   stmt.close();
                }
}
  catch(ClassNotFoundException e){
  out.println("Couldn't load database driver: " + e.getMessage());
  }
  catch(NullPointerException e){
  out.println("NullPointerException caught: " + e.getMessage());
  }
  catch (Exception e){
  out.println(e);
  }
  finally {
  // Always close the database connection.
  try {
  if (conn != null) conn.close();
  }
  catch (SQLException ignored){
  out.println(ignored);
  }
  }
  }
} 
}

The Dt_of_OUT_Transaction column is VARCHAR2(20).

This code is giving me NullPointer Exception, Can anyone please look into my code and correct, Its urgent. I really dont knw where is the problem. Please help me out.

Thanks in advance
Lissy.

Mike Zal

Ranch Hand

Posts: 144

I like...

posted 6 years ago

This seems like it belongs better in the JDBC forum. With that being said, I have a few comments about your code.

When you are asking people to help solve a problem, it is nice and sometime necessary to provide the stack trace. There are a lot of things in your code that could be causing errors. The most likely problem is the is a problem with your setting of values from your request. Request parameters are ALWAYS Strings. Your use of toString() could be causing the NullPointer if the parameter does not exist. Have you verified that all the request parameters are being set? Try writing all the Strings to a log to see what their values are being set as.

Whenever you are performing a database update, ALWAYS USE java.sql.PreparedStatement. Using regular java.sql.Statement leaves your application open for SQL injection attacks. You may not want to have your request parameters exactly match the names of the fields in your table. That makes it even easier to perform the SQL injection. You should also sanitize any inputs for not only SQL injection, but also to prevent simple formatting issues. Do you verify that all the request parameters are of the proper type and length? Do any varchars exceed the length of the database field?

Your database structure should also be in the Third Normal Form. The way you have your table structured defeats the purpose of having a database since it acts more like a spreadsheet. Is there a reason that your Inventory_Qty field is stored as a varchar instead of a numeric type?

A minor coding point, but a rule of thumb is not to have a single line of code exceed the width of the screen. You should add some line breaks into your SQL query string.

OCJP6, OCWCD5

Swastik Dey

Rancher

Posts: 1784

I like...

posted 6 years ago

Which line is showing npe? And it would be better to use PreparedStatement instead of Statement.

Swastik

Bear Bibeault

Author and ninkuma
Marshal

Posts: 65898

135

I like...

posted 6 years ago

Moved to the JDBC forum.

[Asking smart questions] [About Bear] [Books by Bear]

Paul Clapham

Sheriff

Posts: 22203

I like...

posted 6 years ago

Swastik Dey wrote:Which line is showing npe?

I predict it's going to be one of the lines like

where request.getParameter("Inventory_Qty") is returning null (because the user didn't fill in that box in the HTML form).

lisy jessica

Ranch Hand

Posts: 47

posted 6 years ago

Thanks alot for the quick responses,

The full stack trace is

java.net.URISyntaxException: Illegal character in path at index
                      18: file:/C:/Documents and Settings/Administrator/My Documents/
                       NetBeansProjects/UploadApplication/build/web/WEB-INF/lib/classes12.jar
	at java.net.URI$Parser.fail(URI.java:2809)
	at java.net.URI$Parser.checkChars(URI.java:2982)
	at java.net.URI$Parser.parseHierarchical(URI.java:3066)
	at java.net.URI$Parser.parse(URI.java:3014)
	at java.net.URI.<init>(URI.java:578)
	at java.net.URL.toURI(URL.java:918)
	at com.sun.enterprise.v3.server.SnifferManagerImpl.getURIs(SnifferManagerImpl.java:268)
	at com.sun.enterprise.v3.server.SnifferManagerImpl.getApplicableSniffers(SnifferManagerImpl.java:202)
	at com.sun.enterprise.v3.server.SnifferManagerImpl.getSniffers(SnifferManagerImpl.java:150)
	at com.sun.enterprise.v3.server.ApplicationLifecycle.setupContainerInfos(ApplicationLifecycle.java:604)
	at com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:368)
	at com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:240)
	at org.glassfish.deployment.admin.DeployCommand.execute(DeployCommand.java:370)
	at com.sun.enterprise.v3.admin.CommandRunnerImpl$1.execute(CommandRunnerImpl.java:355)
	at com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRunnerImpl.java:370)
	at com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRunnerImpl.java:1067)
	at com.sun.enterprise.v3.admin.CommandRunnerImpl.access$1200(CommandRunnerImpl.java:96)
	at com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1247)
	at com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1235)
	at com.sun.enterprise.v3.admin.AdminAdapter.doCommand(AdminAdapter.java:465)
	at com.sun.enterprise.v3.admin.AdminAdapter.service(AdminAdapter.java:222)
	at com.sun.grizzly.tcp.http11.GrizzlyAdapter.service(GrizzlyAdapter.java:168)
	at com.sun.enterprise.v3.server.HK2Dispatcher.dispath(HK2Dispatcher.java:117)
	at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:234)
	at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:822)
	at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:719)
	at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1013)
	at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:225)
	at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultProtocolChain.java:137)
	at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:104)
	at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:90)
	at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:79)
	at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:54)
	at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:59)
	at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
	at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:532)
	at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool.java:513)
	at java.lang.Thread.run(Thread.java:662)
|#]

[#|2011-05-30T14:40:53.619+0800|INFO|glassfish3.1|javax.enterprise.system.std.com.sun.enterprise.server.logging|_ThreadID=94;_ThreadName=Thread-1;|----------I am in DBConnection----------|#]

[#|2011-05-30T14:40:53.744+0800|INFO|glassfish3.1|javax.enterprise.system.std.com.sun.enterprise.server.logging|_ThreadID=94;_ThreadName=Thread-1;|---------end of DBConnection----------|#]

[#|2011-05-30T14:40:53.760+0800|INFO|glassfish3.1|javax.enterprise.system.std.com.sun.enterprise.server.logging|_ThreadID=94;_ThreadName=Thread-1;|query select SerialNo,PartNo,Material_Number,Material_Desc,Pegasus_Work_Order_No,Project_Code,Dt_of_OUT_Transaction,Transaction_Status,Requested_By,Issued_By,Received_By from InventoryDB_Main where SerialNo='YP0637C3672'|#]

[#|2011-05-30T14:41:03.152+0800|WARNING|glassfish3.1|javax.enterprise.system.container.web.com.sun.enterprise.web|_ThreadID=97;_ThreadName=Thread-1;|StandardWrapperValve[OutEditData]: PWC1406: Servlet.service() for servlet OutEditData threw exception
java.lang.NullPointerException
	at update.OutEditData.doPost(OutEditData.java:31)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:755)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
	at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1534)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:281)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
	at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:655)
	at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:595)
	at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:98)
	at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:91)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:162)
	at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:326)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:227)
	at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:170)
	at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:822)
	at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:719)
	at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1013)
	at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:225)
	at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultProtocolChain.java:137)
	at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:104)
	at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:90)
	at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:79)
	at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:54)
	at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:59)
	at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
	at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:532)
	at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool.java:513)
	at java.lang.Thread.run(Thread.java:662)
|#]

I am still getting the same error, The problem was with Inventory_Qty, The datatype of Inventory_Qty is Number, now I removed this Inventory_Qty from my code and trying to update other fields using prepared statement, am still getting the above error. Please help me out. I am really confused y am getting still getting the error.

Thanks in advance
Lissy.

Sean Clark

Rancher

Posts: 377

I like...

posted 6 years ago

Hey,

Well the exception says it is happening on line 31 of that class:

java.lang.NullPointerException
at update.OutEditData.doPost(OutEditData.java:31)

which in the code you posted is this line: Have you followed Mike's advice above and printed out the value of each of the parameters (and also not called the toString() method) like:
Also another code style thing, variables typically start with a lower case letter to make it easier for someone reading the code to know what is a class and what is a variable.

Sean

I love this place!

lisy jessica

Ranch Hand

Posts: 47

posted 6 years ago

Thank you so much for the prompt reply, will try this and get back to you.

Thanks,
Lissy.

lisy jessica

Ranch Hand

Posts: 47

posted 6 years ago

I have printed the values, two values are returning null thats y am getting NullPointerException, the values are Requested_By, Issued_By

this is my EditServlet.java

import java.io.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.sql.*;
import java.util.*;

public class EditServlet extends HttpServlet {
   
   public void doGet(HttpServletRequest request, HttpServletResponse response)
                                   throws ServletException,IOException{
			response.setContentType("text/html");
			PrintWriter out = response.getWriter();
			String SerialNo= request.getParameter("SerialNo");
                        System.out.println("Oracle 10g Connect Example.");
			Connection conn = null;
			Statement st;
			try {
				conn = DBConnection1.getConnection();
				System.out.println("Connected to the database");
                                ArrayList userList=null;
				String query = "select SerialNo,PartNo,Material_Number,Material_Desc,Purchase_Order,Project_Code,Pegasus_Work_Order_No,Dt_of_OUT_Transaction,Transaction_Status,Requested_By,Issued_By,Received_By from InventoryDB_Main where SerialNo='" + SerialNo + "'";
				System.out.println("query " + query);
				st = conn.createStatement();
				ResultSet  rs = st.executeQuery(query);
                               while(rs.next())
				{
                                  userList =new ArrayList();
				  userList.add(rs.getString(1));
				  userList.add(rs.getString(2));
                                  userList.add(rs.getString(3));
                                  userList.add(rs.getString(4));
                                  userList.add(rs.getString(5));
				  userList.add(rs.getString(6));
                                  userList.add(rs.getString(7));
                                  userList.add(rs.getString(8));
                                  userList.add(rs.getString(9));
				  userList.add(rs.getString(10));
                                  userList.add(rs.getString(11));
                                  userList.add(rs.getString(12));
                                  
                                  
                                 }
                                request.setAttribute("userList",userList);
                                String nextJSP = "/OutEditData.jsp";
				RequestDispatcher dispatcher = getServletContext().getRequestDispatcher(nextJSP);
				dispatcher.forward(request,response);
				conn.close();
                                rs.close();
                                st.close();
				System.out.println("Disconnected from database");

} catch (Exception e) {
			e.printStackTrace();
			}
  }
}

OutEditData.jsp

<%@ page language="java" import="java.util.*;"%>
<%@ page language="java" import="java.sql.*"%>
<%@ page language="java" import="java.lang.*"%>
<html>
<head>
    </script>
<script type="text/javascript" align="right">
document.write("<p>" + Date() + "</p>");
</script>
</head>
<BODY bgcolor="#99CCFF">

<br>
       
<br></br>
    <form name="editform" method="post" action="OutransEdit">
        <%!
            String SerialNo = "";
            String PartNo = "";
            String Material_Number = "";
            String Material_Desc = "";
            String Purchase_Order = "";
            String Project_Code = "";
            String Pegasus_Work_Order_No = "";
            String Dt_of_OUT_Transaction ="";
            String Transaction_Status = "";
            String Requested_By = "";
            String Issued_By = "";
            String Received_By = "";

List userList= null;
        %>
<%

if(request.getAttribute("userList")!=null && request.getAttribute("userList")!="")
{
		userList = (ArrayList)request.getAttribute("userList");

SerialNo = userList.get(0).toString();
                PartNo = userList.get(1).toString();
		Material_Number = userList.get(2).toString();
		Material_Desc = userList.get(3).toString();
                Purchase_Order = userList.get(4).toString();
                Project_Code = userList.get(5).toString();
                Pegasus_Work_Order_No = userList.get(6).toString();
                Dt_of_OUT_Transaction = userList.get(7).toString();
                Transaction_Status = userList.get(8).toString();
		Requested_By = userList.get(9).toString();
                Issued_By = userList.get(10).toString();
                Received_By = userList.get(11).toString();

}
%>

<tr>
                <td>Serial No</td>
                <td><input type="text" name="SerialNo" value="<%=SerialNo%>"></td>
            </tr>
            
            <tr>
                <td>Part No</td>
                <td><input type="text" name="PartNo" value="<%=PartNo%>"></td>
            </tr>
            
            <tr>
                <td>Material Number</td>
                <td><input type="text" name="Material_Number" value="<%=Material_Number%>"></td>
            </tr>
            <tr>
                <td>Material Description</td>
                <td><input type="text" name="Material_Desc" value="<%=Material_Desc%>"></td>
            </tr>
            <tr>
                <td>Purchase_Order</td>
                <td><input type="text" name="Purchase_Order" value="<%=Purchase_Order%>"></td>
            </tr>
            <tr>
                <td>Project_Code</td>
                <td><input type="text" name="Project_Code" value="<%=Project_Code%>"></td>
            </tr>
            <tr>
                <td>Pegasus_Work_Order_No</td>
                <td><input type="text" name="Pegasus_Work_Order_No" value="<%=Pegasus_Work_Order_No%>"></td>
            </tr>
             
            <tr>
                <td>Dt_of_OUT_Transaction</td>
                <td><input type="text" name="Dt_of_OUT_Transaction" value="<%=Dt_of_OUT_Transaction%>"></td>
            </tr>
            <tr>
                <td>Transaction_Status</td>
                <td><input type="text" name="Transaction_Status" value="<%=Transaction_Status%>"></td>
            </tr>
           
             
            <tr>
                <td>Requested_By</td>
                <td><input type="text" name="Requested_By" value="<%=Requested_By%>"></td>
            </tr>
            
            <tr>
                <td>Issued_By</td>
                <td><input type="text" name="Issued_By" value="<%=Issued_By%>"></td>
            </tr>
            
             <tr>
                <td>Received_By</td>
                <td><input type="text" name="Received_By" value="<%=Received_By%>"></td>
            </tr>

I dont know y the two values are null, Requested_By and Issued_By, Please can anyone look into my code and correct me.

Thanks in advance
Lissy.

lisy jessica

Ranch Hand

Posts: 47

posted 6 years ago

Thanks alot everyone for helping me, I got it finally, I made a silly mistake, I gave a space after the Requested_By and Issued_By that's y am getting NPE.

String Requested_By = request.getParameter("Requested_By ");

String Issued_By = request.getParameter("Issued_By ");

Thanks alot everypone once again for helping me.

Thanks
Lissy.

Problem in updating the fields to database

Similar Threads