Corrupt file download

[Nick Sher]

Hi,

I am trying to download a file using Struts 2 but the downloaded XML file is corrupt. It works if the xml file has around 60 lines else the content is ignored. I am not an IO expert but kindly correctly me if I need to fix anything here. Can someone please help me? Here is what I am trying to do.

The Action class:

byte[] results= service.download();
contentLength = results.length;
downloadStream = new ByteArrayInputStream(results);
result = "downloadSuccess";

The service class:

HttpClient client = new HttpClient();
GetMethod method = new GetMethod(urlString);
BufferedInputStream inputStream = null;
byte[] reservationsFile = null;
		
try{
	client.executeMethod(method);
	if(method.getStatusCode() == HttpStatus.SC_NO_CONTENT)
				throw ExceptionUtil.makeException("error.no.content");
			
	inputStream = new BufferedInputStream(method.getResponseBodyAsStream());
			
	resultsFile = new byte[inputStream.available()];
	int offset = 0;
	int numRead = 0;
	while(offset < resultsFile.length && (numRead = inputStream.read(resultsFile,offset, resultsFile.length-offset))>=0){
				offset +=numRead;
	}
			
}catch(Exception e){
	e.printStackTrace();
}finally{
	if(inputStream != null){
		try{
			inputStream.close();
		}catch(IOException e){
			throw ExceptionUtil.makeException("error.unknown");
		}
}
method.releaseConnection();
}
		
return resultsFile;

The struts.xml settings:
<result name="downloadSuccess" type="stream"> <param name="contentType">%{contentType}</param> <param name="contentLength">%{contentLength}</param> <param name="inputName">downloadStream</param> <param name="contentDisposition">attachment;filename=%{downloadFileName}</param> <param name="bufferSize">1024</param> </result>

[Nick Sher]

Resolved.

The fix is to use:

IOUtils.toByteArray(inputStream);

[Paul Clapham]

And specifically in regard to your post, I think you will find that the utility you mention doesn't make the mistake of assuming the "available()" method will always return the length of the response body.