Progress Bar and Thread

[Ashish Agre]

import javax.swing.*;
class chVal implements Runnable{
//    static int totalThread = 0;
    JProgressBar j;
    JLabel l;
    public chVal(JProgressBar j, JLabel l) {
        this.j = j;
        this.l = l;
    }
    public void run() {
//        System.out.println(+totalThread);
        for(int i=0;i<j.getMaximum();i++)
        try{
            Thread.currentThread().sleep(100);
            j.setStringPainted(true);
            j.setValue(j.getValue() + 1);
            int temp = j.getValue();
            String s = "Status : " + Integer.toString(temp) + " %";
            l.setText(s);
        }catch(Exception e) {

        }
    }
}
public class ProgressDemo extends javax.swing.JFrame {
    Thread t;
    chVal c;

    /** Creates new form ProgressDemo */
    public ProgressDemo() {
        initComponents();
        jLabel2.setText("Status : 0");
        c =  new chVal(j, jLabel2);
    }


    @SuppressWarnings("unchecked")
    // <editor-fold defaultstate="collapsed" desc="Generated Code">
    private void initComponents() {

        j = new javax.swing.JProgressBar();
        jButton1 = new javax.swing.JButton();
        jButton2 = new javax.swing.JButton();
        jLabel1 = new javax.swing.JLabel();
        jLabel2 = new javax.swing.JLabel();

        setDefaultCloseOperation(javax.swing.WindowConstants.EXIT_ON_CLOSE);
        setTitle("Progress Bar Demo");
        setBackground(new java.awt.Color(204, 255, 204));
        setResizable(false);

        jButton1.setText("Start");
        jButton1.addActionListener(new java.awt.event.ActionListener() {
            public void actionPerformed(java.awt.event.ActionEvent evt) {
                jButton1ActionPerformed(evt);
            }
        });

        jButton2.setText("Reset");
        jButton2.addActionListener(new java.awt.event.ActionListener() {
            public void actionPerformed(java.awt.event.ActionEvent evt) {
                jButton2ActionPerformed(evt);
            }
        });

        jLabel1.setBackground(new java.awt.Color(153, 255, 102));
        jLabel1.setFont(new java.awt.Font("OCR A Extended", 1, 24));
        jLabel1.setForeground(new java.awt.Color(0, 153, 0));
        jLabel1.setText("Progress Bar Demo");
        jLabel1.setBorder(new javax.swing.border.SoftBevelBorder(javax.swing.border.BevelBorder.RAISED, null, java.awt.Color.green, null, null));

        jLabel2.setBackground(new java.awt.Color(102, 255, 255));
        jLabel2.setFont(new java.awt.Font("Times New Roman", 1, 14));
        jLabel2.setHorizontalAlignment(javax.swing.SwingConstants.TRAILING);
        jLabel2.setText("jLabel2");
        jLabel2.setBorder(javax.swing.BorderFactory.createMatteBorder(1, 1, 1, 1, new java.awt.Color(204, 0, 51)));

        javax.swing.GroupLayout layout = new javax.swing.GroupLayout(getContentPane());
        getContentPane().setLayout(layout);
        layout.setHorizontalGroup(
            layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(layout.createSequentialGroup()
                .addContainerGap()
                .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
                    .addGroup(layout.createSequentialGroup()
                        .addComponent(jButton1)
                        .addGap(18, 18, 18)
                        .addComponent(jButton2))
                    .addComponent(jLabel1, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)
                    .addComponent(j, javax.swing.GroupLayout.DEFAULT_SIZE, 278, Short.MAX_VALUE)
                    .addComponent(jLabel2, javax.swing.GroupLayout.DEFAULT_SIZE, 278, Short.MAX_VALUE))
                .addContainerGap())
        );
        layout.setVerticalGroup(
            layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(layout.createSequentialGroup()
                .addGap(27, 27, 27)
                .addComponent(jLabel1, javax.swing.GroupLayout.PREFERRED_SIZE, 45, javax.swing.GroupLayout.PREFERRED_SIZE)
                .addGap(53, 53, 53)
                .addComponent(j, javax.swing.GroupLayout.PREFERRED_SIZE, 43, javax.swing.GroupLayout.PREFERRED_SIZE)
                .addGap(32, 32, 32)
                .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.BASELINE)
                    .addComponent(jButton1, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)
                    .addComponent(jButton2))
                .addGap(52, 52, 52)
                .addComponent(jLabel2)
                .addContainerGap())
        );

        pack();
    }// </editor-fold>

    private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {                                         
        chVal c = new chVal(j, jLabel2);
        t = new Thread(c);
        startThread(t);
        jButton1.setEnabled(false);
        jButton2.setEnabled(true);
    }                                        

    private void jButton2ActionPerformed(java.awt.event.ActionEvent evt) {                                         
        jButton1.setEnabled(true);
        jButton2.setEnabled(true);
        try {
             t.interrupted();
             boolean b = t.isAlive();
             System.out.println(b);
             j.setValue(0);
             
        }catch(Exception e) {
            System.out.println("Thread interrupted to reset");
        }
    }                                        
    public void startThread (Thread t) {
        t.start();
    }
    /**
    * @param args the command line arguments
    */
    public static void main(String args[]) {
        java.awt.EventQueue.invokeLater(new Runnable() {
            public void run() {
                new ProgressDemo().setVisible(true);
            }
        });
    }

    // Variables declaration - do not modify
    private javax.swing.JProgressBar j;
    private javax.swing.JButton jButton1;
    private javax.swing.JButton jButton2;
    private javax.swing.JLabel jLabel1;
    private javax.swing.JLabel jLabel2;
    // End of variables declaration

}

Anybody please help me i want that when reset is clicked then the current thread must terminate ...
and new thread must start....

[Stephan van Hulst]

In chVal's run() method, make the loop test not only whether it's at the end of progress, but also whether it has to abort. Simply use a boolean member variable, and set this boolean to abort in your reset button.

By the way, your code looks very bulky. Don't fully qualify classes in your code. Instead, import java.awt.event.*, javax.swing.event.* and javax.swing.border.* and use simply class names in your code.

Also, never use variable names like j or l as member variables. They need to be descriptive. You should also use upper camel case for class names. Don't use chVal, it doesn't follow naming conventions, and its meaning is not clear.
Also, don't call your methods names like jButton2ActionPerformed(), call them names that describe what they do, like reset().

[Rob Spoor]

Stephan van Hulst wrote:Also, don't call your methods names like jButton2ActionPerformed(), call them names that describe what they do, like reset().

The GUI part has been automatically generated; you can tell from the use of GroupLayout, the way the event handling methods are named, and the presence of the initComponents method.

[Stephan van Hulst]

Ahh I see. Another reason for me to write my GUIs manually :P

[Darryl Burke]

I feel it's unfortunate that Oracle, and Sun before them, present the NetBeans visual designer as a beginners' tool, as witness the byline in the Swing Tutoral index page:

Learning Swing with the NetBeans IDE is the fastest and easiest way to begin working with Swing.

I wouldn't agree with that. The fastest and easiest way to learn Swing is to learn the API and how to use it, with the help of tutorials and the occasional input from a more experienced person, on a forum or elsewhere. The visual designer can be a powerful productivity booster in the hands of a skilled and experienced Java / Swing coder, who would know better than to blindly accept default variable and method names, and who would know just what all the auto-generated code does.

[Ashish Agre]

well darryl i tried that using netbeans for swing might be easy but ofcourse nobody likes it here... just complaints ..

when you know :

JButton j = new JButton("Press me") 

100 times then at 101th time you just need to drag and drop with the help of visual deigner but this doesn't seems to be acceptable

[Paul Clapham]

Sure it's acceptable. The thing is, it's also acceptable to post your own code here and ask questions about it. But posting somebody else's code which you don't understand... that irritates people a bit. And that's basically what you're doing when you post code generated by Netbeans. So they tend to say things like "Learn Swing for yourself first, then you won't be taken aback when you are forced to debug somebody else's Swing code".

Just my two cents (CAD, not US pesos) about where those complaints are coming from.

[Darryl Burke]

Ashish Agre wrote:well darryl i tried that using netbeans for swing might be easy but ofcourse nobody likes it here... just complaints ..

when you know :

JButton j = new JButton("Press me") 

100 times then at 101th time you just need to drag and drop with the help of visual deigner but this doesn't seems to be acceptable

If you have 100 buttons with a similar functionality (I'm thinking Minesweeper) you should be using an array.

And if you have 100 buttons on a single screen, and they don't have similar functionality, you have a severe design/usability problem.

Sorry if that comes across as supercilious and me acting superior, but just think about it for yourself -- do you agree?

[Ashish Agre]

well darryl i just want to know it is good to use use netbeans IDE for studying swing as most memorizing thing that after applying . on the object (JButton.setEnable(true)) we are able to see how many more function are associated with the object so that every time we don't need to refer javadoc
@ paul after core i want to concentrate on swing should i continue with netbeans or the same cmd(>_) or terminal[ashish : $]

[Darryl Burke]

Just to be clear: I don't recommend coding Java in Notepad. By all means take advantage of the syntax highlighting and code completion, with popup javadoc, that an IDE provides.

My stand is that the NetBeans visual designer is not a beginners' tool, and never will be. It actually lowers productivity for a beginner, and is IMHO about 5 times more difficult to learn than it is to learn hand coding.

OTOH, once you have adequate exposure to Swing coding, once you know what can (and should) be done, it's relatively easier to discover for the first time how to do that in a visual designer.

And Java has methods, not functions