Generating OL LI tree structure from a recursive method call

[Tahir Akram]

Hi

I have a list of objects type Node (items). And Node class has children in it (childItems). I Want to print this structure in ol li html markup.

Preparing in a recursive method. But there is some issue in my logic. Have a look on my code.

The the size of the items will be 2. According to given sample markup. Means 2 top level parents exist. And then they have further children as a list in them.

StringBuffer html = new StringBuffer();

 void printValues(ArrayList items){ 
for (Object o : items){
    html.append("<ol>");
    html.append("<li>");
    Node node = (Node)o;
    html.append(node.getName);

    if (node.getChildItems()!= null){
        printValues(node.getChildItems());
    }else{
        html.append("</li>");
    }
    html.append("</ol>");
}   
 }
// ...........
 System.out.println(html.toString(););

//...
  public class Node{
String Name;
ArrayList childItems = new ArrayList(); // of type Node
/* getter setters are proper */
}

Following markup is an example. It can be on N level.

<ol> <li> Manager <ol> <li> Associate Manager <ol> <li> A.M. Configuration 1 </li> <li> A.M. Configuration 2 </li> <li> Staff Memmber <ol> <li> Staff Memmber Configuration </li> <!-- can goes on --> <li>...</li> </ol> </li> </ol> </li> </ol> </li> <li> Client Package <ol> <li> Gold <ol> <li> Feature 1 </li> <li> Feature 2 </li> </ol> </li> </ol> </li>

[Greg Charles]

You want to put out the <ol> before the loop starts, and the </ol> after it ends. You might want to check there is at least one element before you do that though.

[Rob Spoor]

Also, print out the closing regardless of whether there are any children or not. Simply take it outside the else block.