Can't find out the error

[budsy remo]

Hi i'm getting a problem in my TheIcon Class . I am trying to implement a JFileChooser but when i want to use an accessory with it . I want to add an icon at a side which will display a thumbnail of the image being selected . The program works fine without the "TheIcon " class . I'll make the lines as bold where the error is showing . The error is : not a statement File f= (File) e.getNewValue();

import javax.swing.*;
import java.awt.event.*;
import java.awt.*;
import java.io.*;
import javax.swing.filechooser.*;
public class Q5
{
	public static void main(String... args)
	{
		EventQueue.invokeLater(new Runnable()
		{
			public void run()
			{
				Q5Fr q3=new Q5Fr();
				q3.setVisible(true);
				q3.setDefaultCloseOperation(q3.EXIT_ON_CLOSE);
			}
		});
	}
}
class Q5Fr extends JFrame
{
	private JFileChooser jfc1;
	private JLabel jl1;
	Q5Fr()
	{
		setSize(500,600);
		setTitle("Hello");
		
		jl1=new JLabel();
		add(jl1,BorderLayout.CENTER);
		
		jfc1=new JFileChooser();
		jfc1.setCurrentDirectory(new File("."));
		JMenuBar jmb1=new JMenuBar();
		setJMenuBar(jmb1);
		JMenu file=new JMenu("file");
		jmb1.add(file);
		
		JMenuItem jmi1=new JMenuItem("Open",'O');
		file.add(jmi1);
		file.addSeparator();
		JMenuItem jmi2=new JMenuItem("Exit",'E');
		
		IconView iv1=new IconView();
		jmi1.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent e)
			{
				int result=jfc1.showOpenDialog(Q5Fr.this);
				
				if(result==jfc1.APPROVE_OPTION)
				{
					String path=jfc1.getSelectedFile().getPath();
					Dimension d=jl1.getPreferredSize();
						
					ImageIcon ii1=new ImageIcon(path);
					jl1.setSize(ii1.getIconWidth(),ii1.getIconHeight());
					jl1.setIcon(ii1);
					System.out.println(ii1.getIconHeight()+" "+ii1.getIconWidth());
				}
			}
		});
		
		file.add(jmi2);
		jmi2.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent e)
			{
				System.exit(0);
			}
		});
		jfc1.setAccessory(new TheIcon(jfc1));	
	}
	
	
}
class IconView extends FileView
{
	IconView()
	{
		java.net.URL url1=getClass().getResource("ist2_2504199-baldy-bloke.jpg");
		if(url1==null)
		System.out.println("aloha");
	}
}
class TheIcon extends JLabel
{
	TheIcon(JFileChooser jfc1)
	{
		setPreferredSize(200,200);
		jfc1.addPropertyChangeListener(new PropertyChangeListener()
		{
			public void propertyChange(PropertyChangeEvent e)
			{
				if(e.getPropertyName()==JFileChooser.SELECTED_FILE_CHANGED_PROPERTY)
				File f= (File) e.getNewValue();
				if(f==null)
				{
					setIcon(null);
				}
				else
				{
					ImageIcon temp=new ImageIcon(f.getPath());
					setIcon(new ImageIcon(temp.getImage().getScaledInstance(-1,-1,Image.SCALE_DEFAULT));
				}
			}
		});
	}

[budsy remo]

The error is on line no 97 but i don't know what .

[Matthew Brown]

I think you might be missing some brackets around the block following line 96. Have another look there.

[budsy remo]

@Matthew I have missed out a bracket in the post but not in code otherwise i would have had an "reached end of line while parsing" error .

[Matthew Brown]

So what exactly do you think the scope of the variable you're declaring on line 97 is at the moment?

[budsy remo]

i only need that variable for getting the name of the file so that i could get an icon and use setIcon() to the label . It's scope is within the propertyChange(PropertyChangeEvent e) .

[Matthew Brown]

No it isn't. The scope is currently limited to that line only, because you've got an if statement (line 96) with no brackets following. Which means that only the following line is within the if block. You need to put brackets round the entire following block.

[budsy remo]

Thanks a lot man . Solved the error .

[Rob Spoor]

You're comparing Strings (e.getPropertyName() and JFileChooser.SELECTED_FILE_CHANGED_PROPERTY) using == while you should be using the equals method.

[budsy remo]

shouldn't it work because the == checks for the same memory location and e.getPropertyName() would return a string at the same memory location as the JFileChooser's static string SELECTED_FILE_PROPERTY_CHANGED ???

[Rob Spoor]

It might, but are you sure it always will? What if the property name will be a new String similar to the constant but not the same in regards to ==?