Win a copy of Functional Reactive Programming this week in the Other Languages forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Need help with Prime number Loop and with boolean statement

 
Kwasi Roberts
Greenhorn
Posts: 4
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Can someone tell me where I'm going wrong here in making this read all prime numbers
import java.util.*;

Here is my original code


Here is the code where I was asked to combine a while loop with a boolean statement. I need help on both.



[Edit: put code between [code] and [/code] ubb code blocks]
 
Andrew Monkhouse
author and jackaroo
Marshal Commander
Pie
Posts: 11945
212
C++ Firefox Browser IntelliJ IDE Java Mac Oracle
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
For the first class:
  • What is the definition of a Prime number? How are you handling the two conditions to validate that it is a prime?
  • What are you trying to do in lines 20 - 22?

  •  
    Campbell Ritchie
    Sheriff
    Pie
    Posts: 50258
    79
    • Mark post as helpful
    • send pies
    • Quote
    • Report post to moderator
    You are both mistaken using ½ the number as the limit for testing whether it is prime. You ought to use √number. You also should use a Sieve of Eratosthenes to populate a boolean array and that will tell you whether a number is prime or not. Much faster and efficient than using the % operator. If you look in the Wikipedia article which appears from that link, there is the Sieve of Euler, too.
     
    Andrew Monkhouse
    author and jackaroo
    Marshal Commander
    Pie
    Posts: 11945
    212
    C++ Firefox Browser IntelliJ IDE Java Mac Oracle
    • Mark post as helpful
    • send pies
    • Quote
    • Report post to moderator
    vinayak jog - thank you for replying, however at CodeRanch we work on the theory that we want to teach people how to solve the problems themselves. Complete solutions don't lend themselves to that - the learning experience is removed.

    I therefore removed your response.
     
    • Post Reply
    • Bookmark Topic Watch Topic
    • New Topic