SQL Update not happening

Kiran kk

Greenhorn

Posts: 9

posted 6 years ago

i'm writing a jsp file that takes theatre, movie name,cast,director,language,opendate,closedate(all are stirings). I'm getting their values in the servlet and passing them to the class to do the update.. No exceptions found.. but still the update is not happening...
here is the code below

JSP file

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
</head>
<body>

<form method="get" action="AddmovieServlet">
Select Theatre<br></br>
<input type="radio" name="theatre" value="Fire"></input>Fire
<input type="radio" name="theatre" value="Air"></input>Air
<input type="radio" name="theatre" value="Earth"></input>Earth
<input type="radio" name="theatre" value="Sky"></input>Sky
<input type="radio" name="theatre" value="Water"></input>Water
<table align="center">
<tr>
<td>Movie Name:</td>
<td><input type="text" name="moviename"></input></td>
</tr>
<tr>
<td>Star Cast:</td>
<td><input type="text" name="starcast"></input></td>
</tr>
<tr>
<td>Director:</td>
<td><input type="text" name="director"></input></td>
</tr>
<tr>
<td>Language:</td>
<td><input type="text" name="language"></input></td>
</tr>
<tr>
<td>Open Date:</td>
<td><input type="text" name="opendate"></input></td>
</tr>
<tr>
<td>Date Date:</td>
<td><input type="text" name="closedate"></input></td>
</tr>
<tr>
<td colspan="2" align="right"> <input type="submit" value="add movie"></input></td>
</tr>
</table>
</form>
</body>
</html>

servlet file

package control;
import java.io.IOException;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import model.AddMovieClass;
/**
 * Servlet implementation class AddmovieServlet
 */
public class AddmovieServlet extends HttpServlet {
	private static final long serialVersionUID = 1L;
       
    /**
     * @see HttpServlet#HttpServlet()
     */
    public AddmovieServlet() {
        super();
        // TODO Auto-generated constructor stub
    }

/**
	 * @see HttpServlet#doGet(HttpServletRequest request, HttpServletResponse response)
	 */
	protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		// TODO Auto-generated method stub
		String mname=request.getParameter("moviename");
		String starcast=request.getParameter("starcast");
		String director=request.getParameter("director");
		String language=request.getParameter("language");
		String odate=request.getParameter("opendate");
		String cdate=request.getParameter("closedate");
		String theatre=request.getParameter("theatre");
		AddMovieClass mc=new AddMovieClass();
		if(mc.add(mname,starcast,director,language,odate,cdate,theatre))
		response.sendRedirect("movieadded.jsp");
		else
			response.sendRedirect("AddmovieJsp.jsp");
	}

/**
	 * @see HttpServlet#doPost(HttpServletRequest request, HttpServletResponse response)
	 */
	protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		// TODO Auto-generated method stub
	}

}

class file

please help me...

Madhan Sundararajan Devaki

Ranch Hand

Posts: 312

I like...

posted 6 years ago

I believe, your UPDATE query requires quotes around the ? symbols, as all the values are Strings. Also, you may need to explicitly set autocommit to true. BTW I am unable to understand why you have put ps.execute() statement after the executeUpdate statement! Further, you need to move the ps.close() statement before releasing the connection.

S.D. MADHAN
Not many get the right opportunity !

Abhay Agarwal

Ranch Hand

Posts: 1376

I like...

posted 6 years ago

I think it is because you are not committing your changes in database.

above mentioned commit code is missing in your AddMovieClass.
Re-run your code with commmit statement added. your problem may get solved.

By the way, why are we calling below mentioned execute statement in AddMovieClass when already executeUpdate() is called.

please use code tags to display java code in posts.

~ abhay

Ramesh Kumar

Ranch Hand

Posts: 42

posted 6 years ago

yes abhay and madhan are correct ,
1)you are already have ps.executeUpdate(); statement to execute your query , then why you need ps.execute(); statement ???
2)once you done with the execution part .you have to commit your changes . connection.commit() is also needed at the end .
3) i dont know what you doing with ManageConnectionClass file . if you managing your connection there . its better to close there iself .

Ramesh

SCJP,OCA

Consider Paul's rocket mass heater.

SQL Update not happening

Similar Threads