JOptionPane dialog box is not displaying

[kunagu varun]

Hello friends i am new to java programming. I am trying to develop a simple GUI based application to perform addition of two numbers.

Please have a look at my code

public void actionPerformed(ActionEvent e) {
				try
				{
					int num1,num2,res;					
					num1=Integer.parseInt(txtNum1.getText());
					num2=Integer.parseInt(txtNum2.getText());
					res=num1+num2;
					txtResult.setText(String.valueOf(res));
				}
				catch(Exception e1)
				{
					JOptionPane.showMessageDialog(null, "Please Enter Numbers", "No Numbers", JOptionPane.ERROR_MESSAGE);
					/*if((txtNum1.getText()=="")||(txtNum2.getText()==""))
					{
					
					}*/
				}
				
			}

What i am expecting is whenever a user presses on the add button and if the input numbers are not provided then a message box much appear and display the error message.
The above code works fine and the box is also displaying but I need it to appear only after checking that if condition. If I place the JoptionPane line inside that if (Yes I have removed the block comment) nothing appears.

Hope you have understood my problem. Please help me guys

[Jesper de Jong]

That is because you are using == to compare strings. The == operator compares references - in other words, it checks if the two arguments to the left and right of it refer to the exact same object. It does not compare the content of the objects.

Use equals instead:

if (txtNum1.getText().equals("") || txtNum2.getText().equals(""))

[Rajkamal Pillai]

Did you check what value is returned from txtNum1.getText() and txtNum2.getText()?

Maybe it is not having an empty String ("") and thats why the comparison is failing?

Cheers,
Raj.

[John Jai]

Jesper de Jong wrote:
Use equals instead:

if (txtNum1.getText().equals("") || txtNum2.getText().equals(""))

Use equals as said by Jong... or check whether text is of zero length

txtNum1.getText().length() == 0

[John Jai]

Raj Kamal wrote:Maybe it is not having an empty String ("") and thats why the comparison is failing?

I fear even if it returns "" it will fail if we use == for comparison

[kunagu varun]

Thank you Mr.Jesper de Jong
Worked like a charm

[Rajkamal Pillai]

Gosh! Can't believe I missed the '=='...