Forum:

Other Open Source Projects

problem with upload file using common file upload servlet

Greenhorn

Posts: 13

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Good afternoon,
I am having problem of saving an image to the /WebContent/images/ folder in my server. I think i may have missed something important in my codes , and i wonder if you all have any solution for it.

Below are my jsp code and java code

package org.minh.admin;

import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.io.PrintWriter;
import java.util.Iterator;
import java.util.List;

import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.fileupload.DefaultFileItemFactory;
import org.apache.commons.fileupload.DiskFileUpload;
import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.FileUpload;
import org.apache.commons.fileupload.FileUploadException;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;

public class CommonFileUploadServlet extends HttpServlet{
	
	 private static final String tmpDir = "c:\\tmp";
	private File tmpDirectory;
	private File destDirectory;
	
	
		
	
	protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
	    PrintWriter out = response.getWriter();
	    response.setContentType("text/plain");
	    out.println("<h1>Servlet File Upload Example using Commons File Upload</h1>");
	    out.println();
	    String contextRoot = getServletContext().getRealPath("/");
 
		DiskFileItemFactory  fileItemFactory = new DiskFileItemFactory ();
		fileItemFactory.setRepository(new File(contextRoot + "WebContent/upload/"));
		/*
		 *Set the size threshold, above which content will be stored on disk.
		 */
		fileItemFactory.setSizeThreshold(1*1024*1024); //1 MB
		/*
		 * Set the temporary directory to store the uploaded files of size above threshold.
		 */
			ServletFileUpload uploadHandler = new ServletFileUpload(fileItemFactory);
	
		try {
			/*
			 * Parse the request
			 */
			List items = uploadHandler.parseRequest(request);
			Iterator itr = items.iterator();
			while(itr.hasNext()) {
				FileItem item = (FileItem) itr.next();
				/*
				 * Handle Form Fields.
				 */
				if(item.isFormField()) {
					out.println("File Name = "+item.getFieldName()+", Value = "+item.getString());
				} else {
					//Handle Uploaded files.
					out.println("Field Name = "+item.getFieldName()+
						", File Name = "+item.getName()+
						", Content type = "+item.getContentType()+
						", File Size = "+item.getSize());
					/*
					 * Write file to the ultimate location.
					 */
					//File file = new File(dest,item.getName());
					 String fileName = item.getName();
					 File saveFile = new File("/"+fileName);        
					 saveFile.createNewFile();     
					 item.write(saveFile);

}
				out.close();
			}
		}catch(FileUploadException ex) {
			log("Error encountered while parsing the request",ex);
		} catch(Exception ex) {
			log("Error encountered while uploading file",ex);
		}
 
	}

}

Thanks for all of your help.

Tom

Paul Clapham

Marshal

Posts: 28226

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I would start by finding information about the problem. Do error messages appear? Where? What do they say? That sort of thing. Just posting a bunch of code with no information about the failure mode isn't very helpful to anybody.

Java 8 (verified skill)
Skill verified by Paul Clapham

minhdung tran

Greenhorn

Posts: 13

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Paul,
sorry for missing the information to the problem. The code did not give me any error but it did not work as it should.
I think i may miss important component since in the code, i would like it to store the image at the /WebContent/upload folder in the server, but the image was not there when i ran it.

Thanks.

Paul Clapham

Marshal

Posts: 28226

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

But here's where you write the file:

I see you have debugging code elsewhere, but I don't see any debugging code here to see whether that fileName variable does what you want.

minhdung tran

Greenhorn

Posts: 13

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Paul,

Sorry for not making myself clear. I don't know how to display the path of the file name variable

it should be at the /WebContent/Upload/image.gif as it indicated earlier in the context root and the setRepository

But it did not appear so. I think i miss some important point in my code

[code = java]
File saveFile = new File("/"+fileName);

[/code]

Thanks.

Paul Clapham

Marshal

Posts: 28226

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

minhdung tran wrote:I don't know how to display the path of the file name variable...

Wouldn't that be

?

minhdung tran

Greenhorn

Posts: 13

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Good morning,
Thanks for your help. I displayed it and it gave me the path to my file system which resided on the C drive, not the server
path as i would like the image to be stored which is under myApp/WebContent/Upload/.

Also the program ran without any error but the image never store there myApp/WebContent/Upload/.

I don't know what i did wrong. Please help me if you could.

Thanks alot!

Tom

Consider Paul's rocket mass heater.