JScrollPane within JTable cell issue

[Dinuka Arsakularatne]

Hi guy,

im having a problem with not being able to scroll inside a JTable's cell. I have a cell with JScroll pane added to it. Within that there is a JLabel representing the text to be displayed. But the horizontal scroll bar does not seem to work. Following i have added the test code i have used for this.

import java.awt.Color;
import java.awt.Component;
import java.awt.Dimension;
import java.awt.GridLayout;
import java.awt.ScrollPane;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.ComponentEvent;
import java.awt.event.ComponentListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.io.Serializable;
import java.util.EventObject;

import javax.swing.AbstractCellEditor;
import javax.swing.BorderFactory;
import javax.swing.JButton;
import javax.swing.JColorChooser;
import javax.swing.JComponent;
import javax.swing.JDialog;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.JTextArea;
import javax.swing.SwingUtilities;
import javax.swing.border.Border;
import javax.swing.event.CellEditorListener;
import javax.swing.event.ChangeEvent;
import javax.swing.event.EventListenerList;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableCellEditor;
import javax.swing.table.TableCellRenderer;

public class TableDialogEditDemo extends JPanel {
	private boolean DEBUG = false;

	public TableDialogEditDemo() {
		super(new GridLayout(1, 0));

		JTable table = new JTable(new MyTableModel());
		table.setPreferredScrollableViewportSize(new Dimension(500, 70));

		// Create the scroll pane and add the table to it.
		JScrollPane scrollPane = new JScrollPane(table);

		table.setRowHeight(50);
		
		 table.setDefaultRenderer(String.class, new TextAreaRenderer("test"));

		// Add the scroll pane to this panel.
		add(scrollPane);
	}

	class MyTableModel extends AbstractTableModel {
		private String[] columnNames = { "First Name", "Favorite Color",
				"Sport", "# of Years", "Vegetarian" };
		private Object[][] data = {
				{
						"Marysssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss",
						new Color(153, 0, 153), "Snowboarding", new Integer(5),
						new Boolean(false) },
				{ "Alison", new Color(51, 51, 153), "Rowing", new Integer(3),
						new Boolean(true) },
				{ "Kathy", new Color(51, 102, 51), "Knitting", new Integer(2),
						new Boolean(false) },
				{ "Sharon", Color.red, "Speed reading", new Integer(20),
						new Boolean(true) },
				{ "Philip", Color.pink, "Pool", new Integer(10),
						new Boolean(false) } };

		public int getColumnCount() {
			return columnNames.length;
		}

		public int getRowCount() {
			return data.length;
		}

		public String getColumnName(int col) {
			return columnNames[col];
		}

		public Object getValueAt(int row, int col) {
			return data[row][col];
		}

		/*
		 * JTable uses this method to determine the default renderer/ editor for
		 * each cell. If we didn't implement this method, then the last column
		 * would contain text ("true"/"false"), rather than a check box.
		 */
		public Class getColumnClass(int c) {
			return getValueAt(0, c).getClass();
		}

		public boolean isCellEditable(int row, int col) {
			// Note that the data/cell address is constant,
			// no matter where the cell appears onscreen.
			if (col < 1) {
				return false;
			} else {
				return true;
			}
		}

		public void setValueAt(Object value, int row, int col) {
			if (DEBUG) {
				System.out.println("Setting value at " + row + "," + col
						+ " to " + value + " (an instance of "
						+ value.getClass() + ")");
			}

			data[row][col] = value;
			fireTableCellUpdated(row, col);

			if (DEBUG) {
				System.out.println("New value of data:");
				printDebugData();
			}
		}

		private void printDebugData() {
			int numRows = getRowCount();
			int numCols = getColumnCount();

			for (int i = 0; i < numRows; i++) {
				System.out.print("    row " + i + ":");
				for (int j = 0; j < numCols; j++) {
					System.out.print("  " + data[i][j]);
				}
				System.out.println();
			}
			System.out.println("--------------------------");
		}
	}

	/**
	 * Create the GUI and show it. For thread safety, this method should be
	 * invoked from the event-dispatching thread.
	 */
	private static void createAndShowGUI() {
		// Make sure we have nice window decorations.
		JFrame.setDefaultLookAndFeelDecorated(true);

		// Create and set up the window.
		JFrame frame = new JFrame("TableDialogEditDemo");
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

		// Create and set up the content pane.
		JComponent newContentPane = new TableDialogEditDemo();
		newContentPane.setOpaque(true); // content panes must be opaque
		frame.setContentPane(newContentPane);

		// Display the window.
		frame.pack();
		frame.setVisible(true);
	}

	public static void main(String[] args) {
		// Schedule a job for the event-dispatching thread:
		// creating and showing this application's GUI.
		javax.swing.SwingUtilities.invokeLater(new Runnable() {
			public void run() {
				createAndShowGUI();
			}
		});
	}
}



class TextAreaRenderer implements TableCellRenderer {

	private String text;

	public TextAreaRenderer(String text) {
		this.text = text;
	}

	public Component getTableCellRendererComponent(JTable table, Object val,
			boolean isSelected, boolean hasFocus, int row, int column) {
		
			
			JScrollPane pane =  new JScrollPane(new JLabel((String) val));
			pane.setHorizontalScrollBarPolicy(JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);
			return pane;
		

	}
}

Any help in this regard is much appreciated guys. I even looked at the threads here and there was one issue listed here but did not have a clear answer.

[Darryl Burke]

A renderer isn't added to any visible component hierarchy and can't receive input events. What you see in a JTable's cells is the image of the renderer component.

Use a custom editor. An editor responds to input events (obviously!)

I even looked at the threads here and there was one issue listed here but did not have a clear answer.

A link to that thread might help us to help you better.

[Dinuka Arsakularatne]

Darryl Burke wrote:A renderer isn't added to any visible component hierarchy and can't receive input events. What you see in a JTable's cells is the image of the renderer component.

Use a custom editor. An editor responds to input events (obviously!)

I even looked at the threads here and there was one issue listed here but did not have a clear answer.

A link to that thread might help us to help you better.

Hi Darryl,

Thank you for the prompt response. This is the thread i looked at but could not a get a complete idea on it https://coderanch.com/t/335150/GUI/java/JScrollPane-inside-JTable-cell#1483844.

[Darryl Burke]

Note that the linked thread suggests the same solution.

Chantal Ackermann wrote:you have to write a custom TableCellEditor for this

So, problem solved?

[Dinuka Arsakularatne]

Darryl Burke wrote:Note that the linked thread suggests the same solution.

Chantal Ackermann wrote:you have to write a custom TableCellEditor for this

So, problem solved?

Hi Daryl,

Im trying it out right now. still was not successful where the horizontal scroll bar wont move. Will try more and post my findings here to find out from you guys what i am doing wrong. Thank you so much for your prompt responses. appreciate it alot.


Dinuka

[Dinuka Arsakularatne]

Hi Daryl

This is the latest example i tried out. Still no luck. Please if you have the time go through the following and let me know what im doing wrong. Your help is much appreciated.

import java.awt.Component;
import java.awt.Container;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;

import javax.swing.AbstractCellEditor;
import javax.swing.BoxLayout;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableCellEditor;
import javax.swing.table.TableCellRenderer;

public class MyTable extends JFrame {
	 private boolean DEBUG = true;
	private JTable table;

	private JScrollPane[] sp;

	private JLabel[] lbl;

	private MyTableModel model;

	public MyTable() {

		super("Table Test");

		model = new MyTableModel();

		lbl = new JLabel[model.getRowCount()];

		sp = new JScrollPane[model.getRowCount()];

		table = new JTable(model);

		table.getColumnModel().getColumn(1)
				.setCellRenderer(new MyTableRenderer());

		table.setDefaultEditor(String.class, new ScrollTableCellEditor());

		table.setRowHeight(30);

		lbl = new JLabel[model.getRowCount()];

		Container c = getContentPane();

		c.setLayout(new BoxLayout(c, BoxLayout.X_AXIS));

		c.add(table);

		setSize(220, 130);

		setVisible(true);

	}

	public static void main(String[] args) {

		MyTable test = new MyTable();

		test.addWindowListener(new WindowAdapter() {

			public void windowClosing(WindowEvent e) {

				System.exit(0);

			}

		});

	}
	

	  class MyTableModel extends AbstractTableModel {
	    private String[] columnNames = { "First Name", "Last Name", "Sport",
	        "# of Years", "Vegetarian" };

	    private Object[][] data = {
	        { "Mary", "Campionesssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss", "Snowboarding", new Integer(5),
	            new Boolean(false) },
	        { "Alison", "Huml", "Rowing", new Integer(3), new Boolean(true) },
	        { "Kathy", "Walrath", "Knitting", new Integer(2),
	            new Boolean(false) },
	        { "Sharon", "Zakhour", "Speed reading", new Integer(20),
	            new Boolean(true) },
	        { "Philip", "Milne", "Pool", new Integer(10),
	            new Boolean(false) } };

	    public int getColumnCount() {
	      return columnNames.length;
	    }

	    public int getRowCount() {
	      return data.length;
	    }

	    public String getColumnName(int col) {
	      return columnNames[col];
	    }

	    public Object getValueAt(int row, int col) {
	      return data[row][col];
	    }

	    /*
	     * JTable uses this method to determine the default renderer/ editor for
	     * each cell. If we didn't implement this method, then the last column
	     * would contain text ("true"/"false"), rather than a check box.
	     */
	    public Class getColumnClass(int c) {
	      return getValueAt(0, c).getClass();
	    }

	    /*
	     * Don't need to implement this method unless your table's editable.
	     */
	    public boolean isCellEditable(int row, int col) {
	      //Note that the data/cell address is constant,
	      //no matter where the cell appears onscreen.
	      if (col < 2) {
	        return false;
	      } else {
	        return true;
	      }
	    }

	    /*
	     * Don't need to implement this method unless your table's data can
	     * change.
	     */
	    public void setValueAt(Object value, int row, int col) {
	      if (DEBUG) {
	        System.out.println("Setting value at " + row + "," + col
	            + " to " + value + " (an instance of "
	            + value.getClass() + ")");
	      }

	      data[row][col] = value;
	      fireTableCellUpdated(row, col);

	      if (DEBUG) {
	        System.out.println("New value of data:");
	        printDebugData();
	      }
	    }

	    private void printDebugData() {
	      int numRows = getRowCount();
	      int numCols = getColumnCount();

	      for (int i = 0; i < numRows; i++) {
	        System.out.print("    row " + i + ":");
	        for (int j = 0; j < numCols; j++) {
	          System.out.print("  " + data[i][j]);
	        }
	        System.out.println();
	      }
	      System.out.println("--------------------------");
	    }
	  }

	public class MyTableRenderer implements TableCellRenderer {

		public Component getTableCellRendererComponent(JTable table,

		Object value,

		boolean isSelected,

		boolean hasFocus,

		int row,

		int column) {

			

				lbl[row] = new JLabel((String) value);

			

			if (sp[row] == null) {

				sp[row] = new JScrollPane(lbl[row]);

			} else {

				sp[row].setViewportView(lbl[row]);

			}

			return sp[row];

		}

	}

	public class ScrollTableCellEditor extends AbstractCellEditor implements
			TableCellEditor {

		public Component getTableCellEditorComponent(JTable table,
				Object value,

				boolean isSelected, int r, int c) {

			return sp[r];

		}

		@Override
		public Object getCellEditorValue() {
			// TODO Auto-generated method stub
			return null;
		}

	}

}

[Dinuka Arsakularatne]

Found the answer guys. This is a working example of scrollable table data cell;

import java.awt.Component;
import java.awt.Container;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;

import javax.swing.AbstractCellEditor;
import javax.swing.BoxLayout;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.JTextArea;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableCellEditor;
import javax.swing.table.TableCellRenderer;

public class MyTable extends JFrame {
	 private boolean DEBUG = true;
	private JTable table;

	private JScrollPane[] sp;

	private JLabel[] lbl;

	private MyTableModel model;
	
	private JScrollPane ss;


	public MyTable() {

		super("Table Test");

		model = new MyTableModel();

		lbl = new JLabel[model.getRowCount()];

		sp = new JScrollPane[model.getRowCount()];

		table = new JTable(model);

		table.getColumnModel().getColumn(1)
				.setCellRenderer(new MyTableRenderer());
	
		table.getColumnModel().getColumn(1).setCellEditor(new ScrollTableCellEditor());
	
		
		table.setRowHeight(30);

		lbl = new JLabel[model.getRowCount()];

		Container c = getContentPane();

		c.setLayout(new BoxLayout(c, BoxLayout.X_AXIS));

		c.add(table);

		setSize(220, 130);

		setVisible(true);

	}

	public static void main(String[] args) {

		MyTable test = new MyTable();

		test.addWindowListener(new WindowAdapter() {

			public void windowClosing(WindowEvent e) {

				System.exit(0);

			}

		});

	}
	

	  class MyTableModel extends AbstractTableModel {
	    private String[] columnNames = { "First Name", "Last Name", "Sport"};

	    private Object[][] data = {
	        { "Mary", "Campionesssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss", "Snowboarding" }};

	    public int getColumnCount() {
	      return columnNames.length;
	    }

	    public int getRowCount() {
	      return data.length;
	    }

	    public String getColumnName(int col) {
	      return columnNames[col];
	    }

	    public Object getValueAt(int row, int col) {
	    	val = (String)data[row][col];
	      return data[row][col];
	    }

	    /*
	     * JTable uses this method to determine the default renderer/ editor for
	     * each cell. If we didn't implement this method, then the last column
	     * would contain text ("true"/"false"), rather than a check box.
	     */
	    public Class getColumnClass(int c) {
	      return getValueAt(0, c).getClass();
	    }

	    /*
	     * Don't need to implement this method unless your table's editable.
	     */
	    public boolean isCellEditable(int row, int col) {
	     
	        return true;
	 
	    }

	    /*
	     * Don't need to implement this method unless your table's data can
	     * change.
	     */
	    public void setValueAt(Object value, int row, int col) {
	      if (DEBUG) {
	        System.out.println("Setting value at " + row + "," + col
	            + " to " + value + " (an instance of "
	            + value.getClass() + ")");
	      }

	      data[row][col] = value;
	      fireTableCellUpdated(row, col);

	      if (DEBUG) {
	        System.out.println("New value of data:");
	        printDebugData();
	      }
	    }

	    private void printDebugData() {
	      int numRows = getRowCount();
	      int numCols = getColumnCount();

	      for (int i = 0; i < numRows; i++) {
	        System.out.print("    row " + i + ":");
	        for (int j = 0; j < numCols; j++) {
	          System.out.print("  " + data[i][j]);
	        }
	        System.out.println();
	      }
	      System.out.println("--------------------------");
	    }
	  }

	public class MyTableRenderer implements TableCellRenderer {

		public Component getTableCellRendererComponent(JTable table,

		Object value,

		boolean isSelected,

		boolean hasFocus,

		int row,

		int column) {

			
		

				lbl[row] = new JLabel((String) value);
			
			

			if (sp[row] == null) {

				sp[row] = new JScrollPane(lbl[row]);

			} else {

				sp[row].setViewportView(lbl[row]);

			}

		
			return sp[row];
		
		}

	}

	public class ScrollTableCellEditor extends AbstractCellEditor implements
			TableCellEditor {
		

		private String val;
		
		public Component getTableCellEditorComponent(JTable table,
				Object value,

				boolean isSelected, int r, int c) {
			this.val = (String)value;
			return sp[r];
		//	return ss;

		}

		@Override
		public Object getCellEditorValue() {
		
			return val;
		}

	}

}