How to put image on JPanel

[Filip Stirn]

Hy

Can you tell me how to put an image to JPanel.

I tried this but it don't work

import java.awt.*;
import javax.swing.*;

public class Slika{
    
    MyDrawPanel draw;

    public static void main(String[] args){
        new Slika().go();
    }
    
    public void go(){
        JFrame frame=new JFrame("slika");
        JPanel panel=new JPanel();
        draw=new MyDrawPanel();
        frame.getContentPane().add(BorderLayout.CENTER,draw);
        frame.setSize(300,300);
        frame.setVisible(true);
        
    }
    public class MyDrawPanel extends JPanel{
        public void paintComponent(Graphics g){
            Image image=new ImageIcon("raptor.jpeg").getImage();
            g.drawImage(image,3,4,this);
        }
    }
}

btw raptor.jpeg is in C:raptor.jpeg and the .java is in C:/users/accountName/eclipse/picture/src/picture.java

[Paul Clapham]

Your code looks for the image in the current working directory. Try specifying the full path to the image.

And don't read the image in the paintComponent method. That method is called very frequently. Read the image in your initialization code and just draw it in the paintComponent method.

[Filip Stirn]

Can you tell me which path sould I write? I tried everything that comes on my mind but still without sucess.
As I mentioed before the picture is here C:/raptor.jpeg and the .java is in C:/users/accountName/eclipse/picture/src/picture.java

[Maneesh Godbole]

new ImageIcon(//point to the image you want to load)

[Paul Clapham]

Filip Stirn wrote:Can you tell me which path sould I write? I tried everything that comes on my mind but still without sucess.
As I mentioed before the picture is here C:/raptor.jpeg and the .java is in C:/users/accountName/eclipse/picture/src/picture.java

How is it that you didn't try "C:/raptor.jpeg" then?

Or perhaps your problem is not that the image isn't found, but something else. I did notice that you didn't describe your problem at all.

[Filip Stirn]

Paul Clapham wrote:

Filip Stirn wrote:Can you tell me which path sould I write? I tried everything that comes on my mind but still without sucess.
As I mentioed before the picture is here C:/raptor.jpeg and the .java is in C:/users/accountName/eclipse/picture/src/picture.java

How is it that you didn't try "C:/raptor.jpeg" then?

Or perhaps your problem is not that the image isn't found, but something else. I did notice that you didn't describe your problem at all.

I tried that but still when I launch programm it just shows JFrame with JPanel but without picture

[Campbell Ritchie]

I think this discussion would sit better on the GUIs forum. Moving.

[Paul Clapham]

I don't see where you set the preferred size of your DrawPanel, so perhaps it's zero. You can test where a component is and how big it is by putting a Border around it. A LineBorder would do perfectly well.

[Filip Stirn]

It still don't work. Can someone just please try my code, fill in what is wrong or missing and then paste the working code here?

[Maneesh Godbole]

Did you move the image reading part out of the paint component like Paul said? Can you show us your latest code?

[Paul Clapham]

Filip Stirn wrote:It still don't work. Can someone just please try my code, fill in what is wrong or missing and then paste the working code here?

Nope. We aren't here to do your work for you.

So tell us, what exactly did you see when you drew a thick red border around your panel?

[Filip Stirn]

My code:

import java.awt.*;
import javax.swing.*;

public class Slika{
    
	Image image;
    MyDrawPanel draw;

    public static void main(String[] args){
        new Slika().go();
    }
    
    public void go(){
        JFrame frame=new JFrame("slika");
        JPanel panel=new MyDrawPanel();
        panel.setSize(100,100);
        image=new ImageIcon("C:/raptor.jpeg").getImage();
        frame.getContentPane().add(BorderLayout.CENTER,panel);
        frame.setSize(300,300);
        frame.setVisible(true);
        
    }
    public class MyDrawPanel extends JPanel{
        public void paintComponent(Graphics g){
            g.drawImage(image,3,4,this);
        }
    }
}

I don't know how to set border around picture. And the only thing I see when i launch this program is JFrame.

[Rob Spoor]

Setting the size of your panel does nothing - the frame's content pane's BorderLayout ignores it. You should set the preferred size instead, as that's being used by most layout managers.

As for the border, you can always give your panel itself a border, using its setBorder method.

[Filip Stirn]

Rob Spoor wrote:Setting the size of your panel does nothing - the frame's content pane's BorderLayout ignores it. You should set the preferred size instead, as that's being used by most layout managers.

As for the border, you can always give your panel itself a border, using its setBorder method.

import java.awt.*;
import javax.swing.*;


public class Slika{
    
	Color color;
	Image image;
    MyDrawPanel draw;
    

    public static void main(String[] args){
        new Slika().go();
    }
    
    public void go(){
        JFrame frame=new JFrame("slika");
        JPanel panel=new MyDrawPanel();
        Dimension dimension=new Dimension();
        dimension.setSize(100,100);
        panel.setPreferredSize(dimension);
        image=new ImageIcon("C:/raptor.jpeg").getImage();
        frame.getContentPane().add(BorderLayout.CENTER,panel);
        frame.setSize(300,300);
        frame.setVisible(true);
        
    }
    public class MyDrawPanel extends JPanel{
        public void paintComponent(Graphics g){
            g.drawImage(image,3,4,this);
        }
    }
}

I guess I should give up cause I'm just to dumb for this

[Randall Twede]

i dont know if this will help but:
first, i would copy or move the image file to the same folder as the java code. then you can just use its name.
second, i cant remember why but i learned or was taught that the first line of code in your paintComponent method should be super.paintComponent():

[Rob Spoor]

After adding the super.paintComponent(g) as Randall suggested, that code works for me. So what's it not doing that you think it should?