another head first beatbox question

[michael dej]

in the book the beat-box is limited to only allowing one save as the file name is hard coded into the file out put stream. I have been trying to put in a file chooser so you can save more then one file; so far i can get the file chooser to open and save a file but i cannot retrieve the file information (the checkbox state that i want to save)

need some help here below is the code

import java.awt.*;
import javax.swing.*;
import java.io.*;
import javax.sound.midi.*;
import java.util.*;
import java.awt.event.*;

public class BeatBoxSaveOnly {  // implements MetaEventListener 
    JPanel mainPanel;
    ArrayList<JCheckBox> checkboxList;
    // int bpm = 120;
    Sequencer sequencer;
    Sequence sequence;
    Sequence mySequence = null;
    Track track;
    JFrame theFrame;

    String[] instrumentNames = {"Bass Drum", "Closed Hi-Hat", 
            "Open Hi-Hat","Acoustic Snare", "Crash Cymbal", "Hand Clap", 
            "High Tom", "Hi Bongo", "Maracas", "Whistle", "Low Conga", 
            "Cowbell", "Vibraslap", "Low-mid Tom", "High Agogo", 
            "Open Hi Conga"};
    int[] instruments = {35,42,46,38,49,39,50,60,70,72,64,56,58,47,67,63};

    public static void main (String[] args) {
        new BeatBoxSaveOnly().buildGUI();
    }

    public void buildGUI() {
        theFrame = new JFrame("Cyber BeatBox");
        theFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        BorderLayout layout = new BorderLayout();
        JPanel background = new JPanel(layout);
        background.setBorder(BorderFactory.createEmptyBorder(10,10,10,10));

        checkboxList = new ArrayList<JCheckBox>();
        Box buttonBox = new Box(BoxLayout.Y_AXIS);

        JButton start = new JButton("Start");
        start.addActionListener(new MyStartListener());
        buttonBox.add(start);

        JButton stop = new JButton("Stop");
        stop.addActionListener(new MyStopListener());
        buttonBox.add(stop);

        JButton upTempo = new JButton("Tempo Up");
        upTempo.addActionListener(new MyUpTempoListener());
        buttonBox.add(upTempo);

        JButton downTempo = new JButton("Tempo Down");
        downTempo.addActionListener(new MyDownTempoListener());
        buttonBox.add(downTempo);

        JButton saveIt = new JButton("Serialize It");  // new button
        saveIt.addActionListener(new MySendListener());
        buttonBox.add(saveIt);

        JButton restore = new JButton("Restore");     // new button
        restore.addActionListener(new MyReadInListener());
        buttonBox.add(restore);

        Box nameBox = new Box(BoxLayout.Y_AXIS);
        for (int i = 0; i < 16; i++) {
            nameBox.add(new Label(instrumentNames[i]));
        }

        background.add(BorderLayout.EAST, buttonBox);
        background.add(BorderLayout.WEST, nameBox);

        theFrame.getContentPane().add(background);

        GridLayout grid = new GridLayout(16,16);
        grid.setVgap(1);
        grid.setHgap(2);
        mainPanel = new JPanel(grid);
        background.add(BorderLayout.CENTER, mainPanel);

        for (int i = 0; i < 256; i++) {                    
            JCheckBox c = new JCheckBox();
            c.setSelected(false);
            checkboxList.add(c);
            mainPanel.add(c);            
        } // end loop

        setUpMidi();

        theFrame.setBounds(50,50,300,300);
        theFrame.pack();
        theFrame.setVisible(true);
    } // close method

    public void setUpMidi() {
        try {
            sequencer = MidiSystem.getSequencer();
            sequencer.open();
            // sequencer.addMetaEventListener(this);
            sequence = new Sequence(Sequence.PPQ,4);
            track = sequence.createTrack();
            sequencer.setTempoInBPM(120);

        } catch(Exception e) {e.printStackTrace();}
    } // close method
    /*
    public class MyCheckBoxListener implements ItemListener {
    public void itemStateChanged(ItemEvent ev) {      
    // might add real-time removal or addition, probably not because of timing
    }
    } // close inner class
     */

    public void buildTrackAndStart() {
        // this will hold the instruments for each vertical column,
        // in other words, each tick (may have multiple instruments)
        int[] trackList = null;

        sequence.deleteTrack(track);
        track = sequence.createTrack();

        for (int i = 0; i < 16; i++) {
            trackList = new int[16];

            int key = instruments[i];

            for (int j = 0; j < 16; j++ ) {         
                JCheckBox jc = (JCheckBox) checkboxList.get(j + (16*i));

                if ( jc.isSelected()) {
                    trackList[j] = key;
                } else {
                    trackList[j] = 0;
                }       
            } // close inner

            makeTracks(trackList);
        } // close outer

        track.add(makeEvent(192,9,1,0,15)); // - so we always go to full 16 beats 

      
        try {

            sequencer.setSequence(sequence);  
            sequencer.setLoopCount(sequencer.LOOP_CONTINUOUSLY);                  
            sequencer.start();
            sequencer.setTempoInBPM(120);
        } catch(Exception e) {e.printStackTrace();}

    } // close method

    //============================================================== inner class listeners           

    public class MyStartListener implements ActionListener {
        public void actionPerformed(ActionEvent a) {
            buildTrackAndStart();
        }
    }

    public class MyStopListener implements ActionListener {
        public void actionPerformed(ActionEvent a) {
            sequencer.stop();
        }
    }

    public class MyUpTempoListener implements ActionListener {
        public void actionPerformed(ActionEvent a) {
            float tempoFactor = sequencer.getTempoFactor();
            sequencer.setTempoFactor((float)(tempoFactor * 1.03));
        }
    }

    public class MyDownTempoListener implements ActionListener {
        public void actionPerformed(ActionEvent a) {
            float tempoFactor = sequencer.getTempoFactor();
            sequencer.setTempoFactor((float)(tempoFactor * .97));
        }
    }

    public class MySendListener implements ActionListener {    // new - save
        public void actionPerformed(ActionEvent a) {
            // make an arraylist of just the STATE of the checkboxes
            boolean[] checkboxState = new boolean[256];

            JFileChooser saveFile = new JFileChooser();
            saveFile.showSaveDialog(theFrame);
            fileSaved (saveFile.getSelectedFile());

            for (int i = 0; i < 256; i++) {
                JCheckBox check = (JCheckBox) checkboxList.get(i);
                if (check.isSelected()) {
                    checkboxState[i] = true;
                }
            }

        } // close method
    } // close inner class


    public class MyReadInListener implements ActionListener {  // new - restore
        public void actionPerformed(ActionEvent a) {
            // read in the thing

            boolean[] checkboxState = null;
            JFileChooser fileOpen = new JFileChooser();
            fileOpen.showOpenDialog(theFrame);

            


            // now stop sequence and restart
            sequencer.stop(); 
            buildTrackAndStart();
        } // close method
    } // close inner class
    public void fileSaved (File file) {
        boolean[] checkboxState = new boolean[256];
        for (int i = 0; i < 256; i++) {
            JCheckBox check = (JCheckBox) checkboxList.get(i);
            if (check.isSelected()) {
                checkboxState[i] = true;
            }
        }
        try {
            FileOutputStream fileStream = new FileOutputStream( new File( file +".ser"));
            ObjectOutputStream os = new ObjectOutputStream(fileStream);
            os.writeObject(checkboxState);
        } catch(Exception ex) {
            ex.printStackTrace();
        }
        
    }

    public void fileOpen (File file) {
         // read in the thing

          boolean[] checkboxState = null;
         
          try {
            FileInputStream filestream = new FileInputStream (new File (file + ".ser"));
            ObjectInputStream is = new ObjectInputStream(filestream);
            checkboxState = (boolean[]) is.readObject();
            
            } catch (Exception ex) { ex.printStackTrace();  }
       
              // now reset the sequence to be this
          for (int i = 0; i < 256; i++) {
             JCheckBox check = (JCheckBox) checkboxList.get(i);
             if (checkboxState[i]) {
                check.setSelected(true);
             } else {
                check.setSelected(false);
             }
         } 
         
      } // close method
        
    

        //==============================================================       

        public void makeTracks(int[] list) {

            for (int i = 0; i < 16; i++) {
                int key = list[i];

                if (key != 0) {
                    track.add(makeEvent(144,9,key, 100, i));
                    track.add(makeEvent(128,9,key, 100, i + 1));
                }
            }
        }


        public  MidiEvent makeEvent(int comd, int chan, int one, int two, int tick) {
            MidiEvent event = null;
            try {
                ShortMessage a = new ShortMessage();
                a.setMessage(comd, chan, one, two);
                event = new MidiEvent(a, tick);

            }catch(Exception e) { }
            return event;
        }

        /*
        public void meta(MetaMessage message) {
        if (message.getType() == 47) {
        sequencer.start();
        sequencer.setTempoInBPM(bpm);
        }
        }
         */

    } // close class
        
          
          

[Campbell Ritchie]

Welcome to the Ranch

Are you clicking the "approve" or "yes" button on the file chooser? If so, the showSaveDialog method has an int return type. Shouldn't you check that against the constants in the file Chooser class, something like this?

if (saveFile.showSaveDialog(myFrame) == JFileChooser.APPROVE_OPTION)
{
   ...
}

Also your next if isn't quite right. You should beware of if (b) b2 = true; and the version with if-else is even worse. You do sometimes really need if (b) b2 = true;, but I suspect not here. What is happening is that you are gradually setting the check boxes to true and never setting them to false. Try something like

/* Probably belongs inside the previous "if" */
for (int i = 0; i < checkboxState.length; i++)
{
   JCkeckBox check = checklist.get(i);
   checkboxState[i] = check.isSelected();
}

You will notice an if has gone, and so has the cast. Since you have given the List an actual type parameter of JCheckBox, there is no need for any casting. Always use parameterised types, to avoid casting, because casts are nasty, error-prone things. I have also taken the 256 out. Number literals like that (called "magic numbers") are error-prone when used on arrays.

[Campbell Ritchie]

I earlier wrote:. . . Try something like

/* Probably belongs inside the previous "if" */
for (int i = 0; i < checkboxState.length; i++)
{
   JCkeckBox check = checklist.get(i);
   checkboxState[i] = check.isSelected();
}

. . .

. . . which can be abbreviated to
checkboxState[i] = checkList.get(i).isSelected();
But you must always ensure the array and the list are the same size. Maybe two arrays, declared as final , instead, so they will always be the same size??

[michael dej]

ok and these are going to into the fileSaved of fileOpen?

i know it's probably a silly question. i'll try this but the problem i get is i don't think it's saving correctly, as any changes i make after are still there when i restore (ex ample i uncheck several boxes, and restore because i don't like the change the file appears to open(no errors) but nothing changes)


{edit} i just put the code you suggested in the file save part, and still have the same issue. it must a save issue not writing the checkbox state (at leat that's my current thinking)


here is the original way it way saved

 public class MySendListener implements ActionListener {    // new - save
       public void actionPerformed(ActionEvent a) {
          // make an arraylist of just the STATE of the checkboxes
         boolean[] checkboxState = new boolean[256];

         for (int i = 0; i < 256; i++) {
             JCheckBox check = (JCheckBox) checkboxList.get(i);
             if (check.isSelected()) {
                checkboxState[i] = true;
             }
          }

         try {
            FileOutputStream fileStream = new FileOutputStream(
                new File("Checkbox.ser"));
            ObjectOutputStream os = new ObjectOutputStream(fileStream);
            os.writeObject(checkboxState);
         } catch(Exception ex) {
             ex.printStackTrace();
         }

       } // close method
     } // close inner class



    public class MyReadInListener implements ActionListener {  // new - restore
        public void actionPerformed(ActionEvent a) {
          // read in the thing

          boolean[] checkboxState = null;
          try {
              FileInputStream fileIn = new FileInputStream(
                  new File("Checkbox.ser"));
              ObjectInputStream is = new ObjectInputStream(fileIn);
              checkboxState = (boolean[]) is.readObject();

          } catch(Exception ex) {ex.printStackTrace();}

              // now reset the sequence to be this
          for (int i = 0; i < 256; i++) {
             JCheckBox check = (JCheckBox) checkboxList.get(i);
             if (checkboxState[i]) {
                check.setSelected(true);
             } else {
                check.setSelected(false);
             }
         } 

       

        // now stop sequence and restart
        sequencer.stop(); 
        buildTrackAndStart();
      } // close method
  } // close inner class

this way worked fine but now i want to incorporate a file chooser option

[Campbell Ritchie]

Doesn't matter what you do with those values at this stage. Get the values, print out all the values in the array, and then you will have some idea whether it works. Then consider the next stage, of printing the values in a file.

You want to program only a few lines at a time, get them working, then write a few more lines.

[michael dej]

it is part of the file retrieval i set a print when i saved and when i opened a file the save gave me the boolean states,whereas the open gave back nothing at all

[michael dej]

ok i figured it out, finally

[Campbell Ritchie]

Well done

. . . but how did you sort it out?

[michael dej]

i swapped the for and try parts under save, and i took out the ".ser" under the file stream for both.


the problem i have now is i get no file extension when i save, that i haven't figured out yet

    public class MySendListener implements ActionListener {    // new - save
        public void actionPerformed(ActionEvent a) {
            // make an arraylist of just the STATE of the checkboxes
     

            JFileChooser saveFile = new JFileChooser();
            saveFile.showSaveDialog(theFrame);
            fileSaved (saveFile.getSelectedFile());

            
        } // close method
    } // close inner class

    public class MyReadInListener implements ActionListener {  // new - restore
        public void actionPerformed(ActionEvent a) {
            // read in the thing

            JFileChooser fileOpen = new JFileChooser();
            fileOpen.showOpenDialog(theFrame);
            openfile(fileOpen.getSelectedFile());
            // now stop sequence and restart
            sequencer.stop(); 
            buildTrackAndStart();
        } // close method
    } // close inner class
    public void fileSaved (File file) {
        boolean[] checkboxState = new boolean[256];
         for (int i = 0; i < 256; i++) {
             JCheckBox check = (JCheckBox) checkboxList.get(i);
             if (check.isSelected()) {
                checkboxState[i] = true;
             }
             
          }
        try {
            FileOutputStream fileStream = new FileOutputStream( new File( file +" "));
            ObjectOutputStream os = new ObjectOutputStream(fileStream);
            os.writeObject(checkboxState);
        } catch(Exception ex) {
            ex.printStackTrace();
        }
        

    }

    public void openfile (File file) {
        // read in the thing

        boolean[] checkboxState = null;

        try {
            FileInputStream filestream = new FileInputStream (new File (file + " " ));
            ObjectInputStream is = new ObjectInputStream(filestream);
            checkboxState = (boolean[]) is.readObject();

        } catch (Exception ex) { ex.printStackTrace();  }
        // now reset the sequence to be this
        for (int i = 0; i < 256; i++) {
            JCheckBox check = (JCheckBox) checkboxList.get(i);
            if (checkboxState[i]) {
                check.setSelected(true);
            } else {
                check.setSelected(false);
            }
           
        } 

    } // close method