Forum:

Struts

Form Validation using xml in struts2

Ranch Hand

Posts: 51

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hello all,

I am trying to develop an app using struts which has form with fields. I am validating the fields using the validation xml, but its not showing any error while some of the fields are empty.. Could anyone help me to find a loophole in my app, I am new to Struts, any help is greatly appreciated...

Following are the codes in my app,

My initial page with form,

My validation xml named LoginAction-Validation.xml,

My action class..

package struts2;
import com.opensymphony.xwork2.ActionSupport;

public class LoginAction extends ActionSupport {
	private static final long serialVersionUID = 1L;
	
	private String username;
	private String password;
	
	public String execute()  {
		
		 if(this.username.equals("admin") && this.password.equals("test")){
//			 addActionMessage("Successfully logged in!!");
			 return "success";
		 }
//		 else if(this.username.equals("") && this.password.equals("")){
//		
//			 
//			 return "empty";
//		 }
//		 else if(this.username.equals("")){
//			
//			 return "empty";
//		 }
//		 else if(this.password.equals("")){
//			
//			 return "empty";
//		 }
//		
		 else{
//			 addActionError("Invalid User!!");
			 return "error";
		 }
//		 return "success" ;
		 
	}
	
//	public void validate(){
//		if(getUsername().length() == 0){
//			addFieldError("username","User name is required" );
//		}
//		else if(!getUsername().equals("admin")){
//			addFieldError("username","Invalid user" );
//		}
//		if(getPassword().length() == 0){
//			addFieldError("password","Password is required" );
//		}
//	}

public String getUsername() {
		return username;
	}

public void setUsername(String username) {
		this.username = username;
	}

public String getPassword() {
		return password;
	}

public void setPassword(String password) {
		this.password = password;
	}

}

My struts.xml is the following...

Thanks and regards,
hemanth.

Ravindra B Pawar

Greenhorn

Posts: 9

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

CORRECT CODE

you have not specified the action class name

OR BETTER WAY IS TO

CHANGE THIS TO

i think you getting the point

hope this helps

hemanth acharya

Ranch Hand

Posts: 51

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Ravindra,

Thanks for the response,

I have done the changes you mentioned, its still not checking the validation xml to get the errors while the fields in the form is empty.

regards,
hemanth.

Ravindra B Pawar

Greenhorn

Posts: 9

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

The problem with your code was you were displaying the login jsp page (for first time visit to page) for that you created one dummy action login
Then you were submitting the for to same login action which was simply displaying the form again

if you submit form to the new action which will process your form and corresponding xml should be referred for the validations

for more info you can see code at
http://www.vaannila.com/struts-2/struts-2-example/struts-2-validation-using-xml-example-1.html

hemanth acharya

Ranch Hand

Posts: 51

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Ravindra,

I solved the problem...
The changes you mentioned, I had corrected, along with that i added a property file name struts.properties in which i included the constant,

where 'LoginAction' is my property file containing all the variables, eg..

regards,
hemanth.

Ravindra B Pawar

Greenhorn

Posts: 9

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Hemanth,

I have never used this property files.
Can you please show me how is you directory strutcture so that i can understand where to put
struts.PROPERTIES
LoginAction.PROPERTIES

Thanks,
Ravi

hemanth acharya

Ranch Hand

Posts: 51

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Ravindra,

I created a new source folder for the project called 'resources' and places in that... Please find the attached image.

regards,
hemanth.

directory-structure.GIF

Ravindra B Pawar

Greenhorn

Posts: 9

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Thanks for quick reply.

It really good idea to create new folder called resources to put these things like struts.xml and properties file.

Do you have any idea if we can put the LoginAction-validation.xml in resources folder or it has to be there with the source file LoginAction.java?

Thanks

hemanth acharya

Ranch Hand

Posts: 51

posted 13 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Ravindra,

Conventional, the 'action' and the 'validation xml' for the same should be in one folder...
I think it wont be found if its placed in 2 different folders..

regards,
hemanth.

There are 29 Knuts in one Sickle, and 17 Sickles make up a Galleon. 42 tiny ads in a knut:

New web page for Paul's Rocket Mass Heaters movies

https://coderanch.com/t/785239/web-page-Paul-Rocket-Mass