Issue in annotating DAO using spring 3.0

[Ankit Chandrawat]

Hi,

I am using Spring 3.0+Hibernate in my application. This is the error I am getting while I try to annotate my DAO class.

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'chatSessionBO': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.mercer.chat.app.dao.ChatSessionDAO com.mercer.chat.app.businessmodel.ChatSessionBO.chatSessionDAO; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'chatSessionDAO' defined in file [D:\opt\jboss-4.0.3SP1\server\mercerhr\deploy\mercerhr.ear\mercer.war\WEB-INF\classes\com\mercer\chat\app\dao\ChatSessionDAO.class]: Invocation of init method failed; nested exception is java.lang.IllegalArgumentException: 'sessionFactory' or 'hibernateTemplate' is required

@Repository("chatSessionDAO")
public class ChatSessionDAO extends MercerDAO{
	
	public List retrieveSessionInfo(ChatSessionQO chatSessionQO) throws MercerException {
		List lstReturn = null;
		try {
			Criteria criteria = getCriteria(chatSessionQO);
			if(criteria!=null) {
				lstReturn = processQuery(criteria);
			}
			
		}
		 catch (Exception e) {
				log.error("error :::" , e);
				throw new MercerException("No transaction");
			}
		 return lstReturn;
	}
	
	protected Criteria getCriteria(ChatSessionQO chatSessionQO) throws MercerException {
		Criteria cr = null;
		int chatSessionId = chatSessionQO.getChatSessionId();
		String chatSessionIdString = Integer.toString(chatSessionId);
		cr = createCriteria(chatSessionIdString);
		return cr;
	}
	private Criteria createCriteria(String chatSessionIdString) throws MercerException {
		Criteria cr = null;
		log.info("creating criteria");
		try {
			HibernateTemplate hibernateTemplate = getHibernateTemplate();
			Session session = hibernateTemplate.getSessionFactory().getCurrentSession();
			log.info("creating criteria for event listing");
			cr = session.createCriteria(MHRContChatSessionDO.class, "chatSession").add(Restrictions.eq("id", chatSessionIdString));
			return cr;
		} catch (HibernateException e) {
			throw convertToMercerException(e);
		}
		
	}
	protected List processQuery(Criteria criteria) throws MercerException {
		List lstReturn = null;
		if (criteria != null) {
			try {
				// set cache to true
				criteria.setCacheable(true);
				// execute query
				lstReturn = criteria.list();
			} catch (Exception e) {
				log.error("exception" + e);
				throw convertToMercerException(e);
			}
		}
		return lstReturn;
	}

}

public abstract class MercerDAO extends HibernateDaoSupport {

	/** Logger for this class. */
	public final static Logger log = Logger.getLogger(MercerDAO.class);
	
	
	public static Logger getLog() {
		return log;
	}

	
	public MercerException convertToMercerException(Exception e) {
		log.error("IN ConvertTOMercerException : ", e);
		MercerException me = new MercerException(e.getMessage());
		me.addError(e.getMessage());

		if (e instanceof MercerException) {
			me = (MercerException) e;
		}

		
		if (me.getErrorCode().contains("ORA-16000") && (!DatabaseFailoverService.isFlgReadOnly())) {
			//DatabaseFailoverService.flgReadOnly = true;			
			DatabaseFailoverService.setFlgReadOnly(true);					
		}
		
		// R1_10@PS : V2M : Added error code of read only database : END
		return me;
	}

	
	public List executeFind(final String namedQuery, final String[] paramNames, final Object[] values,
			final ResultTransformer resultTransformer, final int firstResult, final int maxResult)
			throws DataAccessException {

		HibernateTemplate hibernateTemplate = getHibernateTemplate();

		//TODO : @NSS : Tweak for cache.
		// Purposefully cahche false because of ResultTransformer
		if (null != resultTransformer) {
			hibernateTemplate.setCacheQueries(false);
		} else {
			hibernateTemplate.setCacheQueries(true);
		}

		if (paramNames != null && values != null && paramNames.length != values.length) {
			throw new IllegalArgumentException("Length of paramNames array must match length of values array");
		}

		// Implementing Hibernate Callback
		return hibernateTemplate.executeFind(new HibernateCallback() {

			
			public Object doInHibernate(Session session) throws HibernateException {
				Query queryObject = session.getNamedQuery(namedQuery);
				if (values != null) {
					for (int i = 0; i < values.length; i++) {
						queryObject.setParameter(paramNames[i], values[i]);
					}
				}
				if (firstResult > 0) {
					queryObject.setFirstResult(firstResult);
				}

				if (maxResult > 0) {
					queryObject.setMaxResults(maxResult);
				}
				//R1_07@NSS : BugFix - Avoid Null Pointer : Feb 21, 2008 : Start
				if (null != resultTransformer) {
					queryObject.setResultTransformer(resultTransformer);
				}
				//R1_07@NSS : BugFix - Avoid Null Pointer : Feb 21, 2008 : End
				return queryObject.list();
			}
		});

	}

	
	public List executeFind(final String namedQuery, final String[] paramNames, final Object[] values,
			final ResultTransformer resultTransformer) throws DataAccessException {
		return executeFind(namedQuery, paramNames, values, resultTransformer, 0, 0);
	}
	public Query createQuery(final String queryString) throws DataAccessException {
		HibernateTemplate hibernateTemplate = getHibernateTemplate();

		return (Query) hibernateTemplate.execute(new HibernateCallback() {

			
			public Object doInHibernate(Session session) {
				return session.createQuery(queryString);
			}
		});
	}

}

@Component("chatSessionBO")
public class ChatSessionBO {

	@Autowired
	@Qualifier("chatSessionDAO")
	private ChatSessionDAO chatSessionDAO;

	public String registerUserForEmailAlerts(ChatSessionQO chatSessionQO) throws MercerException {
		MHRContChatSessionDO chatSessionDO = null;
		MHRContChatAlertsDO chatAlerts = null;
		String chatSessionIndicator = null;
		List<MHRContChatSessionDO> chatSessionList = chatSessionDAO.retrieveSessionInfo(chatSessionQO);
		if(!CollectionUtil.isEmpty(chatSessionList)) {
			Iterator it = chatSessionList.iterator();
			while(it.hasNext()) {
				chatSessionDO =(MHRContChatSessionDO) it.next();
				 chatAlerts = (MHRContChatAlertsDO) chatSessionDO.getChatAlerts();
				 if(!chatAlerts.equals(null)) {
					 chatSessionIndicator = ChatSessionConstantsIF.USER_ALREADY_REGISTERED;
				 }
			}
		}
		return chatSessionIndicator;
		
	}
}

[paul nisset]

Hi ,
I'd look at how your components are accessng the Hibernate Session.

After brief look, it appears that retrieveSessionInfo() in ChatSessionDAO
is used by ChatSessionBO but ChatSessionDAO dosn't have a Session with it despite using a Hibernate Criteria .

That's my best guess.

-Paul

[Ankit Chandrawat]

Thanks for the reply Paul. Any ideas how can I make sure that I get the Session ?

[paul nisset]

MercerDAO needs a HibernateTemplate to be set.
Perhaps move the HibernateTemplate in that class's excecuteFind() method to a class level private variable .
You could then set it in the Spring config file via injection.

Alternatively, if you pass in a HibernateSession via the constructor or injection ,it will create a default HibernateTemplate for you.

Check this out:

http://static.springsource.org/spring/docs/1.2.9/api/org/springframework/orm/hibernate/support/HibernateDaoSupport.html

Hope this helps,
Paul

[Ankit Chandrawat]

I just checked something out :

In our application the DAO now are being injected like this. Foe example the ServicesPageDAO, this DAO also extends MercerDAO.
So that implies, what is being done by using xml, needs to be done using annotations. I need to inject sessionFactory that is referring mySessionFactory. How do I inject this mySessionFactory using annotations.

<bean id="servicesPageDAO"
		class="com.mercer.app.persistentservice.servicepagespersistentservice.servicespagedao.ServicesPageDAO">
		<property name="sessionFactory">
			<ref bean="mySessionFactory" />
		</property>
	</bean>

<bean id="mySessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
		<!-- TODO: @NSS : can we map folder itself ? like <value>classpath:/com/mercer/content</value> -->
		<property name="mappingLocations">
			<list>
				<value>classpath*:META-INF/com/mercer/userprofile/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/content/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/product/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/order/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/lookup/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/ukalumni/*.hbm.xml</value>
				<!-- Innovation 03: Podcast: START -->
				<value>classpath*:META-INF/com/mercer/podcast/*.hbm.xml</value>				
				<!-- Innovation 03: Podcast: END -->
				<!-- MercerPoll: START -->
				<value>classpath*:META-INF/com/mercer/mercerpoll/*.hbm.xml</value>				
				<!-- MercerPoll: END -->
			
				<value>classpath*:META-INF/com/mercer/userlog/AttachmentDownloadContentDetailProc.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/userlog/AttachmentDownloadUserDetailProc.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/userlog/MHRUserLogStoredProc.hbm.xml</value>	
				
			</list>
		</property>
		<property name="hibernateProperties">
			<ref bean="exampleHibernateProperties" />
		</property>
		<property name="dataSource">
			<ref bean="myDataSource" />
		</property>
	</bean>

[paul nisset]

You can mix and match Annotations and injection using the config file .
I don't use annotations or @Autowired a lot so I don't know the syntax for using annotations with a Session.

[Sai Hegde]

You can autowire it in your ServicesDAO as follows -

@Autowired
private LocalSessionFactoryBean mySessionFactory

[paul nisset]

Quick and painless .
Cheers.

[Ankit Chandrawat]

Thanks for the response Sai. But when I put :

@Autowired                                                                                
	private LocalSessionFactoryBean mySessionFactory ;

in my code as shown below

@Repository("chatSessionDAO")
public class ChatSessionDAO extends MercerDAO{
	 
	@Autowired                                                                                
	private LocalSessionFactoryBean mySessionFactory ;
	
	public List retrieveSessionInfo(ChatSessionQO chatSessionQO) throws MercerException {
		List lstReturn = null;
		try {
			Criteria criteria = getCriteria(chatSessionQO);
			if(criteria!=null) {
				lstReturn = processQuery(criteria);
			}
			
		}
		 catch (Exception e) {
				log.error("error :::" , e);
				throw new MercerException("No transaction");
			}
		 return lstReturn;
	}
	
	protected Criteria getCriteria(ChatSessionQO chatSessionQO) throws MercerException {
		Criteria cr = null;
		int chatSessionId = chatSessionQO.getChatSessionId();
		String chatSessionIdString = Integer.toString(chatSessionId);
		cr = createCriteria(chatSessionIdString);
		return cr;
	}
	private Criteria createCriteria(String chatSessionIdString) throws MercerException {
		Criteria cr = null;
		log.info("creating criteria");
		try {
			//HibernateTemplate hibernateTemplate = getHibernateTemplate();
			//Session session = hibernateTemplate.getSessionFactory().getCurrentSession();
			//Session session = mySessionFactory.getCurrentSession();
			SessionFactory sessionFactory  = mySessionFactory.getObject();
			Session session = sessionFactory.getCurrentSession();	
			log.info("creating criteria for event listing");
			cr = session.createCriteria(MHRContChatSessionDO.class, "chatSession").add(Restrictions.eq("id", chatSessionIdString));
			return cr;
		} catch (HibernateException e) {
			throw convertToMercerException(e);
		}
		
	}
	protected List processQuery(Criteria criteria) throws MercerException {
		List lstReturn = null;
		if (criteria != null) {
			try {
				// set cache to true
				criteria.setCacheable(true);
				// execute query
				lstReturn = criteria.list();
			} catch (Exception e) {
				log.error("exception" + e);
				throw convertToMercerException(e);
			}
		}
		return lstReturn;
	}
}

I get the following error :
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'chatSessionBO': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.mercer.chat.app.dao.ChatSessionDAO com.mercer.chat.app.businessmodel.ChatSessionBO.chatSessionDAO; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'chatSessionDAO': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.springframework.orm.hibernate3.LocalSessionFactoryBean com.mercer.chat.app.dao.ChatSessionDAO.mySessionFactory; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No unique bean of type [org.springframework.orm.hibernate3.LocalSessionFactoryBean] is defined: expected single matching bean but found 3: [&myMarsSessionFactory, &mySessionFactory, &myLogSessionFactory]

[Ankit Chandrawat]

Hi Thanks for all the help Paul and Sai. I have been able to resolve the issue by providing a @Qualifier.