sum up numbers

[Juan Villena]

Hi, in this program, supposed to add odd numbers
it works when num1 <= numb2 : "10, 1"
but when you enter num1 >=numb2 : "10,1" does not work and theres no errors
what condition i have to add (when numb1>=numb2) and where i have to locate it.
Thanks

import java.util.Scanner;
public class W06M2Prog5SumOddNums
{
  public static void main(String args[])
  {
    Scanner keyBoard = new Scanner(System.in);
    System.out.println("Enter two integers: ");
    int num1 = keyBoard.nextInt();
    int num2 = keyBoard.nextInt();
     
    System.out.println("You entered " + num1 + " and " + num2);
    
    int sum = 0;
 
    for (int cntr=num1; cntr<=num2; cntr++){
       if ((cntr % 2 ==1) || (cntr % 2 == -1)) sum += cntr; 
            cntr++;
      }
      
     System.out.println("The sum of the odd values between the two number is " + sum); 
  }

}

[Unnar Björnsson]

That's because you assume, in your code that num1 is less then or equal to num2.
Take a look at line 15
max() and min() in the Math class might be handy here.

[Wouter Oet]

You need to check out your loop. It is custom to have the increment part also in the for loop.

[Winston Gutkowski]

Juan Villena wrote:Hi, in this program, supposed to add odd numbers
it works when num1 <= numb2 : "10, 1"
but when you enter num1 >=numb2 : "10,1" does not work and theres no errors
what condition i have to add (when numb1>=numb2) and where i have to locate it.

Well personally, I'd do it right after they enter the numbers; the question is: what do you do if they enter them in the wrong order?

However, another way to do it without worrying about errors would be to just swap the two values if they're in the wrong order.

Winston