<identifier> expected error

[lily jose]

I Created a class Clock with displayTime(),displayMsg() methods to display time and required message.
I am getting 2 errors ,please help me find out my mistake.
they are-
<identifier>expected
and
';' expected
Please reply soon:rolleyes:

 import java.io.*;
import java.util.*;

public class Clock
	{

	private int Hours;
	private int Minutes;
	private int Seconds;
 	private String i;
   public static void clock(){

  	   System.out.println("It is mid night");
	  }
   public static void clock(int h, int m,int s)
  	{
  	Hours=h;
  	Minutes=m;
  	Seconds=s;
  	}
public void setHours (String Hours)
    {
	
       this.Hours = Hours;           
    }
    public int getHours ( )
    {
        return Hours;
    }
    public void setMinutes (String Minutes)
    {
       this.Minutes = Minutes;
    }
    public int getMinutes ( )
    {
        return Minutes;
    }

    public void setSeconds (String Seconds)
    {
       this.Seconds= Seconds;
    }
    public int getSeconds ( )
    {
        return Seconds;
    }
public static void displayTime()
	{
	System.out.println("the time is"+h+":"+m+":"+s+""+i);
	}
public stacic void displayMsg()
{
	if(h==12&&i==AM)
	{
	System.out.println("Its Late night ! Go to Sleep");
	}
	if(h>=0&&h<6)
	{
        
	if(i==AM){
	System.out.println("Its Late night ! Go to Sleep");
	        }
	}
	if(h>=6&&h<12)
	{
	if(i==AM){
	System.out.println("Good Morning");
	        }
	}
	if(h==12&&i==PM)
	{
	System.out.println("Good Afternoon");
	}
	if(h>=0&&h<6)
	{
	if(i=PM){
	System.out.println("Good Afternoon");
	        }
	}
	if(h>=6&&h<8)
	{
	if(i==PM){
	System.out.println("Good Evening");
	        }
	}
	if(h>=8&&h<12)
	{
	if(i==PM){
	System.out.println("Good Night");
	         }
	}
}
public static void main (String args[]) 
	{
	Scanner scanner = new Scanner(System.in);
 	String i;
  	System.out.println("Enter whether morning or evening: ");
  	String time = scanner.nextLine();
  	if (time==morning)
	{
	 i="AM";
	}
	else
	 if(time==evening)
	{
	i="PM";
	}
	clock c=new clock;
  	c.displayTime();
	c.displayMsg();
	
	}
} 

[Edit - added code tags - MB]

[Matthew Brown]

Hi Lily. Welcome to the Ranch!

It's a lot more helpful if you tell us where the errors are occuring - the compiler will tell you which line it thinks is a problem, so it's useful to pass this on.

However, I can see a few problems. For example:

- You've got a static method (clock) referring to non-static variables (Hours, Minutes, Seconds). I suspect it's meant to be a constructor, but it isn't written as a constructor.

- You refer to AM and PM as if they are variables (e.g. line 53), but they aren't defined anywhere.
I suspect you're intending them to be Strings (they really ought to be enums, but maybe you haven't learned about them yet).

- On line 108, you've got missing brackets, and the capitalisation is wrong (Clock, not clock).

This isn't a complete list. You should really write just a bit of your class at a time, compiling regularly, rather than writing it all and then seeing what mistakes you've made. That way you've got a much better idea what's caused the problem.

[lily jose]

Thank ,
Now i have understood my mistake!
I am just a beginner in java, that's why i got my code messed up!

[fred rosenberger]

There's nothing wrong with making mistakes - in fact, it's one of the best ways to learn. and folks around here LOVE helping, but you have to help us help you. As Matthew pointed out, if you would post the exact and complete text of your errors, that makes it even easier to help you.

Let me also give you this piece of advice: Don't write 100+ lines of code before you compile. I personally NEVER write more than 2-3 before recompiling. That way, if there is a new syntax error, I know the exact 2-3 lines where the error must be.

After compiling, I test my new code - a LOT.

I write a LOT of throw-away code. I am a BIG proponent of putting in System.out.printin() statements all over the place that say things like "got to spot 1" or "in the outer for-loop" or "value of x is " + x.

I know it sounds silly and like a waste of time, but ultimately, especially when beginning, it really will SAVE you time.