Metthod within method need sloving

[Teh Singh]

I need to correct the method within a method at line 267
please can someone slove it ?

                       import java.util.*;
import java.util.Scanner;

public class menu{
public static void main(String args[]){

String cpu1;
int a;
int c;
String d;
boolean cpuDone = false;
boolean ramDone = false;
boolean graphicsDone = false;
String b;
int e;
String f;


Scanner inputVal = new Scanner(System.in);

System.out.println("              The Computer Store ");
System.out.println("     The store for all your hardware needs ");
System.out.println(" Please select part needed from the list below ");
System.out.println("                   1. CPU");
System.out.println("                   2. RAM ");
System.out.println("                   3. Graphics card");
a = inputVal.nextInt();


if ( a == 1){
if (cpuDone == false){
System.out.println("Please selct CPU model:");
System.out.println(" (C1)     Intel i3");
System.out.println(" (C2)     Intel i5");
System.out.println(" (C3)     Intel i7");
System.out.println(" (C4)     AMD FX 4");

System.out.println(" (C5)     AMD FX 6");
cpuDone = true;
}else{
System.out.println("already chosen CPU");
}
}

if ( a == 2){
if (ramDone == false){
System.out.println("Please select RAM model: ");
System.out.println(" (R1)     DDR2 2GB ");
System.out.println(" (R2)     DDR2 4GB");
System.out.println(" (R3)     DDR3 2GB");
System.out.println(" (R4)     DDR3 4GB");
System.out.println(" (R5)     DDR3 8GB");
ramDone = true;
}else{
System.out.println("already chosen RAM");
}
}

if ( a == 3){
if (graphicsDone == false){
System.out.println("Please selct Graphics card model:");
System.out.println(" (G1)     Geforce GTX 570");
System.out.println(" (G2)     Geforce GTX 580");
System.out.println(" (G3)     Geforce GTX 590");
System.out.println(" (G4)     ATI Radeon HD 4000");
System.out.println(" (G5)     ATI Radeon HD 5000");
graphicsDone = true;
}else{
System.out.println("already chosen RAM");
}
}


b = inputVal.next();

if ( b.equals("C1")){
System.out.println("You have selected the Intel i3 CPU, the cost for this is 100 pounds");
}

if ( b.equals("C2")){
System.out.println("You have selected the Intel i5 CPU, the cost for this is 150 pounds");
}

if ( b.equals("C3")){
System.out.println("You have selected the Intel i7 CPU, the cost for this is 200 pounds");
}

if ( b.equals("C4")){
System.out.println("You have selected the AMD FX 4 CPU, the cost for this is 150 pounds");
}

if ( b.equals("C5")){
System.out.println("You have selected the AMD FX 6 CPU, the cost for this is 200 pounds");
}

if ( b.equals("R1")){
System.out.println("You have selected the DDR2 2GB, the cost for this is 100 pounds");
}

if ( b.equals("R2")){
System.out.println("You have selected the DDR2 4GB, the cost for this is 150 pounds");
}

if ( b.equals("R3")){
System.out.println("You have selected the DDR3 2GB, the cost for this is 200 pounds");
}

if ( b.equals("R4")){
System.out.println("You have selected the DDR3 4GB, the cost for this is 200 pounds");
}

if ( b.equals("R5")){
System.out.println("You have selected the DDR3 8GB, the cost for this is 250 pounds");
}

if ( b.equals("G1")){
System.out.println("You have selected the Geforce GTX 570 Graphics card, the cost for this is 200 pounds");
}

if ( b.equals("G2")){
System.out.println("You have selected the Geforce GTX 580 Graphics card, the cost for this is 300 pounds");
}

if ( b.equals("G3")){
System.out.println("You have selected the Geforce GTX 590 Graphics card, the cost for this is 400 pounds");
}

if ( b.equals("G4")){
System.out.println("You have selected the ATI Radeon HD 4000 Graphics card, the cost for this is 350 pounds");
}

if ( b.equals("G5")){
System.out.println("You have selected the ATI Radeon HD 5000 Graphics card, the cost for this is 400 pounds");
}

System.out.println("                                         ");
System.out.println("                                         ");
System.out.println("               The Computer Store ");
System.out.println("     The store for all your hardware needs ");
System.out.println(" Please select part needed from the list below ");
System.out.println("                   1. CPU");
System.out.println("                   2. RAM ");
System.out.println("                   3. Graphics card");
c = inputVal.nextInt();


if ( c == 1){
if (cpuDone == false){
System.out.println("                                         ");
System.out.println("                                         ");
System.out.println(" Please selct CPU model:");
System.out.println(" (C1)     Intel i3");
System.out.println(" (C2)     Intel i5");
System.out.println(" (C3)     Intel i7");
System.out.println(" (C4)     AMD FX 4");
System.out.println(" (C5)     AMD FX 6");
cpuDone = true;
}
else{
System.out.println(" You have already chosen a CPU");
printHeader();
}
}

if ( c == 2){
if (ramDone == false){
System.out.println("                                         ");
System.out.println("                                         ");
System.out.println("Please select RAM model: ");
System.out.println(" (R1)     DDR2 2GB ");
System.out.println(" (R2)     DDR2 4GB");
System.out.println(" (R3)     DDR3 2GB");
System.out.println(" (R4)     DDR3 4GB");
System.out.println(" (R5)     DDR3 8GB");
ramDone = true;
}
else{
System.out.println("You have already chosen your RAM");
printHeader();
}
}


if ( c == 3){
if (graphicsDone == false){
System.out.println("Please selct Graphics card model:");
System.out.println(" (G1)     Geforce GTX 570");
System.out.println(" (G2)     Geforce GTX 580");
System.out.println(" (G3)     Geforce GTX 590");
System.out.println(" (G4)     ATI Radeon HD 4000");
System.out.println(" (G5)     ATI Radeon HD 5000");
graphicsDone = true;
}
else{
System.out.println("You have already chosen your Graphics card");
printHeader();
}
}




d = inputVal.next();

if ( d.equals("C1")){
System.out.println("You have selected the Intel i3 CPU, the cost for this is 100 pounds");
}

if ( d.equals("C2")){
System.out.println("You have selected the Intel i5 CPU, the cost for this is 150 pounds");
}

if ( d.equals("C3")){
System.out.println("You have selected the Intel i7 CPU, the cost for this is 200 pounds");
}

if ( d.equals("C4")){
System.out.println("You have selected the AMD FX 4 CPU, the cost for this is 150 pounds");
}

if ( d.equals("C5")){
System.out.println("You have selected the AMD FX 6 CPU, the cost for this is 200 pounds");
}

if ( d.equals("R1")){
System.out.println("You have selected the DDR2 2GB, the cost for this is 100 pounds");
}

if ( d.equals("R2")){
System.out.println("You have selected the DDR2 4GB, the cost for this is 150 pounds");
}

if ( d.equals("R3")){
System.out.println("You have selected the DDR3 2GB, the cost for this is 200 pounds");
}

if ( d.equals("R4")){
System.out.println("You have selected the DDR3 4GB, the cost for this is 200 pounds");
}

if ( d.equals("R5")){
System.out.println("You have selected the DDR3 8GB, the cost for this is 250 pounds");
}

if ( d.equals("G1")){
System.out.println("You have selected the Geforce GTX 570 Graphics card, the cost for this is 200 pounds");
}

if ( d.equals("G2")){
System.out.println("You have selected the Geforce GTX 580 Graphics card, the cost for this is 300 pounds");
}

if ( d.equals("G3")){
System.out.println("You have selected the Geforce GTX 590 Graphics card, the cost for this is 400 pounds");
}

if ( d.equals("G4")){
System.out.println("You have selected the ATI Radeon HD 4000 Graphics card, the cost for this is 350 pounds");
}

if ( d.equals("G5")){
System.out.println("You have selected the ATI Radeon HD 5000 Graphics card, the cost for this is 400 pounds");
}



public static void printHeader;{
System.out.println("                                         ");
System.out.println("                                         ");
System.out.println("               The Computer Store ");
System.out.println("     The store for all your hardware needs ");
System.out.println(" Please select part needed from the list below ");
System.out.println("                   1. CPU");
System.out.println("                   2. RAM ");
System.out.println("                   3. Graphics card");
}


e = inputVal.nextInt();

if ( e == 1){
if (cpuDone == false){
System.out.println("                                         ");
System.out.println("                                         ");
System.out.println("   Please selct CPU model:");
System.out.println(" (C1)     Intel i3");
System.out.println(" (C2)     Intel i5");
System.out.println(" (C3)     Intel i7");
System.out.println(" (C4)     AMD FX 4");
System.out.println(" (C5)     AMD FX 6");
cpuDone = true;
}else{
System.out.println(" You have already chosen a CPU");
}
}

if ( e == 2){
if (ramDone == false){
System.out.println("                                         ");
System.out.println("                                         ");
System.out.println("  Please select RAM model: ");
System.out.println(" (R1)     DDR2 2GB ");
System.out.println(" (R2)     DDR2 4GB");
System.out.println(" (R3)     DDR3 2GB");
System.out.println(" (R4)     DDR3 4GB");
System.out.println(" (R5)     DDR3 8GB");
ramDone = true;
}
else{
System.out.println("You have already chosen your RAM");
}
}

if ( e == 3){
if (graphicsDone == false){
System.out.println("  Please selct Graphics card model:");
System.out.println(" (G1)     Geforce GTX 570");
System.out.println(" (G2)     Geforce GTX 580");
System.out.println(" (G3)     Geforce GTX 590");
System.out.println(" (G4)     ATI Radeon HD 4000");
System.out.println(" (G5)     ATI Radeon HD 5000");
graphicsDone = true;
}
else{
System.out.println("You have already chosen your Graphics card");
}
}

f = inputVal.next();

if ( f.equals("C1")){
System.out.println("You have selected the Intel i3 CPU, the cost for this is 100 pounds");
}

if ( f.equals("C2")){
System.out.println("You have selected the Intel i5 CPU, the cost for this is 150 pounds");
}

if ( f.equals("C3")){
System.out.println("You have selected the Intel i7 CPU, the cost for this is 200 pounds");
}

if ( f.equals("C4")){
System.out.println("You have selected the AMD FX 4 CPU, the cost for this is 150 pounds");
}

if ( f.equals("C5")){
System.out.println("You have selected the AMD FX 6 CPU, the cost for this is 200 pounds");
}

if ( f.equals("R1")){
System.out.println("You have selected the DDR2 2GB, the cost for this is 100 pounds");
}

if ( f.equals("R2")){
System.out.println("You have selected the DDR2 4GB, the cost for this is 150 pounds");
}

if ( f.equals("R3")){
System.out.println("You have selected the DDR3 2GB, the cost for this is 200 pounds");
}

if ( f.equals("R4")){
System.out.println("You have selected the DDR3 4GB, the cost for this is 200 pounds");
}

if ( f.equals("R5")){
System.out.println("You have selected the DDR3 8GB, the cost for this is 250 pounds");
}

if ( f.equals("G1")){
System.out.println("You have selected the Geforce GTX 570 Graphics card, the cost for this is 200 pounds");
}

if ( f.equals("G2")){
System.out.println("You have selected the Geforce GTX 580 Graphics card, the cost for this is 300 pounds");
}

if ( f.equals("G3")){
System.out.println("You have selected the Geforce GTX 590 Graphics card, the cost for this is 400 pounds");
}

if ( f.equals("G4")){
System.out.println("You have selected the ATI Radeon HD 4000 Graphics card, the cost for this is 350 pounds");
}

if ( f.equals("G5")){
System.out.println("You have selected the ATI Radeon HD 5000 Graphics card, the cost for this is 400 pounds");
}



}
}

[Paul Clapham]

The first thing you should do is to indent your code so the { symbols and the } symbols match up vertically. Then, since the error is caused because you don't have enough of one or the other kind of those symbols, it should be easier to find out where you missed one. If you are using an IDE like Netbeans or Eclipse then there's an option you can take to reformat your class.

As it is you have several hundred lines of code which is less readable than it should be. This problem is the consequence of having unreadable code.

[Campbell Ritchie]

Welcome to the Ranch

You should also write code from outside in, rather from top to bottom, which reduces the risk of such mistakes.

[Teh Singh]

Ive counted every { and } and they are equal but the thing is that i am nesting a method within a method and have no idea how to sort it out

[Campbell Ritchie]

Is that all in the main() method? Good grief! Any method that long ought to be divided into several methods.
Also that whole thing is non object-oriented; you ought to have classes for CPU, memory, etc.

[Teh Singh]

I only learnt this in like 4 weeks at colllege so im not the best :/

[Paul Clapham]

Teh Singh wrote:Ive counted every { and } and they are equal...

Sure, but they are in the wrong order. I still suggest you format your code better. Even if you find your problem now, it will be easy for you to break it again and have the same problem.

[Teh Singh]

Problem is i aint learnt that far yet in college

and have half term but trying to finsih my program and have no idea how to have seperate classes for them etc.

[fred rosenberger]

This is why you don't write 300 lines of code before you compile. My guess is that you have something like this:

public static void main 
{
public void dummy()
{
}
}

You'll notice I have the correct number of curly braces, but this code would be invalid. You have to close one method before you start the next. So my above example would be correctly written as this:

public static void main 
{
}
public void dummy()
{
}

[Ben Ooms]

Teh Singh wrote:Problem is i aint learnt that far yet in college

and have half term but trying to finsih my program and have no idea how to have seperate classes for them etc.

Your main method is from line 5 till 393, within this method you have another method printheader between line 267 and 276. That's causing the error. If you put the method outside of main and use it you can remove 87 lines of code from the main .

regards,
Ben

[Greg Brannon]

How about the semi-colon at the end of line 267, before the {?

[Ben Ooms]

Greg Brannon wrote:How about the semi-colon at the end of line 267, before the {?

Your totally right, I fixed that one and forgot to mention it.