Trying to get rid of redundancy?

[Ashley Kin]

Hi, I'm trying to get rid of redundance in this program by factoring? Thank you for any help! (Sorry, I'm not sure how to use clipboard)

import java.util.*;
public class Coordinates {
    public static void main(String[] args) {
        Scanner console = new Scanner(System.in);
        double result = getCoordinates(console);
        System.out.println(result);
    }
    
    public static double getCoordinates(Scanner console) {
        System.out.print("What is the x coordinate? ");
        double x = console.nextDouble();
        int negatives;
        if (x < 0.0) {
            System.out.print("What is the y coordinate? ");
            double y = console.nextDouble();
            if (y < 0.0) {
                negatives = 2;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }  else {
                negatives = 1;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }
        } else {
            System.out.print("What is the y coordinate? ");
            double y = console.nextDouble();
            if (y < 0.0) {
                negatives = 1;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }  else {
                negatives = 0;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }
        }
    }
}

[Winston Gutkowski]

Ashley Kin wrote:Hi, I'm trying to get rid of redundance in this program by factoring?

Well, the usual way is to put repeated code into a method and call it instead. And it seems like you have 2 big blocks of repeated code. You might want to think about parameter(s) for that method as well, so that it's self-contained.

Winston

[Ralph Cook]

another way is not to post the same question in two forums. You've got this same one in "Java in General".

rc

[Harsha Smith]

import java.util.*;

public class Coordinates {
	public static void main(String[] args) {

		System.out.println(getCoordinates());
	}

	public static double getCoordinates() {
		Scanner console = new Scanner(System.in);
		System.out.print("What is the x coordinate? ");
		double x = console.nextDouble();
		System.out.print("What is the y coordinate? ");
		double y = console.nextDouble();
      return x + y + getNegatives(x, y);
	}

	private static int getNegatives(double x, double y) {

		if (x < 0.0 && y < 0.0)
			return 2;
		if (x < 0.0 && y > 0.0)
			return 1;
		if (x > 0 && y < 0)
		return 1;
		return 0;

	}

}

Ralph Cook wrote:another way is not to post the same question in two forums. You've got this same one in "Java in General".

rc

good sense of humor!

[Sven Eriksson]

Hi Ashley

Easiest would be something like this:

        System.out.print("What is the y coordinate? ");
        double y = console.nextDouble();
        if (x < 0.0) {
            if (y < 0.0) {
                negatives = 2;
            }  else {
                negatives = 1;
            }
        } else {
            if (y < 0.0) {
                negatives = 1;
            }  else {
                negatives = 0;
            }
        }
        System.out.println("negatives = " + negatives);
        return x + y + negatives;

Hopefully that might help some, but you could also write it in another method and call to it
Remember, everyone codes differently...