street view & satilite view is not working

[shawn peter]

this is my main class

package com.android.mymap;


import java.io.IOException;
import java.util.List;

import android.content.Intent;
import android.graphics.drawable.Drawable;
import android.location.Address;
import android.location.Criteria;
import android.location.Geocoder;
import android.location.Location;
import android.location.LocationListener;
import android.location.LocationManager;
import android.os.Bundle;
import android.view.KeyEvent;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.Toast;

import com.google.android.maps.GeoPoint;
import com.google.android.maps.MapActivity;
import com.google.android.maps.MapController;
import com.google.android.maps.MapView;
import com.google.android.maps.Overlay;
import com.google.android.maps.OverlayItem;


public class GMapsActivity extends MapActivity implements LocationListener,OnClickListener{

	private MapView mapView;
	private LocationManager locationManager;
	private Intent item;
	//private static final double latitudeE6 = 9.097416174598038 * 1E6;
	//private static final double longitudeE6 = 80.14439212158322 * 1E6;
	
	private static  double latitudeE6 = 0.0;
	private static  double longitudeE6 = 0.0;
	private OverlayItem overlayitem1;
	private MapController mapController;
	@Override
	public void onCreate(Bundle savedInstanceState) {

		super.onCreate(savedInstanceState);
		setContentView(R.layout.main);
		Button copyrights=(Button)findViewById(R.id.Btn_copyrights);
		copyrights.setOnClickListener(this);
		
		mapView = (MapView) findViewById(R.id.map_view);
		mapView.setBuiltInZoomControls(true);//AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
		//mapView.getController();
		mapView.setClickable(true);
		//mapView.setSatellite(true);
		//mapView.setStreetView(true);
		
		
		 locationManager = (LocationManager) getSystemService(LOCATION_SERVICE);
		    
		    //Get the best provider  for the criteria
		    
		    Criteria criteria = new Criteria();
		    criteria.setPowerRequirement(Criteria.POWER_LOW);
		    criteria.setAccuracy(Criteria.ACCURACY_COARSE);
		    
		    String bestprovider = locationManager.getBestProvider(criteria,false);
		    
		    Location lastknownlocation = locationManager.getLastKnownLocation(bestprovider);
		    
		    
		    locationManager.requestLocationUpdates(bestprovider,5000, 0.2f, this);
		
		List<Overlay> mapOverlays = mapView.getOverlays();
		Drawable drawable = this.getResources().getDrawable(R.drawable.icon);
		CustomItemizedOverlay itemizedOverlay = new CustomItemizedOverlay(
				drawable, this);
		//GeoPoint point = new GeoPoint((int)latitudeE6, (int)longitudeE6);
		if(lastknownlocation!=null){
		longitudeE6=lastknownlocation.getLongitude()*1e6;
		latitudeE6 =lastknownlocation.getLatitude()*1e6;
		}
		else{
			
		}
		GeoPoint point = new GeoPoint((int)latitudeE6,(int)longitudeE6);
		//OverlayItem overlayitem = new OverlayItem(point, "Hello","I'm in From Wadduwa, Sri lanka!");

		Geocoder geocoder = new Geocoder(this);
	    List<Address> addresses;
		try {
			addresses = geocoder.getFromLocation(lastknownlocation.getLatitude(),lastknownlocation.getLongitude(),1);
		
	    for (Address address: addresses){
	    	String Country=address.getCountryName();
	    	overlayitem1 = new OverlayItem(point, address.getCountryName(), address.getAddressLine(0));
	    	//locationdetails += "Address is "+address.getAddressLine(0)+" ,"+address.getCountryName();
	    }
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		
		//itemizedOverlay.addOverlay(overlayitem);
		itemizedOverlay.addOverlay(overlayitem1);
		mapOverlays.add(itemizedOverlay);
		mapController = mapView.getController();
		mapController.animateTo(point);
		
		mapController.setZoom(15);
		
		System.out.println("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX  "+longitudeE6);
		System.out.println("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX  "+latitudeE6);
		
		
	}

	public boolean onKeyDown(int keyCode, KeyEvent event) {
        switch (keyCode) {
        case KeyEvent.KEYCODE_3:
        	mapController.zoomIn();
            break;
        case KeyEvent.KEYCODE_1:
        	mapController.zoomOut();
            break;
        }
        return super.onKeyDown(keyCode, event);
    }
	
	@Override
	protected boolean isRouteDisplayed() {
		return false;
	}
	@Override
	protected boolean isLocationDisplayed() {
	return false;
	}

	@Override
	public void onLocationChanged(Location location) {
		
		
		longitudeE6=location.getLongitude()*1e6;
		latitudeE6=location.getLatitude()*1e6;
		
	}

	@Override
	public void onProviderDisabled(String provider) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void onProviderEnabled(String provider) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void onStatusChanged(String provider, int status, Bundle extras) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void onClick(View v) {
					
		
		if(v.getId() == R.id.Btn_copyrights)
		{
			item = new Intent(getApplicationContext(), Copyrights.class);
		}
		else if(v.getId()==R.id.Btn_satalite){
			mapView.setSatellite(true);			
		}
		else if(v.getId()==R.id.Btn_satalite){
			mapView.setStreetView(true);			
		}
		
		startActivity(item);
		
	}
	
	
	
}

this is working fine.i have added a button to change the view.there are two buttom to change the street view and satilite view.But it is not working.???

[Tim Moores]

Compare lines 173 and 176.

[shawn peter]

what is the error wit h lines 173 and 176 ?
it is trigger only button clicks.

[Tim Moores]

Do they actually do that? Both of them?

[shawn peter]

I have change the code.still same.

if(v.getId() == R.id.Btn_copyrights)
		{
			item = new Intent(getApplicationContext(), Copyrights.class);
		}
		if(v.getId()==R.id.Btn_satalite){
			mapView.setSatellite(true);			
		}
		if(v.getId()==R.id.Btn_street){
			mapView.setStreetView(true);			
		}

[Tim Moores]

Have you ascertained that those "if" conditions are triggered? In other words, do the mapView.set... methods get executed?

[shawn peter]

I need to change the map view after load it into phone.normally google map load normal map.i need to change the type of map after clicking the button.
So how it should be change?

[shawn peter]

I have change the code.Still same.

if(v.getId() == R.id.Btn_copyrights)
		{
			item = new Intent(getApplicationContext(), Copyrights.class);
		}
		if(v.getId()==R.id.Btn_satalite){
			mapView.setSatellite(true);
			mapView.invalidate();
		}
		if(v.getId()==R.id.Btn_street){
			mapView.setStreetView(true);
			mapView.invalidate();
		}

[Tim Moores]

Tim Moores wrote:Have you ascertained that those "if" conditions are triggered? In other words, do the mapView.set... methods get executed?

Does that mean the answer to this question is "yes" or "no"?

[shawn peter]

Yes.
It should be called,because have change them inside the onclick method.Then button clicks it must be called.

Anyway I have change the code as below.Same reqult.

if(v.getId()==R.id.Btn_satalite){
			mapView.setSatellite(true);
			mapView.setStreetView(false);
			mapView.invalidate();
		}
		if(v.getId()==R.id.Btn_street){
			mapView.setStreetView(true);
			mapView.setSatellite(false);
			mapView.invalidate();
		}

[Tim Moores]

I didn't ask whether it *should* be called; obviously you think that it should. I asked if it *is* getting called. That's what matters, and that's what you need to find out.

[shawn peter]

I tried with debugging.But never gones to that method.I don't know why ?

[Tim Moores]

Is it called for the copyrights button? If so, what's the difference between that button and the other two buttons?

[shawn peter]

Yes.copyrights button working.So do i have to call separate activities for each street & satalite views ?

[Tim Moores]

Separate activities? No. But you will have to register the onClickListener with all buttons for which it should be called.

[shawn peter]

Thanks Tim.It is working fine.Anyway When i moves with phone The pointer doesn't move.I have to rstart the programm.What is the error with that ?

[Tim Moores]

What do you expect to happen? It's not like the onLocationChanged method causes anything to happen.

[shawn peter]

I need to change the poiter with the current changes.Example it i travelling in a vehivle pointer must be change with the location changes.

[Tim Moores]

Sounds like you need to tell the MapView to update itself somehow.

[shawn peter]

There is a built in application in my phone which changes the pointer when i move with phone.

anyway can't we do this using this code.

locationManager.requestLocationUpdates(bestprovider,5000, 0.2f, this);

[Tim Moores]

anyway can't we do this using this code.

Why not? I sounded like that's what you wanted to do.

[shawn peter]

I change the code as below.

locationManager.requestLocationUpdates(bestprovider,5 , 0.2f, this);

So i reduce the time different.but still it is not update the pointer when i moves in a vehicle .
Where is the error ?

[Tim Moores]

Tim Moores wrote:Sounds like you need to tell the MapView to update itself somehow.

[shawn peter]

So that means i have to repeat calling below code for location changes.

 List<Overlay> mapOverlays = mapView.getOverlays();
				Drawable drawable = this.getResources().getDrawable(R.drawable.icon);
				CustomItemizedOverlay itemizedOverlay = new CustomItemizedOverlay(
						drawable, this);
				//GeoPoint point = new GeoPoint((int)latitudeE6, (int)longitudeE6);
				
				GeoPoint point = new GeoPoint((int)latitudeE6,(int)longitudeE6);
				//OverlayItem overlayitem = new OverlayItem(point, "Hello","I'm in From Wadduwa, Sri lanka!");

				geocoder = new Geocoder(this);
			    List<Address> addresses;
				try {
					addresses = geocoder.getFromLocation(latitudeE6/1e6,longitudeE6/1e6,1);
				
			    for (Address address: addresses){
			    	String Country=address.getCountryName();
			    	overlayitem1 = new OverlayItem(point, address.getCountryName(), address.getAddressLine(0));
			    	//locationdetails += "Address is "+address.getAddressLine(0)+" ,"+address.getCountryName();
			    }
				} catch (IOException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
				
				//itemizedOverlay.addOverlay(overlayitem);
				itemizedOverlay.addOverlay(overlayitem1);
				mapOverlays.add(itemizedOverlay);
				mapController = mapView.getController();
				mapController.animateTo(point);
				
				mapController.setZoom(14);

Is it ok to do all above code in onLocationChanged method.I think it is better .because it automatically calls that method when location chnages happen.isn't it ?

[shawn peter]

I have change the code adding while loop.

package com.virtual.yourlocation;

import java.io.IOException;
import java.util.List;

import com.google.android.maps.GeoPoint;
import com.google.android.maps.MapActivity;
import com.google.android.maps.MapController;
import com.google.android.maps.MapView;
import com.google.android.maps.Overlay;
import com.google.android.maps.OverlayItem;
import android.app.Activity;
import android.content.Intent;
import android.graphics.drawable.Drawable;
import android.location.Address;
import android.location.Criteria;
import android.location.Geocoder;
import android.location.Location;
import android.location.LocationListener;
import android.location.LocationManager;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.TextView;

public class ShowYourLocation extends MapActivity implements LocationListener,OnClickListener{
    /** Called when the activity is first created. */
   
private LocationManager locationManager;
	
	private static  double latitudeE6 = 0.0;
	private static  double longitudeE6 = 0.0;
	private MapController mapController;
	private OverlayItem overlayitem1;	
	private Geocoder geocoder;
	private MapView mapView;	
	private Intent item;
	
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        
        Button copyrights=(Button)findViewById(R.id.B_Copyrights);
		copyrights.setOnClickListener(this);
		
		Button satalite=(Button)findViewById(R.id.B_Satilite);
		satalite.setOnClickListener(this);
		
		Button street=(Button)findViewById(R.id.B_Street);
		street.setOnClickListener(this);
		
		TextView error=(TextView)findViewById(R.id.Error);
		
		mapView = (MapView) findViewById(R.id.map_view);
		mapView.setBuiltInZoomControls(true);
		//mapView.getController();
		mapView.setClickable(true);
		
		locationManager = (LocationManager) getSystemService(LOCATION_SERVICE);
	    Criteria criteria = new Criteria();
	    criteria.setPowerRequirement(Criteria.POWER_HIGH);
	    criteria.setAccuracy(Criteria.ACCURACY_FINE);	    
	    String bestprovider = locationManager.getBestProvider(criteria,false);	    
	    Location lastknownlocation = locationManager.getLastKnownLocation(bestprovider);
	    
	    while (true){
	    if(lastknownlocation!=null){
			longitudeE6=lastknownlocation.getLongitude()*1e6;
			latitudeE6 =lastknownlocation.getLatitude()*1e6;
			
			 locationManager.requestLocationUpdates(bestprovider,5, 0.2f, this);
			 
			 List<Overlay> mapOverlays = mapView.getOverlays();
				Drawable drawable = this.getResources().getDrawable(R.drawable.icon);
				CustomItemizedOverlay itemizedOverlay = new CustomItemizedOverlay(
						drawable, this);
				//GeoPoint point = new GeoPoint((int)latitudeE6, (int)longitudeE6);
				
				GeoPoint point = new GeoPoint((int)latitudeE6,(int)longitudeE6);
				//OverlayItem overlayitem = new OverlayItem(point, "Hello","I'm in From Wadduwa, Sri lanka!");

				geocoder = new Geocoder(this);
			    List<Address> addresses;
				try {
					addresses = geocoder.getFromLocation(latitudeE6/1e6,longitudeE6/1e6,1);
				
			    for (Address address: addresses){
			    	String Country=address.getCountryName();
			    	overlayitem1 = new OverlayItem(point, address.getCountryName(), address.getAddressLine(0));
			    	//locationdetails += "Address is "+address.getAddressLine(0)+" ,"+address.getCountryName();
			    }
				} catch (IOException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
				
				//itemizedOverlay.addOverlay(overlayitem);
				itemizedOverlay.addOverlay(overlayitem1);
				mapOverlays.add(itemizedOverlay);
				mapController = mapView.getController();
				mapController.animateTo(point);
				
				mapController.setZoom(14);
				
				error.setText("");
	    	
			}
	    else{
	    	error.setVisibility(1);
	    	//error.setText("Provider not available");
	    }
	    }
				
	    }
    

	@Override
	public void onClick(View v) {
		

		if(v.getId() == R.id.B_Copyrights)
		{
			item = new Intent(getApplicationContext(), Copyrights.class);
			startActivity(item);
		}
		if(v.getId()==R.id.B_Satilite){
			mapView.setSatellite(true);
			mapView.setTraffic(false);
			mapView.invalidate();
		}
		if(v.getId()==R.id.B_Street){
			mapView.setTraffic(true);
			mapView.setSatellite(false);
			mapView.invalidate();
		}
		
	}

	@Override
	public void onLocationChanged(Location location) {
		longitudeE6=location.getLongitude()*1e6;
		latitudeE6=location.getLatitude()*1e6;
		
	}

	@Override
	public void onProviderDisabled(String arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void onProviderEnabled(String arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void onStatusChanged(String arg0, int arg1, Bundle arg2) {
		// TODO Auto-generated method stub
		
	}


	@Override
	protected boolean isRouteDisplayed() {
		// TODO Auto-generated method stub
		return false;
	}
	
}

But the problem is now code never goes to if part as lastknownlocation null at first time.Can anyone give me solution for this ?
Is there a way to get currentlocation details without lastknownlocation method ?

[Tim Moores]

You can't loop forever on the onCreate method - you need to return from that quickly, live you would do for all other lifecycle methods. Any GUI changes should be triggered from the various listeners, like onLocationChanged and onClick.

I don't understand your question - why does the code rely on there being a lastknownlocation? There won't necessarily be one, as you have found out. Nor will there be a currentlocation until you get onLocationChanged updates. You will need to decide what the app should do until there is a currentlocation.

[shawn peter]

k.But i mean if the location changes countinously it automatically calls the onLocationChanged.So if i need to show it on the map i have to call below code coutinously.So is it correct to code below one in onLocationChanged activity ?

List<Overlay> mapOverlays = mapView.getOverlays();
				Drawable drawable = this.getResources().getDrawable(R.drawable.icon);
				CustomItemizedOverlay itemizedOverlay = new CustomItemizedOverlay(
						drawable, this);
				//GeoPoint point = new GeoPoint((int)latitudeE6, (int)longitudeE6);
				
				GeoPoint point = new GeoPoint((int)latitudeE6,(int)longitudeE6);
				//OverlayItem overlayitem = new OverlayItem(point, "Hello","I'm in From Wadduwa, Sri lanka!");

				geocoder = new Geocoder(this);
			    List<Address> addresses;
				try {
					addresses = geocoder.getFromLocation(latitudeE6/1e6,longitudeE6/1e6,1);
				
			    for (Address address: addresses){
			    	String Country=address.getCountryName();
			    	overlayitem1 = new OverlayItem(point, address.getCountryName(), address.getAddressLine(0));
			    	//locationdetails += "Address is "+address.getAddressLine(0)+" ,"+address.getCountryName();
			    }
				} catch (IOException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
				
				//itemizedOverlay.addOverlay(overlayitem);
				itemizedOverlay.addOverlay(overlayitem1);
				mapOverlays.add(itemizedOverlay);
				mapController = mapView.getController();
				mapController.animateTo(point);
				
				mapController.setZoom(14);