Table Row Selection problem while adding any Image in a JTable

[buntha Choudhary]

I am adding an Image in JTable

public class BrowserLabelCellRenderer extends AbstractCellEditor implements TableCellRenderer, TableCellEditor,ActionListener

through the above logic but when I try to select the row it is not selecting this particular column.

For example My table has 4 Columns and the image is being set in Column 4th.
Then on selecting any Row , default 3 columns are getting selected or highlighted and the 4th Column is not getting highlighted.

[Rob Spoor]

Are you sure it's not being selected? The visual selection is part of the renderer. DefaultTableCellRenderer renders the value with a different colour if the cell is selected; that's what the isSelected parameter indicates. If your renderer does not use a different colour if isSelected is true then the cell will be selected, just not look selected.

[buntha Choudhary]

@Rob Spoor
Thanks for the input but is there no way to make the look identical for the entire row like SWT wizard where entire row shows highlighted blue color.

[Rob Spoor]

That depends on how you've implemented your renderer. Can you show us its fields and getTableRendererComponent method?

[buntha Choudhary]

This is my code snippet-

class ButtonCellRenderer extends AbstractCellEditor
	implements TableCellRenderer,TableCellEditor,MouseListener{

		JTable table;
		JLabel rendererLabel ;
		JButton editButton ;
		 String text = "BAKRA";


		public ButtonCellRenderer(JTable table, int column) {
			// TODO Auto-generated constructor stub
			this.table = table;
		rendererLabel = new JLabel("value.png");


			//rendererBut.setToolTipText("BUNTHAAAAAAAAAAAAAA");
			rendererLabel .addMouseListener(this);


			 TableColumnModel columnModel = table.getColumnModel();
			 columnModel.getColumn(column).setCellRenderer( this );
	            columnModel.getColumn(column).setCellEditor( this );
		}

		public Component getTableCellRendererComponent(JTable table,
				Object value, boolean isSelected, boolean hasFocus, int row
				, int column) {
			// TODO Auto-generated method stub

			

			return rendererLabel ;
		}

		public Component getTableCellEditorComponent(
	            JTable table, Object value, boolean isSelected, int row, int column)
		{

            return rendererLabel ;
        }

		public Object getCellEditorValue() {
			// TODO Auto-generated method stub
			return text;
		}

		public void mousePerformed(ActionEvent ev) {
			// TODO Auto-generated method stub




			JOptionPane.showMessageDialog(null, "UOBS BUTTON PRESSED",
					"BUTTON PRESSED"
					,JOptionPane.ERROR_MESSAGE);
		}



	}

[Rob Camick]

Don't create a custom renderer. JTable already has a renderer to display images.

Just override the getColumnClass(....) method to return Icon.class and the Icon renderer will be used.

[Rob Spoor]

And if you want to keep your class because of the MouseListener, all you need to do is change the background colour inside the getTableCellRendererComponent method. Take a look at the source of DefaultTableCellRenderer (inside the src.zip file in your JDK root directory) for how you could do that.

[buntha Choudhary]

@Rob..

I tried to change the code as suggested by you ..
So I added rendererLabel.setBackground(Color.BLUE); inside renderer getter method but I am not getting the expected.
On looking over the source code-

  public Component getTableCellRendererComponent(JTable table,
                    Object value, boolean isSelected, boolean hasFocus,
                    int row, int column) {

                Color fg = null;
                Color bg = null;

                JTable.DropLocation dropLocation = table.getDropLocation();
                if (dropLocation != null && !dropLocation.isInsertRow()
                        && !dropLocation.isInsertColumn()
                        && dropLocation.getRow() == row
                        && dropLocation.getColumn() == column) {

                    fg = UIManager.getColor("Table.dropCellForeground");
                    bg = UIManager.getColor("Table.dropCellBackground");

                    isSelected = true;
                }

                if (isSelected) {
                    super .setForeground(fg == null ? table
                            .getSelectionForeground() : fg);
                    super .setBackground(bg == null ? table
                            .getSelectionBackground() : bg);
                } else {
                    super 
                            .setForeground(unselectedForeground != null ? unselectedForeground
                                    : table.getForeground());
                    super 
                            .setBackground(unselectedBackground != null ? unselectedBackground
                                    : table.getBackground());
                }

                setFont(table.getFont());

                if (hasFocus) {
                    Border border = null;
                    if (isSelected) {
                        border = UIManager
                                .getBorder("Table.focusSelectedCellHighlightBorder");
                    }
                    if (border == null) {
                        border = UIManager
                                .getBorder("Table.focusCellHighlightBorder");
                    }
                    setBorder(border);

                    if (!isSelected && table.isCellEditable(row, column)) {
                        Color col;
                        col = UIManager.getColor("Table.focusCellForeground");
                        if (col != null) {
                            super .setForeground(col);
                        }
                        col = UIManager.getColor("Table.focusCellBackground");
                        if (col != null) {
                            super .setBackground(col);
                        }
                    }
                } else {
                    setBorder(getNoFocusBorder());
                }

                setValue(value);

                return this ;
            }

setBackground was the method need to be changed or I am somewhere wrong.
Please suggest.

[Rob Spoor]

The renderer component also needs to be opaque.

[buntha Choudhary]

Thanks,

Solution I got by this way -

   rendererLabel.setOpaque(true);
		
		if(isSelected)
		rendererLabel.setBackground( table.getSelectionBackground());
		else
		rendererLabel.setBackground(Color.WHITE);

[buntha Choudhary]

Now everything as expected is working fine.. but I realized a thing while working on the same ..
Actually when the JTable window opens and if I click directly on the JLabel (image) based Column , then the image is gone for a while and the table returns the selected row as -1.
One more point is that the Row selection as well restricted to the previous column.

Precisely , If my Table has 4 column and Image(JLabel) is on the column number 4th, then if I directly click on the image or column 4th , then the row selection happens till the 3rd column and it returns the row selection as -1.
But If I select any other column, the everything is proper and works fine.

I am still using the same logic what I mentioned previously. What is the mistake I am committing.