Forums Register Login

Writing To A File, Prefered Procedure

+Pie Number of slices to send: Send
I've just recently taken to trying to learn Java, and I've been reading up on some books and viewing the pages and pages of documentation. I've been programming in C for 10+ years now and I know the pitfalls of developing bad habits when learning something new, so I'm hoping the Java experts here can help guide me in the ways I'm doing things wrong, how to do things better, and hopefully explain some of the inner workings of Java.

Anyway, I've been working on creating some simple Java programs trying to gain familiarity with the language, and with regards to writing to a file, I'm curious as the best way to go about it?



This is what I wrote up.

Any significant blemishes here?
+Pie Number of slices to send: Send
No, just a few minor things to be aware of.

1) Relative paths. Just like in other contexts, without a leading "/" for unix or "C:/", for Windows, or whatever indicates and absolute path in your file system, the file name will be relative to the user's current working directory. This can lead to confusion, as beginners often assume there's some relationship between that directory and where the main class lives. There's not. Just like executing any other program it's where you current "are" when you invoke the java executable. This is really an OS/shell/file system issue, rather than a Java one, but class files and classpath seem to confuse people.

2) You didn't call newLine(), or whatever BR's method of that nature is. Not a problem here, but if you call write() again, the two will be run together.

3) No need for an explicit flush() here, as close() calls flush().

4) This is the only significant error I see: You should always call close() in a finally block. Such as:
+Pie Number of slices to send: Send
Welcome to the Ranch!

There is one flaw in your code - you may not always close the file. If an exception occurs while writing or flushing, the file will not be closed. By using a try-finally block (or try-with-resources since Java 7) you can ensure that it will:
+Pie Number of slices to send: Send
 

Rob Spoor wrote:


<nitpick>
You should wrap the close() call in a try/catch. You don't want an exception in close() to change the way the overall try statement completes.

 
Goodbye moon men. Hello tiny ad:
a bit of art, as a gift, the permaculture playing cards
https://gardener-gift.com


reply
reply
This thread has been viewed 785 times.
Similar Threads
Question about File, FileWriter + BufferedWriter
Error messgae
BufferedWriter - writing a variable
Is there a way to append text to a File on a specific line or location.
Head First Java QuizCardBuilder not saving files correctly
Building a Better World in your Backyard by Paul Wheaton and Shawn Klassen-Koop
More...

All times above are in ranch (not your local) time.
The current ranch time is
Mar 19, 2024 08:05:08.