JMS sender (Stateless EJB) sends message even if transaction fails

[Nitin Bhardwaj]

Dear Friends,

I've used the Container Managed Transaction in the JMS sender code (TestJMS.java) which sends message to a JMS Queue. The JMS message receiver is an MDB (TestJMSReceiver.java).
Problem: I want that if an exception is thrown inside the sender code TestJMS-->sendMessageTest1(String s) then the transaction should be rolled back which means:
(i) The Entity JmsTestTable should not be saved (look inside sendMessageTest1() method of TestJMS.java)
(ii) The JMS Message sent should be destroyed and it should not be received by JMS Receiver-MDB (TestJMSReceiver).
The (i) option happens but not the (ii) one. This means that message is still being sent to Queue and it is still received by the MDB which is clear from the logs generated by MDB.
The code listing follows:

Sender: TestJMS....method: sendMessageTest1(String s)

package com.ejb.session.stateless;

import javax.annotation.Resource;
import javax.ejb.EJB;
import javax.ejb.SessionContext;
import javax.ejb.Stateless;
import javax.ejb.TransactionAttribute;
import javax.ejb.TransactionAttributeType;
import javax.ejb.TransactionManagement;
import javax.jms.Connection;
import javax.jms.ConnectionFactory;
import javax.jms.Destination;
import javax.jms.JMSException;
import javax.jms.MessageProducer;
import javax.jms.ObjectMessage;
import javax.jms.Session;

import com.ejb.eao.JmsTestEAOLocal;
import com.paatshala.model.JmsTestTable;

/**
 * Session Bean implementation class TestJMS
 */
@Stateless
@TransactionManagement
public class TestJMS implements TestJMSRemote, TestJMSLocal {

    public TestJMS() {

    }

    @Resource(mappedName="java:/PaathshalaConnectionFactory")
    private ConnectionFactory connectionFactory;
    
    @Resource(mappedName="jms/PaatshalaJMSQueue1")
    private Destination destQueue;
    
    @Resource
    private SessionContext context;
    
    @EJB
	private TeacherEAOLocal teacherEao;

    @EJB
	private JmsTestEAOLocal jmsTestEao;
    
    @TransactionAttribute(TransactionAttributeType.REQUIRED)
    public void sendMessageTest1(String s)
    {
    	System.out.println("TestJMS-->sendMessageTest1()--> EJB CONTAINER MANAGED TRANSACTION ENABLED by DEFAULT coz TestJMS is a stateless EJB sending JMS message. Read:http://docs.oracle.com/javaee/6/tutorial/doc/bncgl.html***************************Nitin");
    	Connection conn=null;
    	Session session=null;
    	try {
			conn= connectionFactory.createConnection();
			session=conn.createSession(false, Session.AUTO_ACKNOWLEDGE);
			//session=conn.createSession(true, Session.SESSION_TRANSACTED);
			MessageProducer producer=session.createProducer(destQueue);
			ObjectMessage message=session.createObjectMessage();			
			message.setObject(s);
			producer.send(message);
			
			// Trying to persist an entity. It should not get saved if Exception occurs in this transaction.
			JmsTestTable js=new JmsTestTable();
			js.setMessage("[JMS Client]"+s);
			jmsTestEao.makePersistent(js);
			
			throw new Exception("Throwing Exception. If this transaction is rolled back, the message produced (and probably sent to queue) should be destroyed before it is delivered by the JMS Provider to the MDB listening on the same Queue.");				
			
		} 
    	catch (JMSException e) 
    	{
			e.printStackTrace();
			System.out.println("Hi Nitin --> TestJMS EJB-->sendTeacherMessage()-->Rolling back transaction after JMS Exception");
			context.setRollbackOnly();
		}
    	catch(Exception ex)
    	{
    		ex.printStackTrace();
    		System.out.println("Hi Nitin --> TestJMS EJB-->sendTeacherMessage()-->Rolling back transaction after Exception");
			context.setRollbackOnly();
    	}
    	finally{
    		try {
				session.close();
				conn.close();
			} catch (JMSException e) {
				e.printStackTrace();
				session=null;
				conn=null;
			}
			
    	}

   }
}

MDB: TestJMSReceiver

package com.ejb.mdb;

import javax.annotation.Resource;
import javax.ejb.ActivationConfigProperty;
import javax.ejb.EJB;
import javax.ejb.MessageDriven;
import javax.ejb.MessageDrivenContext;
import javax.ejb.TransactionAttribute;
import javax.ejb.TransactionAttributeType;
import javax.ejb.TransactionManagement;
import javax.jms.JMSException;
import javax.jms.Message;
import javax.jms.MessageListener;
import javax.jms.ObjectMessage;

import com.ejb.eao.JmsTestEAOLocal;
import com.paatshala.model.JmsTestTable;

/**
 * Message-Driven Bean implementation class for: TestJMSReceiver
 *
 */
@MessageDriven(mappedName = "jms/PaatshalaJMSQueue1",
		activationConfig = { 
		@ActivationConfigProperty(propertyName = "destination", propertyValue = "jms/PaatshalaJMSQueue1"),
		@ActivationConfigProperty(propertyName = "destinationType", propertyValue = "javax.jms.Queue")
		}
		)
@TransactionManagement
public class TestJMSReceiver implements MessageListener {

    /**
     * Default constructor. 
     */
    public TestJMSReceiver() {
        // TODO Auto-generated constructor stub
    }
	
    @Resource
    private MessageDrivenContext context;
    	
	@EJB
	private JmsTestEAOLocal jmsTestEao;

	@TransactionAttribute(TransactionAttributeType.REQUIRED)
    public void onMessage(Message message) 
    {
    	System.out.println("Nitin-----------------------TestJMSReceiver--------------------------Nitin");
        ObjectMessage msg=(ObjectMessage)message;
        try {
			String s="[TestJMSReceiver MDB]"+(String)msg.getObject();
			System.out.println("TestJMSReceiver MDB --> String retrieved from JMS Message:"+s);
			JmsTestTable jt=new JmsTestTable();
			jt.setMessage(s);
			jmsTestEao.makePersistent(jt);		
		} catch (JMSException e) {
			e.printStackTrace();
			System.out.println("Hi Nitin --> TestJMSReceiver MDB-->onMessage()-->Rolling back transaction after JMS Exception");
			context.setRollbackOnly();
		}
        catch(Throwable t)
        {
        	t.printStackTrace();
        	System.out.println("Hi Nitin --> TestJMSReceiver MDB-->onMessage()-->Rolling back transaction after Exception");
        	context.setRollbackOnly();
        }
        
    }

}

Best Regards,
Nitin

[Mr sujeet khandelwal]

Hi,

You can use user transaction to solve this issue.

@Resource
javax.transaction.UserTransaction userTx;


try {
userTx.begin();
conn= connectionFactory.createConnection();
session=conn.createSession(false, Session.AUTO_ACKNOWLEDGE);
//session=conn.createSession(true, Session.SESSION_TRANSACTED);
MessageProducer producer=session.createProducer(destQueue);
ObjectMessage message=session.createObjectMessage();
message.setObject(s);
producer.send(message);
// Trying to persist an entity. It should not get saved if Exception occurs in this transaction.
JmsTestTable js=new JmsTestTable();
js.setMessage("[JMS Client]"+s);
jmsTestEao.makePersistent(js);
userTx.commit();
}
catch(Exception ex)
{
ex.printStackTrace();
userTx.rollback();
}

[Hebert Coelho]

Try EJBContext instead SessionContext.

Maybe it will work.