Problem Creating ZIP File

[Avi Abrami]

Greetings to you, dear Reader,
I am using java 1.6.0_30 on Windows2000
I am using the classes in the java.util.zip package to create a ZIP archive that contains all the files in a single folder.
The folder contains over 2,500 files where each file is a PDF file.
Average size of the PDF files is 20 kilobytes and there are 9 (nine) gigabytes of free space on the computer's hard disk.
The problem is that the ZIP archive does not contain all the files in the folder.
I am not getting any error messages.
Here is the code:

java.io.File folder = new java.io.File("folder_name");
java.io.FileOutputStream fos = new java.io.FileOutputStream("zip_archive_name");
java.util.zip.ZipOutputStream zos = new java.util.zip.ZipOutputStream(fos);
java.io.File[] files = folder.listFiles();
for (java.io.File f : files) {
    java.util.zip.ZipEntry entry = new java.util.zip.ZipEntry(f.getName());
    entry.setTime(f.lastModified());
    zos.putNextEntry(entry);
    java.io.FileInputStream fis = new java.io.FileInputStream(f);
    byte[] buf = new byte[8192];
    int cnt = -1;
    while ((cnt = fis.read(buf)) > 0) {
        zos.write(buf);
    }
    fis.close();
    zos.flush();
    zos.closeEntry();
}
zos.close();

Note that I have run the above code when the folder contains only 50 files and all the files where added to the ZIP archive.

Thanks,
Avi.

[Paul Clapham]

Well, I would suggest you should fix your file-copying logic so it copies the whole file and nothing but the file. However regardless of the fact that you're putting extra garbage into the archive, that isn't causing the problem you describe.

Have you considered doing any debugging? Like watching the code and seeing what it actually does? Or have you considered looking at the data to see which files are being written and which aren't? Just telling us there's a problem isn't very helpful. What would be helpful would be information of that type.

[Avi Abrami]

Dear Paul,
Thank you for your reply. In it you write:

I would suggest you should fix your file-copying logic so it copies the whole file and nothing but the file

I would greatly appreciate it if you would show me code to achieve this.
You also wrote:

have you considered looking at the data to see which files are being written and which aren't

I have already done this.
As I wrote in my original post: The code works fine when there are 50 files in the folder.
Note that among the 50 files are those which are not included in the ZIP archive when the folder contains over 2,500 files and all 50 files are added successfully to the ZIP archive. Indeed I can extract them from the created ZIP and view them with Acrobat Reader without any problem.

Cheers,
Avi.

[Paul Clapham]

In line 13, don't write the whole buffer. Just write the part of the buffer which the read() method filled.

As for the rest of your post, I think it says your problem is solved, although I find it difficult to extract a meaning from that sentence.